Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
Am 2014-05-05 14:36, schrieb Dan Carpenter: > On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote: >> Am 2014-05-05 13:35, schrieb Dan Carpenter: >>> On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: Use dev_err() instead of printk() and remove "dgnc:" from the message. This should provide userspace with more useful information and use the common kernel coding style. >>> >>> Whenever I see a "RESEND" in a subject and no explanation then it means >>> our development process has broken down. Meanwhile this is the first >>> time I have seen this patch so the problem is not on our side. >>> >>> regards, >>> dan carpenter >>> >> >> I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week >> or so. I don't see any breakdown. > > What I'm saying is just put an explanation after the --- cut off so we > know what you did wrong the first time. > > Signed-off-by ... > --- > Resending because I sent it to the wrong email list the first time. > Oops! Next time I will use get_maintainer.pl, I promise! > > > Just a simple explanation like that is ok. > > regards, > dan carpenter > sure, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote: > Am 2014-05-05 13:35, schrieb Dan Carpenter: > > On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: > >> Use dev_err() instead of printk() and remove "dgnc:" from the message. > >> This should provide userspace with more useful information and use > >> the common kernel coding style. > >> > > > > Whenever I see a "RESEND" in a subject and no explanation then it means > > our development process has broken down. Meanwhile this is the first > > time I have seen this patch so the problem is not on our side. > > > > regards, > > dan carpenter > > > > I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week > or so. I don't see any breakdown. What I'm saying is just put an explanation after the --- cut off so we know what you did wrong the first time. Signed-off-by ... --- Resending because I sent it to the wrong email list the first time. Oops! Next time I will use get_maintainer.pl, I promise! Just a simple explanation like that is ok. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
Am 2014-05-05 13:35, schrieb Dan Carpenter: > On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: >> Use dev_err() instead of printk() and remove "dgnc:" from the message. >> This should provide userspace with more useful information and use >> the common kernel coding style. >> > > Whenever I see a "RESEND" in a subject and no explanation then it means > our development process has broken down. Meanwhile this is the first > time I have seen this patch so the problem is not on our side. > > regards, > dan carpenter > I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week or so. I don't see any breakdown. martin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: > Use dev_err() instead of printk() and remove "dgnc:" from the message. > This should provide userspace with more useful information and use > the common kernel coding style. > Whenever I see a "RESEND" in a subject and no explanation then it means our development process has broken down. Meanwhile this is the first time I have seen this patch so the problem is not on our side. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
Use dev_err() instead of printk() and remove "dgnc:" from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..88a2106 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device
*c)
ret = sysfs_create_group(>kobj, _tty_attribute_group);
if (ret) {
- printk(KERN_ERR "dgnc: failed to create sysfs tty device
attributes.\n");
+ dev_err(c, "failed to create sysfs tty device attributes.\n");
sysfs_remove_group(>kobj, _tty_attribute_group);
return;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
Use dev_err() instead of printk() and remove dgnc: from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..88a2106 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device
*c)
ret = sysfs_create_group(c-kobj, dgnc_tty_attribute_group);
if (ret) {
- printk(KERN_ERR dgnc: failed to create sysfs tty device
attributes.\n);
+ dev_err(c, failed to create sysfs tty device attributes.\n);
sysfs_remove_group(c-kobj, dgnc_tty_attribute_group);
return;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: Use dev_err() instead of printk() and remove dgnc: from the message. This should provide userspace with more useful information and use the common kernel coding style. Whenever I see a RESEND in a subject and no explanation then it means our development process has broken down. Meanwhile this is the first time I have seen this patch so the problem is not on our side. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
Am 2014-05-05 13:35, schrieb Dan Carpenter: On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: Use dev_err() instead of printk() and remove dgnc: from the message. This should provide userspace with more useful information and use the common kernel coding style. Whenever I see a RESEND in a subject and no explanation then it means our development process has broken down. Meanwhile this is the first time I have seen this patch so the problem is not on our side. regards, dan carpenter I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week or so. I don't see any breakdown. martin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote: Am 2014-05-05 13:35, schrieb Dan Carpenter: On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: Use dev_err() instead of printk() and remove dgnc: from the message. This should provide userspace with more useful information and use the common kernel coding style. Whenever I see a RESEND in a subject and no explanation then it means our development process has broken down. Meanwhile this is the first time I have seen this patch so the problem is not on our side. regards, dan carpenter I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week or so. I don't see any breakdown. What I'm saying is just put an explanation after the --- cut off so we know what you did wrong the first time. Signed-off-by ... --- Resending because I sent it to the wrong email list the first time. Oops! Next time I will use get_maintainer.pl, I promise! Just a simple explanation like that is ok. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
Am 2014-05-05 14:36, schrieb Dan Carpenter: On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote: Am 2014-05-05 13:35, schrieb Dan Carpenter: On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: Use dev_err() instead of printk() and remove dgnc: from the message. This should provide userspace with more useful information and use the common kernel coding style. Whenever I see a RESEND in a subject and no explanation then it means our development process has broken down. Meanwhile this is the first time I have seen this patch so the problem is not on our side. regards, dan carpenter I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week or so. I don't see any breakdown. What I'm saying is just put an explanation after the --- cut off so we know what you did wrong the first time. Signed-off-by ... --- Resending because I sent it to the wrong email list the first time. Oops! Next time I will use get_maintainer.pl, I promise! Just a simple explanation like that is ok. regards, dan carpenter sure, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: dgnc: use dev_err() instead of printk()
Use dev_err() insted of printk() and remove "dgnc:" from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
This makes probably more sense than the previous one.
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..88a2106 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device
*c)
ret = sysfs_create_group(>kobj, _tty_attribute_group);
if (ret) {
- printk(KERN_ERR "dgnc: failed to create sysfs tty device
attributes.\n");
+ dev_err(c, "failed to create sysfs tty device attributes.\n");
sysfs_remove_group(>kobj, _tty_attribute_group);
return;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: dgnc: use dev_err() instead of printk()
Use dev_err() insted of printk() in order to provice userspace with
more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..0f0e8fc 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device
*c)
ret = sysfs_create_group(>kobj, _tty_attribute_group);
if (ret) {
- printk(KERN_ERR "dgnc: failed to create sysfs tty device
attributes.\n");
+ dev_err(c, "dgnc: failed to create sysfs tty device
attributes.\n");
sysfs_remove_group(>kobj, _tty_attribute_group);
return;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: dgnc: use dev_err() instead of printk()
Use dev_err() insted of printk() in order to provice userspace with
more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..0f0e8fc 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device
*c)
ret = sysfs_create_group(c-kobj, dgnc_tty_attribute_group);
if (ret) {
- printk(KERN_ERR dgnc: failed to create sysfs tty device
attributes.\n);
+ dev_err(c, dgnc: failed to create sysfs tty device
attributes.\n);
sysfs_remove_group(c-kobj, dgnc_tty_attribute_group);
return;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: dgnc: use dev_err() instead of printk()
Use dev_err() insted of printk() and remove dgnc: from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This makes probably more sense than the previous one.
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..88a2106 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device
*c)
ret = sysfs_create_group(c-kobj, dgnc_tty_attribute_group);
if (ret) {
- printk(KERN_ERR dgnc: failed to create sysfs tty device
attributes.\n);
+ dev_err(c, failed to create sysfs tty device attributes.\n);
sysfs_remove_group(c-kobj, dgnc_tty_attribute_group);
return;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
