Re: [PATCH] staging: exfat: fix uninitialized variable ret
On Fri, Aug 30, 2019 at 07:46:44PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Currently there are error return paths in ffsReadFile that
> exit via lable err_out that return and uninitialized error
> return in variable ret. Fix this by initializing ret to zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: c48c9f7ff32b ("staging: exfat: add exfat filesystem code to staging")
> Signed-off-by: Colin Ian King
Clang also warns about this:
drivers/staging/exfat/exfat_super.c:885:6: warning: variable 'ret' is used
uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (p_fs->dev_ejected)
^
drivers/staging/exfat/exfat_super.c:892:9: note: uninitialized use occurs here
return ret;
^~~
drivers/staging/exfat/exfat_super.c:885:2: note: remove the 'if' if its
condition is always true
if (p_fs->dev_ejected)
^~
drivers/staging/exfat/exfat_super.c:776:9: note: initialize the variable 'ret'
to silence this warning
int ret;
^
= 0
1 warning generated.
Reviewed-by: Nathan Chancellor
[PATCH] staging: exfat: fix uninitialized variable ret
From: Colin Ian King
Currently there are error return paths in ffsReadFile that
exit via lable err_out that return and uninitialized error
return in variable ret. Fix this by initializing ret to zero.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: c48c9f7ff32b ("staging: exfat: add exfat filesystem code to staging")
Signed-off-by: Colin Ian King
---
drivers/staging/exfat/exfat_super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging/exfat/exfat_super.c
index 5b3c4dfe0ecc..6939aa4f25ee 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -771,7 +771,7 @@ static int ffsReadFile(struct inode *inode, struct
file_id_t *fid, void *buffer,
{
s32 offset, sec_offset, clu_offset;
u32 clu;
- int ret;
+ int ret = 0;
sector_t LogSector;
u64 oneblkread, read_bytes;
struct buffer_head *tmp_bh = NULL;
--
2.20.1
