Re: [PATCH] staging: fbtft: Made into two lines
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: > Oh! Sorry! I made the changes to correct the faults you figured out. > Is it okay now? Better. Also, submit it again with proper commit message and put "PATCH v2" in the subject. > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/fbtft/fb_pcd8544.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_pcd8544.c > b/drivers/staging/fbtft/fb_pcd8544.c > index cf87ce8..925511f 100644 > --- a/drivers/staging/fbtft/fb_pcd8544.c > +++ b/drivers/staging/fbtft/fb_pcd8544.c > @@ -34,8 +34,8 @@ > #define WIDTH 84 > #define HEIGHT 48 > #define TXBUFLEN (84*6) > -#define DEFAULT_GAMMA "40" > /* gamma is used to control contrast in this driver */ Aren't these two supposed to be on the same line? I think your patch is a bit messed up. Doublecheck this. > +#define DEFAULT_GAMMA "40" > > static unsigned tc; > module_param(tc, uint, 0); > -- > 1.7.9.5 > > ___ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: fbtft: Made into two lines
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: > Oh! Sorry! I made the changes to correct the faults you figured out. > Is it okay now? Resubmit it properly with "PATCH v2" in the title and a good commit message. > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/fbtft/fb_pcd8544.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_pcd8544.c > b/drivers/staging/fbtft/fb_pcd8544.c > index cf87ce8..925511f 100644 > --- a/drivers/staging/fbtft/fb_pcd8544.c > +++ b/drivers/staging/fbtft/fb_pcd8544.c > @@ -34,8 +34,8 @@ > #define WIDTH 84 > #define HEIGHT 48 > #define TXBUFLEN (84*6) > -#define DEFAULT_GAMMA "40" > /* gamma is used to control contrast in this driver */ Isn't this comment supposed to be on the previous line (the removed line)? Check if you haven't messed this up > +#define DEFAULT_GAMMA "40" > > static unsigned tc; > module_param(tc, uint, 0); > -- > 1.7.9.5 > > ___ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: fbtft: Made into two lines
On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote:
> Made the comment into a new lineto remove a coding style error detected
> by checkpatch.
> The warning is given below:
> drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters
>
> Signed-off-by: Aparna Karuthodi
> ---
Please update your tree. This will also not apply for:
4178549e4c47 ("Staging: fbtft: fb_pcd8544: Fix comments style")
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: fbtft: Made into two lines
On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: Made the comment into a new lineto remove a coding style error detected by checkpatch. The warning is given below: drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com --- Please update your tree. This will also not apply for: 4178549e4c47 (Staging: fbtft: fb_pcd8544: Fix comments style) regards sudip -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: fbtft: Made into two lines
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Resubmit it properly with PATCH v2 in the title and a good commit message. Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index cf87ce8..925511f 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -34,8 +34,8 @@ #define WIDTH 84 #define HEIGHT 48 #define TXBUFLEN (84*6) -#define DEFAULT_GAMMA 40 /* gamma is used to control contrast in this driver */ Isn't this comment supposed to be on the previous line (the removed line)? Check if you haven't messed this up +#define DEFAULT_GAMMA 40 static unsigned tc; module_param(tc, uint, 0); -- 1.7.9.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: fbtft: Made into two lines
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Better. Also, submit it again with proper commit message and put PATCH v2 in the subject. Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index cf87ce8..925511f 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -34,8 +34,8 @@ #define WIDTH 84 #define HEIGHT 48 #define TXBUFLEN (84*6) -#define DEFAULT_GAMMA 40 /* gamma is used to control contrast in this driver */ Aren't these two supposed to be on the same line? I think your patch is a bit messed up. Doublecheck this. +#define DEFAULT_GAMMA 40 static unsigned tc; module_param(tc, uint, 0); -- 1.7.9.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: fbtft: Made into two lines
Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Signed-off-by: Aparna Karuthodi --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index cf87ce8..925511f 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -34,8 +34,8 @@ #define WIDTH 84 #define HEIGHT 48 #define TXBUFLEN (84*6) -#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */ +#define DEFAULT_GAMMA "40" static unsigned tc; module_param(tc, uint, 0); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: fbtft: Made into two lines
On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: > Made the comment into a new lineto remove a coding style error detected > by checkpatch. > The warning is given below: > drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/fbtft/fb_pcd8544.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_pcd8544.c > b/drivers/staging/fbtft/fb_pcd8544.c > index 8b9ebfb..cf87ce8 100644 > --- a/drivers/staging/fbtft/fb_pcd8544.c > +++ b/drivers/staging/fbtft/fb_pcd8544.c > @@ -34,7 +34,8 @@ > #define WIDTH 84 > #define HEIGHT 48 > #define TXBUFLEN (84*6) > -#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this > driver */ > +#define DEFAULT_GAMMA "40" > +/* gamma is used to control contrast in this driver */ I think the format is usually: /* comment */ #define FOO BAR > > static unsigned tc; > module_param(tc, uint, 0); > -- > 1.7.9.5 > > ___ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: fbtft: Made into two lines
On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: Made the comment into a new lineto remove a coding style error detected by checkpatch. The warning is given below: drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com --- drivers/staging/fbtft/fb_pcd8544.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index 8b9ebfb..cf87ce8 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -34,7 +34,8 @@ #define WIDTH 84 #define HEIGHT 48 #define TXBUFLEN (84*6) -#define DEFAULT_GAMMA 40 /* gamma is used to control contrast in this driver */ +#define DEFAULT_GAMMA 40 +/* gamma is used to control contrast in this driver */ I think the format is usually: /* comment */ #define FOO BAR static unsigned tc; module_param(tc, uint, 0); -- 1.7.9.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: fbtft: Made into two lines
Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index cf87ce8..925511f 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -34,8 +34,8 @@ #define WIDTH 84 #define HEIGHT 48 #define TXBUFLEN (84*6) -#define DEFAULT_GAMMA 40 /* gamma is used to control contrast in this driver */ +#define DEFAULT_GAMMA 40 static unsigned tc; module_param(tc, uint, 0); -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: fbtft: Made into two lines
Made the comment into a new lineto remove a coding style error detected by checkpatch. The warning is given below: drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters Signed-off-by: Aparna Karuthodi --- drivers/staging/fbtft/fb_pcd8544.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index 8b9ebfb..cf87ce8 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -34,7 +34,8 @@ #define WIDTH 84 #define HEIGHT 48 #define TXBUFLEN (84*6) -#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */ +#define DEFAULT_GAMMA "40" +/* gamma is used to control contrast in this driver */ static unsigned tc; module_param(tc, uint, 0); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: fbtft: Made into two lines
Made the comment into a new lineto remove a coding style error detected by checkpatch. The warning is given below: drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com --- drivers/staging/fbtft/fb_pcd8544.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index 8b9ebfb..cf87ce8 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -34,7 +34,8 @@ #define WIDTH 84 #define HEIGHT 48 #define TXBUFLEN (84*6) -#define DEFAULT_GAMMA 40 /* gamma is used to control contrast in this driver */ +#define DEFAULT_GAMMA 40 +/* gamma is used to control contrast in this driver */ static unsigned tc; module_param(tc, uint, 0); -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
