Re: [PATCH] staging: fsl-mc: Add missing header
On 02/13/2017 06:40 PM, Bogdan Purcareata wrote: > Compiling the fsl-mc bus driver will yield a couple of static analysis > errors: > warning: symbol 'fsl_mc_msi_domain_alloc_irqs' was not declared > warning: symbol 'fsl_mc_msi_domain_free_irqs' was not declared. > warning: symbol 'its_fsl_mc_msi_init' was not declared. > warning: symbol 'its_fsl_mc_msi_cleanup' was not declared. > > Since these are properly declared, but the header is not included, add > it in the source files. This way the symbol is properly exported. > > Signed-off-by: Bogdan Purcareata> --- > Sent against staging-testing. > > drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 + > drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > index 7975c6e..b8b2c86 100644 > --- a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > @@ -17,6 +17,7 @@ > #include > #include > #include "../include/mc-bus.h" > +#include "fsl-mc-private.h" > > /* >* Generate a unique ID identifying the interrupt (only used within the MSI > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > index 0e2c1b5..87e4471 100644 > --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > @@ -17,6 +17,7 @@ > #include > #include > #include "../include/mc-bus.h" > +#include "fsl-mc-private.h" > > static struct irq_chip its_msi_irq_chip = { > .name = "ITS-fMSI", > Acked-by: Laurentiu Tudor --- Best Regards, Laurentiu
Re: [PATCH] staging: fsl-mc: Add missing header
On 02/13/2017 06:40 PM, Bogdan Purcareata wrote: > Compiling the fsl-mc bus driver will yield a couple of static analysis > errors: > warning: symbol 'fsl_mc_msi_domain_alloc_irqs' was not declared > warning: symbol 'fsl_mc_msi_domain_free_irqs' was not declared. > warning: symbol 'its_fsl_mc_msi_init' was not declared. > warning: symbol 'its_fsl_mc_msi_cleanup' was not declared. > > Since these are properly declared, but the header is not included, add > it in the source files. This way the symbol is properly exported. > > Signed-off-by: Bogdan Purcareata > --- > Sent against staging-testing. > > drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 + > drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > index 7975c6e..b8b2c86 100644 > --- a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > @@ -17,6 +17,7 @@ > #include > #include > #include "../include/mc-bus.h" > +#include "fsl-mc-private.h" > > /* >* Generate a unique ID identifying the interrupt (only used within the MSI > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > index 0e2c1b5..87e4471 100644 > --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > @@ -17,6 +17,7 @@ > #include > #include > #include "../include/mc-bus.h" > +#include "fsl-mc-private.h" > > static struct irq_chip its_msi_irq_chip = { > .name = "ITS-fMSI", > Acked-by: Laurentiu Tudor --- Best Regards, Laurentiu
[PATCH] staging: fsl-mc: Add missing header
Compiling the fsl-mc bus driver will yield a couple of static analysis errors: warning: symbol 'fsl_mc_msi_domain_alloc_irqs' was not declared warning: symbol 'fsl_mc_msi_domain_free_irqs' was not declared. warning: symbol 'its_fsl_mc_msi_init' was not declared. warning: symbol 'its_fsl_mc_msi_cleanup' was not declared. Since these are properly declared, but the header is not included, add it in the source files. This way the symbol is properly exported. Signed-off-by: Bogdan Purcareata--- Sent against staging-testing. drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 + drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c index 7975c6e..b8b2c86 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c @@ -17,6 +17,7 @@ #include #include #include "../include/mc-bus.h" +#include "fsl-mc-private.h" /* * Generate a unique ID identifying the interrupt (only used within the MSI diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c index 0e2c1b5..87e4471 100644 --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c @@ -17,6 +17,7 @@ #include #include #include "../include/mc-bus.h" +#include "fsl-mc-private.h" static struct irq_chip its_msi_irq_chip = { .name = "ITS-fMSI", -- 1.9.1
[PATCH] staging: fsl-mc: Add missing header
Compiling the fsl-mc bus driver will yield a couple of static analysis errors: warning: symbol 'fsl_mc_msi_domain_alloc_irqs' was not declared warning: symbol 'fsl_mc_msi_domain_free_irqs' was not declared. warning: symbol 'its_fsl_mc_msi_init' was not declared. warning: symbol 'its_fsl_mc_msi_cleanup' was not declared. Since these are properly declared, but the header is not included, add it in the source files. This way the symbol is properly exported. Signed-off-by: Bogdan Purcareata --- Sent against staging-testing. drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 + drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c index 7975c6e..b8b2c86 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c @@ -17,6 +17,7 @@ #include #include #include "../include/mc-bus.h" +#include "fsl-mc-private.h" /* * Generate a unique ID identifying the interrupt (only used within the MSI diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c index 0e2c1b5..87e4471 100644 --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c @@ -17,6 +17,7 @@ #include #include #include "../include/mc-bus.h" +#include "fsl-mc-private.h" static struct irq_chip its_msi_irq_chip = { .name = "ITS-fMSI", -- 1.9.1