Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

[Dan Carpenter]

On Tue, Feb 16, 2016 at 10:39:05PM -0800, shalin mehta wrote:
> Hello,
> 
> Should I send this patch again due the spelling mistake in the patch
> description?
> 


Yes.  And put what Oleg Drokin said about it worked because there were
no users in the changelog.

regards,
dan carpenter

Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

[Dan Carpenter]

On Tue, Feb 16, 2016 at 10:39:05PM -0800, shalin mehta wrote:
> Hello,
> 
> Should I send this patch again due the spelling mistake in the patch
> description?
> 


Yes.  And put what Oleg Drokin said about it worked because there were
no users in the changelog.

regards,
dan carpenter

Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

[shalin mehta]

Hello,

Should I send this patch again due the spelling mistake in the patch
description?

Thanks,
Shalin

On Mon, Feb 15, 2016 at 6:51 PM, Drokin, Oleg  wrote:
>
> On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
>
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>>
>> Signed-off-by: Shalin Mehta 
>> ---
>> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h 
>> b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> index 0d3ed87..4f9e9ad 100644
>> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> @@ -365,10 +365,10 @@
>> #define LDLM_TEST_FLAG(_l, _b)(((_l)->l_flags & (_b)) != 0)
>>
>> /** set a ldlm_lock flag bit */
>> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
>> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
>>
>> /** clear a ldlm_lock flag bit */
>> -#define LDLM_CLEAR_FLAG(_l, _b)   (((_l)->l_flags &= ~(_b))
>> +#define LDLM_CLEAR_FLAG(_l, _b)   ((_l)->l_flags &= ~(_b))
>>
>> /** Mask of flags inherited from parent lock when doing intents. */
>> #define LDLM_INHERIT_FLAGSLDLM_FL_INHERIT_MASK
>
> Acked-by: Oleg Drokin 
>

Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

[shalin mehta]

Hello,

Should I send this patch again due the spelling mistake in the patch
description?

Thanks,
Shalin

On Mon, Feb 15, 2016 at 6:51 PM, Drokin, Oleg  wrote:
>
> On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
>
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>>
>> Signed-off-by: Shalin Mehta 
>> ---
>> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h 
>> b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> index 0d3ed87..4f9e9ad 100644
>> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> @@ -365,10 +365,10 @@
>> #define LDLM_TEST_FLAG(_l, _b)(((_l)->l_flags & (_b)) != 0)
>>
>> /** set a ldlm_lock flag bit */
>> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
>> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
>>
>> /** clear a ldlm_lock flag bit */
>> -#define LDLM_CLEAR_FLAG(_l, _b)   (((_l)->l_flags &= ~(_b))
>> +#define LDLM_CLEAR_FLAG(_l, _b)   ((_l)->l_flags &= ~(_b))
>>
>> /** Mask of flags inherited from parent lock when doing intents. */
>> #define LDLM_INHERIT_FLAGSLDLM_FL_INHERIT_MASK
>
> Acked-by: Oleg Drokin 
>

Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

[Drokin, Oleg]

On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:

> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
> 
> Signed-off-by: Shalin Mehta 
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h 
> b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> index 0d3ed87..4f9e9ad 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> @@ -365,10 +365,10 @@
> #define LDLM_TEST_FLAG(_l, _b)(((_l)->l_flags & (_b)) != 0)
> 
> /** set a ldlm_lock flag bit */
> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
> 
> /** clear a ldlm_lock flag bit */
> -#define LDLM_CLEAR_FLAG(_l, _b)   (((_l)->l_flags &= ~(_b))
> +#define LDLM_CLEAR_FLAG(_l, _b)   ((_l)->l_flags &= ~(_b))
> 
> /** Mask of flags inherited from parent lock when doing intents. */
> #define LDLM_INHERIT_FLAGSLDLM_FL_INHERIT_MASK

Acked-by: Oleg Drokin 

Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

[Drokin, Oleg]

On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:

> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
> 
> Signed-off-by: Shalin Mehta 
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h 
> b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> index 0d3ed87..4f9e9ad 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> @@ -365,10 +365,10 @@
> #define LDLM_TEST_FLAG(_l, _b)(((_l)->l_flags & (_b)) != 0)
> 
> /** set a ldlm_lock flag bit */
> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
> 
> /** clear a ldlm_lock flag bit */
> -#define LDLM_CLEAR_FLAG(_l, _b)   (((_l)->l_flags &= ~(_b))
> +#define LDLM_CLEAR_FLAG(_l, _b)   ((_l)->l_flags &= ~(_b))
> 
> /** Mask of flags inherited from parent lock when doing intents. */
> #define LDLM_INHERIT_FLAGSLDLM_FL_INHERIT_MASK

Acked-by: Oleg Drokin 

Re: [PATCH] staging: lustre: Fixed the parenthesis

[Drokin, Oleg]

On Feb 15, 2016, at 9:28 PM, Greg KH wrote:

> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
> 
> "fixed" in what way?  Did you test-build this patch?  Also, you
> mispelled a word here…

The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.

The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.

Compiles work with or without this fix as the result (I also just checked
just to be sure).

Re: [PATCH] staging: lustre: Fixed the parenthesis

[Drokin, Oleg]

On Feb 15, 2016, at 9:28 PM, Greg KH wrote:

> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
> 
> "fixed" in what way?  Did you test-build this patch?  Also, you
> mispelled a word here…

The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.

The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.

Compiles work with or without this fix as the result (I also just checked
just to be sure).

Re: [PATCH] staging: lustre: Fixed the parenthesis

[Greg KH]

On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.

"fixed" in what way?  Did you test-build this patch?  Also, you
mispelled a word here...

thanks,

greg k-h

Re: [PATCH] staging: lustre: Fixed the parenthesis

[Greg KH]

On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.

"fixed" in what way?  Did you test-build this patch?  Also, you
mispelled a word here...

thanks,

greg k-h

[PATCH] staging: lustre: Fixed the parenthesis

[Shalin Mehta]

The parentehsis are fixed in the macro for the ldlm lock to set and
clear the flags.

Signed-off-by: Shalin Mehta 
---
 drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h 
b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
index 0d3ed87..4f9e9ad 100644
--- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
+++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
@@ -365,10 +365,10 @@
 #define LDLM_TEST_FLAG(_l, _b)(((_l)->l_flags & (_b)) != 0)
 
 /** set a ldlm_lock flag bit */
-#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
+#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
 
 /** clear a ldlm_lock flag bit */
-#define LDLM_CLEAR_FLAG(_l, _b)   (((_l)->l_flags &= ~(_b))
+#define LDLM_CLEAR_FLAG(_l, _b)   ((_l)->l_flags &= ~(_b))
 
 /** Mask of flags inherited from parent lock when doing intents. */
 #define LDLM_INHERIT_FLAGSLDLM_FL_INHERIT_MASK
-- 
1.9.1

[PATCH] staging: lustre: Fixed the parenthesis

[Shalin Mehta]

The parentehsis are fixed in the macro for the ldlm lock to set and
clear the flags.

Signed-off-by: Shalin Mehta 
---
 drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h 
b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
index 0d3ed87..4f9e9ad 100644
--- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
+++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
@@ -365,10 +365,10 @@
 #define LDLM_TEST_FLAG(_l, _b)(((_l)->l_flags & (_b)) != 0)
 
 /** set a ldlm_lock flag bit */
-#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
+#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
 
 /** clear a ldlm_lock flag bit */
-#define LDLM_CLEAR_FLAG(_l, _b)   (((_l)->l_flags &= ~(_b))
+#define LDLM_CLEAR_FLAG(_l, _b)   ((_l)->l_flags &= ~(_b))
 
 /** Mask of flags inherited from parent lock when doing intents. */
 #define LDLM_INHERIT_FLAGSLDLM_FL_INHERIT_MASK
-- 
1.9.1