Re: [PATCH] staging: lustre: lustre: ptlrpc: Fix space required
On Thu, Aug 21, 2014 at 06:59:07PM +0530, Hema Prathaban wrote:
> This patch fixes the checkpatch.pl issue
> Error: Required space after " '+' ',' '=' '(' ' if' "
>
> Signed-off-by: Hema Prathaban
> ---
> drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
> drivers/staging/lustre/lustre/ptlrpc/events.c | 4 ++--
> drivers/staging/lustre/lustre/ptlrpc/import.c | 8
> drivers/staging/lustre/lustre/ptlrpc/llog_client.c | 16
> drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 6 +++---
> drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 2 +-
> drivers/staging/lustre/lustre/ptlrpc/sec_config.c | 6 +++---
> drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 +-
> drivers/staging/lustre/lustre/ptlrpc/service.c | 2 +-
> 9 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
> b/drivers/staging/lustre/lustre/ptlrpc/client.c
> index 8fa9b71..a327d19 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/client.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
> @@ -289,7 +289,7 @@ static void ptlrpc_at_adj_net_latency(struct
> ptlrpc_request *req,
> at = >rq_import->imp_at;
>
> /* Network latency is total time less server processing time */
> - nl = max_t(int, now - req->rq_sent - service_time, 0) +1/*st rounding*/;
> + nl = max_t(int, now - req->rq_sent - service_time, 0) + 1/*st
> rounding*/;
> if (service_time > now - req->rq_sent + 3 /* bz16408 */)
> CWARN("Reported service time %u > total measured time "
> CFS_DURATION_T"\n", service_time,
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c
> b/drivers/staging/lustre/lustre/ptlrpc/events.c
> index c3ec21d..9f5af45 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/events.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/events.c
> @@ -186,7 +186,7 @@ void client_bulk_callback(lnet_event_t *ev)
> if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB, CFS_FAIL_ONCE))
> ev->status = -EIO;
>
> - if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,CFS_FAIL_ONCE))
> + if (CFS_FAIL_CHECK_ORSEuT(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,
> CFS_FAIL_ONCE))
You obviously did not compile this code as it breaks the build :(
Please _always_ test build your patches, don't force others to find
errors like this, it's a huge waste of time on my end when it happens...
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: lustre: lustre: ptlrpc: Fix space required
On Thu, Aug 21, 2014 at 06:59:07PM +0530, Hema Prathaban wrote:
This patch fixes the checkpatch.pl issue
Error: Required space after '+' ',' '=' '(' ' if'
Signed-off-by: Hema Prathaban hemakl...@gmail.com
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/events.c | 4 ++--
drivers/staging/lustre/lustre/ptlrpc/import.c | 8
drivers/staging/lustre/lustre/ptlrpc/llog_client.c | 16
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 6 +++---
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/sec_config.c | 6 +++---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/service.c | 2 +-
9 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
b/drivers/staging/lustre/lustre/ptlrpc/client.c
index 8fa9b71..a327d19 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/client.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
@@ -289,7 +289,7 @@ static void ptlrpc_at_adj_net_latency(struct
ptlrpc_request *req,
at = req-rq_import-imp_at;
/* Network latency is total time less server processing time */
- nl = max_t(int, now - req-rq_sent - service_time, 0) +1/*st rounding*/;
+ nl = max_t(int, now - req-rq_sent - service_time, 0) + 1/*st
rounding*/;
if (service_time now - req-rq_sent + 3 /* bz16408 */)
CWARN(Reported service time %u total measured time
CFS_DURATION_T\n, service_time,
diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c
b/drivers/staging/lustre/lustre/ptlrpc/events.c
index c3ec21d..9f5af45 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/events.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/events.c
@@ -186,7 +186,7 @@ void client_bulk_callback(lnet_event_t *ev)
if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB, CFS_FAIL_ONCE))
ev-status = -EIO;
- if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,CFS_FAIL_ONCE))
+ if (CFS_FAIL_CHECK_ORSEuT(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,
CFS_FAIL_ONCE))
You obviously did not compile this code as it breaks the build :(
Please _always_ test build your patches, don't force others to find
errors like this, it's a huge waste of time on my end when it happens...
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: lustre: lustre: ptlrpc: Fix space required
This patch fixes the checkpatch.pl issue
Error: Required space after " '+' ',' '=' '(' ' if' "
Signed-off-by: Hema Prathaban
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/events.c | 4 ++--
drivers/staging/lustre/lustre/ptlrpc/import.c | 8
drivers/staging/lustre/lustre/ptlrpc/llog_client.c | 16
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 6 +++---
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/sec_config.c | 6 +++---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/service.c | 2 +-
9 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
b/drivers/staging/lustre/lustre/ptlrpc/client.c
index 8fa9b71..a327d19 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/client.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
@@ -289,7 +289,7 @@ static void ptlrpc_at_adj_net_latency(struct ptlrpc_request
*req,
at = >rq_import->imp_at;
/* Network latency is total time less server processing time */
- nl = max_t(int, now - req->rq_sent - service_time, 0) +1/*st rounding*/;
+ nl = max_t(int, now - req->rq_sent - service_time, 0) + 1/*st
rounding*/;
if (service_time > now - req->rq_sent + 3 /* bz16408 */)
CWARN("Reported service time %u > total measured time "
CFS_DURATION_T"\n", service_time,
diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c
b/drivers/staging/lustre/lustre/ptlrpc/events.c
index c3ec21d..9f5af45 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/events.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/events.c
@@ -186,7 +186,7 @@ void client_bulk_callback(lnet_event_t *ev)
if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB, CFS_FAIL_ONCE))
ev->status = -EIO;
- if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,CFS_FAIL_ONCE))
+ if (CFS_FAIL_CHECK_ORSEuT(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,
CFS_FAIL_ONCE))
ev->status = -EIO;
CDEBUG((ev->status == 0) ? D_NET : D_ERROR,
@@ -481,7 +481,7 @@ int ptlrpc_uuid_to_peer(struct obd_uuid *uuid,
}
}
- CDEBUG(D_NET,"%s->%s\n", uuid->uuid, libcfs_id2str(*peer));
+ CDEBUG(D_NET, "%s->%s\n", uuid->uuid, libcfs_id2str(*peer));
return rc;
}
diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c
b/drivers/staging/lustre/lustre/ptlrpc/import.c
index 771b213..5b5c049 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/import.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/import.c
@@ -297,7 +297,7 @@ void ptlrpc_invalidate_import(struct obd_import *imp)
timeout = 1;
}
- CDEBUG(D_RPCTRACE,"Sleeping %d sec for inflight to error out\n",
+ CDEBUG(D_RPCTRACE, "Sleeping %d sec for inflight to error
out\n",
timeout);
/* Wait for all requests to error out and call completion
@@ -843,7 +843,7 @@ static int ptlrpc_connect_interpret(const struct lu_env
*env,
if ((ocd->ocd_connect_flags & imp->imp_connect_flags_orig) !=
ocd->ocd_connect_flags) {
CERROR("%s: Server didn't granted asked subset of flags:
asked=%#llx grranted=%#llx\n",
- imp->imp_obd->obd_name,imp->imp_connect_flags_orig,
+ imp->imp_obd->obd_name, imp->imp_connect_flags_orig,
ocd->ocd_connect_flags);
GOTO(out, rc = -EPROTO);
}
@@ -921,7 +921,7 @@ static int ptlrpc_connect_interpret(const struct lu_env
*env,
* participate since we can reestablish all of our state
* with server again */
if ((MSG_CONNECT_RECOVERING & msg_flags)) {
- CDEBUG(level,"%s@%s changed server handle from
%#llx to %#llx but is still in recovery\n",
+ CDEBUG(level, "%s@%s changed server handle from
%#llx to %#llx but is still in recovery\n",
obd2cli_tgt(imp->imp_obd),
imp->imp_connection->c_remote_uuid.uuid,
imp->imp_remote_handle.cookie,
@@ -1103,7 +1103,7 @@ finish:
* Enforce ADLER for backward compatibility*/
cli->cl_supp_cksum_types = OBD_CKSUM_ADLER;
}
- cli->cl_cksum_type =cksum_type_select(cli->cl_supp_cksum_types);
+ cli->cl_cksum_type =
cksum_type_select(cli->cl_supp_cksum_types);
if (ocd->ocd_connect_flags & OBD_CONNECT_BRW_SIZE)
cli->cl_max_pages_per_rpc =
diff --git a/drivers/staging/lustre/lustre/ptlrpc/llog_client.c
[PATCH] staging: lustre: lustre: ptlrpc: Fix space required
This patch fixes the checkpatch.pl issue
Error: Required space after '+' ',' '=' '(' ' if'
Signed-off-by: Hema Prathaban hemakl...@gmail.com
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/events.c | 4 ++--
drivers/staging/lustre/lustre/ptlrpc/import.c | 8
drivers/staging/lustre/lustre/ptlrpc/llog_client.c | 16
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 6 +++---
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/sec_config.c | 6 +++---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/service.c | 2 +-
9 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
b/drivers/staging/lustre/lustre/ptlrpc/client.c
index 8fa9b71..a327d19 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/client.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
@@ -289,7 +289,7 @@ static void ptlrpc_at_adj_net_latency(struct ptlrpc_request
*req,
at = req-rq_import-imp_at;
/* Network latency is total time less server processing time */
- nl = max_t(int, now - req-rq_sent - service_time, 0) +1/*st rounding*/;
+ nl = max_t(int, now - req-rq_sent - service_time, 0) + 1/*st
rounding*/;
if (service_time now - req-rq_sent + 3 /* bz16408 */)
CWARN(Reported service time %u total measured time
CFS_DURATION_T\n, service_time,
diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c
b/drivers/staging/lustre/lustre/ptlrpc/events.c
index c3ec21d..9f5af45 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/events.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/events.c
@@ -186,7 +186,7 @@ void client_bulk_callback(lnet_event_t *ev)
if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB, CFS_FAIL_ONCE))
ev-status = -EIO;
- if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,CFS_FAIL_ONCE))
+ if (CFS_FAIL_CHECK_ORSEuT(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,
CFS_FAIL_ONCE))
ev-status = -EIO;
CDEBUG((ev-status == 0) ? D_NET : D_ERROR,
@@ -481,7 +481,7 @@ int ptlrpc_uuid_to_peer(struct obd_uuid *uuid,
}
}
- CDEBUG(D_NET,%s-%s\n, uuid-uuid, libcfs_id2str(*peer));
+ CDEBUG(D_NET, %s-%s\n, uuid-uuid, libcfs_id2str(*peer));
return rc;
}
diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c
b/drivers/staging/lustre/lustre/ptlrpc/import.c
index 771b213..5b5c049 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/import.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/import.c
@@ -297,7 +297,7 @@ void ptlrpc_invalidate_import(struct obd_import *imp)
timeout = 1;
}
- CDEBUG(D_RPCTRACE,Sleeping %d sec for inflight to error out\n,
+ CDEBUG(D_RPCTRACE, Sleeping %d sec for inflight to error
out\n,
timeout);
/* Wait for all requests to error out and call completion
@@ -843,7 +843,7 @@ static int ptlrpc_connect_interpret(const struct lu_env
*env,
if ((ocd-ocd_connect_flags imp-imp_connect_flags_orig) !=
ocd-ocd_connect_flags) {
CERROR(%s: Server didn't granted asked subset of flags:
asked=%#llx grranted=%#llx\n,
- imp-imp_obd-obd_name,imp-imp_connect_flags_orig,
+ imp-imp_obd-obd_name, imp-imp_connect_flags_orig,
ocd-ocd_connect_flags);
GOTO(out, rc = -EPROTO);
}
@@ -921,7 +921,7 @@ static int ptlrpc_connect_interpret(const struct lu_env
*env,
* participate since we can reestablish all of our state
* with server again */
if ((MSG_CONNECT_RECOVERING msg_flags)) {
- CDEBUG(level,%s@%s changed server handle from
%#llx to %#llx but is still in recovery\n,
+ CDEBUG(level, %s@%s changed server handle from
%#llx to %#llx but is still in recovery\n,
obd2cli_tgt(imp-imp_obd),
imp-imp_connection-c_remote_uuid.uuid,
imp-imp_remote_handle.cookie,
@@ -1103,7 +1103,7 @@ finish:
* Enforce ADLER for backward compatibility*/
cli-cl_supp_cksum_types = OBD_CKSUM_ADLER;
}
- cli-cl_cksum_type =cksum_type_select(cli-cl_supp_cksum_types);
+ cli-cl_cksum_type =
cksum_type_select(cli-cl_supp_cksum_types);
if (ocd-ocd_connect_flags OBD_CONNECT_BRW_SIZE)
cli-cl_max_pages_per_rpc =
diff --git a/drivers/staging/lustre/lustre/ptlrpc/llog_client.c
b/drivers/staging/lustre/lustre/ptlrpc/llog_client.c
index
