Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-31 Thread Ramon Fried 
Hi Greg
Thanks for your patience. this is the first time I doing it...
I created the patch against linux-next, I will do it again and send it.
Regarding CC's, this is the output of get_maintainer script, how do I
extract the relevant people out of its output ?
Warm regards,
Ramon.

On Sun, Aug 31, 2014 at 3:32 AM, Greg Kroah-Hartman
 wrote:
> On Sun, Aug 31, 2014 at 03:16:48AM +0300, Ramon Fried wrote:
>> This patch fixes the following checkpatch.pl warnings:
>>
>> WARNING: Possible unnecessary 'out of memory' message
>> #146: FILE: ./xlr_net.c:146:
>> +   if (!skb) {
>> +   pr_err("SKB allocation failed\n");
>>
>> WARNING: Missing a blank line after declarations
>> #1107: FILE: ./xlr_net.c:1107:
>> +   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
>> +   unregister_netdev(priv->ndev);
>>
>> Signed-off-by: Ramon Fried 
>
> This is two different things, and as such, should be sent in 2 different
> patches?
>
> Also, you sent this to a lot of people, did they all really need it?
>
>> ---
>>  drivers/staging/netlogic/xlr_net.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/netlogic/xlr_net.c 
>> b/drivers/staging/netlogic/xlr_net.c
>> index 9bf407d..28a42831 100644
>> --- a/drivers/staging/netlogic/xlr_net.c
>> +++ b/drivers/staging/netlogic/xlr_net.c
>> @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
>>
>>   /* skb->data is cache aligned */
>>   skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
>> - if (!skb) {
>> - pr_err("SKB allocation failed\n");
>> + if (!skb)
>>   return NULL;
>> - }
>>   mac_put_skb_back_ptr(skb);
>>   return skb;
>>  }
>> @@ -1104,6 +1102,7 @@ err_gmac:
>>  static int xlr_net_remove(struct platform_device *pdev)
>>  {
>>   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
>> +
>>   unregister_netdev(priv->ndev);
>>   mdiobus_unregister(priv->mii_bus);
>>   mdiobus_free(priv->mii_bus);
>
> Finally, this patch doesn't apply at all to my tree, so even if I wanted
> to apply it, I couldn't.  Please refresh it against the staging-next
> branch of the staging.git tree on git.kernel.org, and if it is still
> relevant (hint, half of it isn't), then redo it and resend.
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-31 Thread Ramon Fried 
Hi Greg
Thanks for your patience. this is the first time I doing it...
I created the patch against linux-next, I will do it again and send it.
Regarding CC's, this is the output of get_maintainer script, how do I
extract the relevant people out of its output ?
Warm regards,
Ramon.

On Sun, Aug 31, 2014 at 3:32 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
 On Sun, Aug 31, 2014 at 03:16:48AM +0300, Ramon Fried wrote:
 This patch fixes the following checkpatch.pl warnings:

 WARNING: Possible unnecessary 'out of memory' message
 #146: FILE: ./xlr_net.c:146:
 +   if (!skb) {
 +   pr_err(SKB allocation failed\n);

 WARNING: Missing a blank line after declarations
 #1107: FILE: ./xlr_net.c:1107:
 +   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
 +   unregister_netdev(priv-ndev);

 Signed-off-by: Ramon Fried ramon.fr...@gmail.com

 This is two different things, and as such, should be sent in 2 different
 patches?

 Also, you sent this to a lot of people, did they all really need it?

 ---
  drivers/staging/netlogic/xlr_net.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

 diff --git a/drivers/staging/netlogic/xlr_net.c 
 b/drivers/staging/netlogic/xlr_net.c
 index 9bf407d..28a42831 100644
 --- a/drivers/staging/netlogic/xlr_net.c
 +++ b/drivers/staging/netlogic/xlr_net.c
 @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)

   /* skb-data is cache aligned */
   skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
 - if (!skb) {
 - pr_err(SKB allocation failed\n);
 + if (!skb)
   return NULL;
 - }
   mac_put_skb_back_ptr(skb);
   return skb;
  }
 @@ -1104,6 +1102,7 @@ err_gmac:
  static int xlr_net_remove(struct platform_device *pdev)
  {
   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
 +
   unregister_netdev(priv-ndev);
   mdiobus_unregister(priv-mii_bus);
   mdiobus_free(priv-mii_bus);

 Finally, this patch doesn't apply at all to my tree, so even if I wanted
 to apply it, I couldn't.  Please refresh it against the staging-next
 branch of the staging.git tree on git.kernel.org, and if it is still
 relevant (hint, half of it isn't), then redo it and resend.

 thanks,

 greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-30 Thread Greg Kroah-Hartman 
On Sun, Aug 31, 2014 at 03:16:48AM +0300, Ramon Fried wrote:
> This patch fixes the following checkpatch.pl warnings:
> 
> WARNING: Possible unnecessary 'out of memory' message
> #146: FILE: ./xlr_net.c:146:
> +   if (!skb) {
> +   pr_err("SKB allocation failed\n");
> 
> WARNING: Missing a blank line after declarations
> #1107: FILE: ./xlr_net.c:1107:
> +   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> +   unregister_netdev(priv->ndev);
> 
> Signed-off-by: Ramon Fried 

This is two different things, and as such, should be sent in 2 different
patches?

Also, you sent this to a lot of people, did they all really need it?

> ---
>  drivers/staging/netlogic/xlr_net.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.c 
> b/drivers/staging/netlogic/xlr_net.c
> index 9bf407d..28a42831 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
>  
>   /* skb->data is cache aligned */
>   skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
> - if (!skb) {
> - pr_err("SKB allocation failed\n");
> + if (!skb)
>   return NULL;
> - }
>   mac_put_skb_back_ptr(skb);
>   return skb;
>  }
> @@ -1104,6 +1102,7 @@ err_gmac:
>  static int xlr_net_remove(struct platform_device *pdev)
>  {
>   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> +
>   unregister_netdev(priv->ndev);
>   mdiobus_unregister(priv->mii_bus);
>   mdiobus_free(priv->mii_bus);

Finally, this patch doesn't apply at all to my tree, so even if I wanted
to apply it, I couldn't.  Please refresh it against the staging-next
branch of the staging.git tree on git.kernel.org, and if it is still
relevant (hint, half of it isn't), then redo it and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-30 Thread Ramon Fried 
This patch fixes the following checkpatch.pl warnings:

WARNING: Possible unnecessary 'out of memory' message
#146: FILE: ./xlr_net.c:146:
+   if (!skb) {
+   pr_err("SKB allocation failed\n");

WARNING: Missing a blank line after declarations
#1107: FILE: ./xlr_net.c:1107:
+   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+   unregister_netdev(priv->ndev);

Signed-off-by: Ramon Fried 
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/netlogic/xlr_net.c 
b/drivers/staging/netlogic/xlr_net.c
index 9bf407d..28a42831 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
/* skb->data is cache aligned */
skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-   if (!skb) {
-   pr_err("SKB allocation failed\n");
+   if (!skb)
return NULL;
-   }
mac_put_skb_back_ptr(skb);
return skb;
 }
@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
unregister_netdev(priv->ndev);
mdiobus_unregister(priv->mii_bus);
mdiobus_free(priv->mii_bus);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-30 Thread Greg KH 
On Sat, Aug 30, 2014 at 10:54:32PM +0300, Ramon Fried wrote:
> This patch fixes the following checkpatch.pl warnings:
> 
> WARNING: Possible unnecessary 'out of memory' message
> #146: FILE: ./xlr_net.c:146:
> + if (!skb) {
> + pr_err("SKB allocation failed\n");
> 
> WARNING: Missing a blank line after declarations
> #1107: FILE: ./xlr_net.c:1107:
> + struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> + unregister_netdev(priv->ndev);

> >From 27b58d9b1d39ab99bf6022b82ac9e602621b2822 Mon Sep 17 00:00:00 2001
> From: Ramon Fried 
> Date: Sat, 30 Aug 2014 22:26:11 +0300
> Subject: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings
> 
> Signed-off-by: Ramon Fried 

WHy did you not put the information above in the changelog area here?

And why send a patch as an attachment, I can't do much of anything with
that :(

Also, please use the scripts/get_maintainer.pl tool to determine who and
what mailing lists to cc: for a patch.

Please fix this up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-30 Thread Ramon Fried 
This patch fixes the following checkpatch.pl warnings:

WARNING: Possible unnecessary 'out of memory' message
#146: FILE: ./xlr_net.c:146:
+   if (!skb) {
+   pr_err("SKB allocation failed\n");

WARNING: Missing a blank line after declarations
#1107: FILE: ./xlr_net.c:1107:
+   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+   unregister_netdev(priv->ndev);
>From 27b58d9b1d39ab99bf6022b82ac9e602621b2822 Mon Sep 17 00:00:00 2001
From: Ramon Fried 
Date: Sat, 30 Aug 2014 22:26:11 +0300
Subject: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

Signed-off-by: Ramon Fried 
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
index 9bf407d..28a42831 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
 	/* skb->data is cache aligned */
 	skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-	if (!skb) {
-		pr_err("SKB allocation failed\n");
+	if (!skb)
 		return NULL;
-	}
 	mac_put_skb_back_ptr(skb);
 	return skb;
 }
@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
 	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
 	unregister_netdev(priv->ndev);
 	mdiobus_unregister(priv->mii_bus);
 	mdiobus_free(priv->mii_bus);
-- 
1.9.1

[PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-30 Thread Ramon Fried 
This patch fixes the following checkpatch.pl warnings:

WARNING: Possible unnecessary 'out of memory' message
#146: FILE: ./xlr_net.c:146:
+   if (!skb) {
+   pr_err(SKB allocation failed\n);

WARNING: Missing a blank line after declarations
#1107: FILE: ./xlr_net.c:1107:
+   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+   unregister_netdev(priv-ndev);
From 27b58d9b1d39ab99bf6022b82ac9e602621b2822 Mon Sep 17 00:00:00 2001
From: Ramon Fried ramon.fr...@gmail.com
Date: Sat, 30 Aug 2014 22:26:11 +0300
Subject: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

Signed-off-by: Ramon Fried ramon.fr...@gmail.com
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
index 9bf407d..28a42831 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
 	/* skb-data is cache aligned */
 	skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-	if (!skb) {
-		pr_err(SKB allocation failed\n);
+	if (!skb)
 		return NULL;
-	}
 	mac_put_skb_back_ptr(skb);
 	return skb;
 }
@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
 	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
 	unregister_netdev(priv-ndev);
 	mdiobus_unregister(priv-mii_bus);
 	mdiobus_free(priv-mii_bus);
-- 
1.9.1

Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-30 Thread Greg KH 
On Sat, Aug 30, 2014 at 10:54:32PM +0300, Ramon Fried wrote:
 This patch fixes the following checkpatch.pl warnings:
 
 WARNING: Possible unnecessary 'out of memory' message
 #146: FILE: ./xlr_net.c:146:
 + if (!skb) {
 + pr_err(SKB allocation failed\n);
 
 WARNING: Missing a blank line after declarations
 #1107: FILE: ./xlr_net.c:1107:
 + struct xlr_net_priv *priv = platform_get_drvdata(pdev);
 + unregister_netdev(priv-ndev);

 From 27b58d9b1d39ab99bf6022b82ac9e602621b2822 Mon Sep 17 00:00:00 2001
 From: Ramon Fried ramon.fr...@gmail.com
 Date: Sat, 30 Aug 2014 22:26:11 +0300
 Subject: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings
 
 Signed-off-by: Ramon Fried ramon.fr...@gmail.com

WHy did you not put the information above in the changelog area here?

And why send a patch as an attachment, I can't do much of anything with
that :(

Also, please use the scripts/get_maintainer.pl tool to determine who and
what mailing lists to cc: for a patch.

Please fix this up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-30 Thread Ramon Fried 
This patch fixes the following checkpatch.pl warnings:

WARNING: Possible unnecessary 'out of memory' message
#146: FILE: ./xlr_net.c:146:
+   if (!skb) {
+   pr_err(SKB allocation failed\n);

WARNING: Missing a blank line after declarations
#1107: FILE: ./xlr_net.c:1107:
+   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+   unregister_netdev(priv-ndev);

Signed-off-by: Ramon Fried ramon.fr...@gmail.com
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/netlogic/xlr_net.c 
b/drivers/staging/netlogic/xlr_net.c
index 9bf407d..28a42831 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
/* skb-data is cache aligned */
skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-   if (!skb) {
-   pr_err(SKB allocation failed\n);
+   if (!skb)
return NULL;
-   }
mac_put_skb_back_ptr(skb);
return skb;
 }
@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
unregister_netdev(priv-ndev);
mdiobus_unregister(priv-mii_bus);
mdiobus_free(priv-mii_bus);
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

2014-08-30 Thread Greg Kroah-Hartman 
On Sun, Aug 31, 2014 at 03:16:48AM +0300, Ramon Fried wrote:
 This patch fixes the following checkpatch.pl warnings:
 
 WARNING: Possible unnecessary 'out of memory' message
 #146: FILE: ./xlr_net.c:146:
 +   if (!skb) {
 +   pr_err(SKB allocation failed\n);
 
 WARNING: Missing a blank line after declarations
 #1107: FILE: ./xlr_net.c:1107:
 +   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
 +   unregister_netdev(priv-ndev);
 
 Signed-off-by: Ramon Fried ramon.fr...@gmail.com

This is two different things, and as such, should be sent in 2 different
patches?

Also, you sent this to a lot of people, did they all really need it?

 ---
  drivers/staging/netlogic/xlr_net.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/staging/netlogic/xlr_net.c 
 b/drivers/staging/netlogic/xlr_net.c
 index 9bf407d..28a42831 100644
 --- a/drivers/staging/netlogic/xlr_net.c
 +++ b/drivers/staging/netlogic/xlr_net.c
 @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
  
   /* skb-data is cache aligned */
   skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
 - if (!skb) {
 - pr_err(SKB allocation failed\n);
 + if (!skb)
   return NULL;
 - }
   mac_put_skb_back_ptr(skb);
   return skb;
  }
 @@ -1104,6 +1102,7 @@ err_gmac:
  static int xlr_net_remove(struct platform_device *pdev)
  {
   struct xlr_net_priv *priv = platform_get_drvdata(pdev);
 +
   unregister_netdev(priv-ndev);
   mdiobus_unregister(priv-mii_bus);
   mdiobus_free(priv-mii_bus);

Finally, this patch doesn't apply at all to my tree, so even if I wanted
to apply it, I couldn't.  Please refresh it against the staging-next
branch of the staging.git tree on git.kernel.org, and if it is still
relevant (hint, half of it isn't), then redo it and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/