Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Joe Perches 
On Sat, 2017-12-02 at 19:15 +0200, Marcus Wolf wrote:
> Can you give me a hint, how to invoke the checkpatch.pl.

There are lots of ways.

I suggest reading the output of $ ./scripts/checkpatch.pl --help

For instance:

[ after the fact checking ]

$ git checkout -b 
  [ commit one or more changes ]
$ git format-patch - -o  
$ ./scripts/checkpatch.pl /*

[ or pipe git diff output to checkpatch ]

$ git checkout -b 
  [ edit files and save changes ]
$ git diff --stat -p | ./scripts/checkpatch.pl

[ or run checkpatch on a particular commit ]

$ ./scripts/checkpatch -g 

[ or run checkpatch.pl on a range of commits ]

$ ./scripts/checkpatch.pl -g

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Joe Perches 
On Sat, 2017-12-02 at 19:15 +0200, Marcus Wolf wrote:
> Can you give me a hint, how to invoke the checkpatch.pl.

There are lots of ways.

I suggest reading the output of $ ./scripts/checkpatch.pl --help

For instance:

[ after the fact checking ]

$ git checkout -b 
  [ commit one or more changes ]
$ git format-patch - -o  
$ ./scripts/checkpatch.pl /*

[ or pipe git diff output to checkpatch ]

$ git checkout -b 
  [ edit files and save changes ]
$ git diff --stat -p | ./scripts/checkpatch.pl

[ or run checkpatch on a particular commit ]

$ ./scripts/checkpatch -g 

[ or run checkpatch.pl on a range of commits ]

$ ./scripts/checkpatch.pl -g

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Marcus Wolf 



Am 02.12.2017 um 18:46 schrieb Joe Perches:

On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote:

rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header and declared it staic in
the implemtation.
Signed-off-by: Marcus Wolf 
---
  drivers/staging/pi433/rf69.c |2 +-
  drivers/staging/pi433/rf69.h |1 -
  2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index ec4b540..90ccf4e 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -442,7 +442,7 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
}
  }
  
-int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum dccPercent dccPercent)

+static int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 
reg, enum dccPercent dccPercent)
  {
switch (dccPercent) {
case dcc16Percent:  return rmw(spi, reg, MASK_BW_DCC_FREQ, 
BW_DCC_16_PERCENT);
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index 645c8df..7f580e9 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -36,7 +36,6 @@
  int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance 
antennaImpedance);
  int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
  enum lnaGain rf69_get_lna_gain(struct spi_device *spi);
-int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum 
dccPercent dccPercent);
  int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent 
dccPercent);
  int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum 
dccPercent dccPercent);
  int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 
exponent);


Beyond the basics of learning to submit patches by
shutting up checkpatch messages, please always keep
in mind how to actually improve the logic and code
clarity for human readers.

The rf69_set_dc_cut_off_frequency_intern function
is actually pretty poorly written.

It's repeated logic that could be simplified and
code size reduced quite a bit.

For instance, the patch below makes it more obvious
what the function does and reduces boiler-plate
copy/paste to a single line.

And I don't particularly care that it is not
checkpatch 'clean'.  checkpatch is only a stupid,
mindless style checker.  Always try to be better
than a mindless script.

and you -really- want to make it checkpatch clean,
a new #define could be used like this below

#define case_dcc_percent(val, dcc, DCC) \
case dcc: val = DCC; break;

Anyway:

$ size drivers/staging/pi433/rf69.o*
text   data bss dec hex 
filename
   35820   5600   0   41420a1cc 
drivers/staging/pi433/rf69.o.new
   36968   5600   0   42568a648 
drivers/staging/pi433/rf69.o.old
---
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e69a2153c999..9e40f162ac77 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -423,19 +423,23 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
  
  int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum dccPercent dccPercent)

  {
+   int val;
+
switch (dccPercent) {
-   case dcc16Percent:  return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_16_PERCENT));
-   case dcc8Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_8_PERCENT));
-   case dcc4Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_4_PERCENT));
-   case dcc2Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_2_PERCENT));
-   case dcc1Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_1_PERCENT));
-   case dcc0_5Percent: return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_5_PERCENT));
-   case dcc0_25Percent:return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_25_PERCENT));
-   case dcc0_125Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_125_PERCENT));
+   case dcc16Percent:  val = BW_DCC_16_PERCENT; break;
+   case dcc8Percent:   val = BW_DCC_8_PERCENT; break;
+   case dcc4Percent:   val = BW_DCC_4_PERCENT; break;
+   case dcc2Percent:   val = BW_DCC_2_PERCENT; break;
+   case dcc1Percent:   val = BW_DCC_1_PERCENT; break;
+   case dcc0_5Percent: val = BW_DCC_0_5_PERCENT; break;
+   case dcc0_25Percent:val = BW_DCC_0_25_PERCENT; break;
+   case dcc0_125Percent:   val = BW_DCC_0_125_PERCENT; break;
default:
dev_dbg(>dev, "set: illegal input param");
return -EINVAL;
}
+
+   return WRITE_REG(reg,

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Marcus Wolf 



Am 02.12.2017 um 18:46 schrieb Joe Perches:

On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote:

rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header and declared it staic in
the implemtation.
Signed-off-by: Marcus Wolf 
---
  drivers/staging/pi433/rf69.c |2 +-
  drivers/staging/pi433/rf69.h |1 -
  2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index ec4b540..90ccf4e 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -442,7 +442,7 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
}
  }
  
-int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum dccPercent dccPercent)

+static int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 
reg, enum dccPercent dccPercent)
  {
switch (dccPercent) {
case dcc16Percent:  return rmw(spi, reg, MASK_BW_DCC_FREQ, 
BW_DCC_16_PERCENT);
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index 645c8df..7f580e9 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -36,7 +36,6 @@
  int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance 
antennaImpedance);
  int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
  enum lnaGain rf69_get_lna_gain(struct spi_device *spi);
-int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum 
dccPercent dccPercent);
  int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent 
dccPercent);
  int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum 
dccPercent dccPercent);
  int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 
exponent);


Beyond the basics of learning to submit patches by
shutting up checkpatch messages, please always keep
in mind how to actually improve the logic and code
clarity for human readers.

The rf69_set_dc_cut_off_frequency_intern function
is actually pretty poorly written.

It's repeated logic that could be simplified and
code size reduced quite a bit.

For instance, the patch below makes it more obvious
what the function does and reduces boiler-plate
copy/paste to a single line.

And I don't particularly care that it is not
checkpatch 'clean'.  checkpatch is only a stupid,
mindless style checker.  Always try to be better
than a mindless script.

and you -really- want to make it checkpatch clean,
a new #define could be used like this below

#define case_dcc_percent(val, dcc, DCC) \
case dcc: val = DCC; break;

Anyway:

$ size drivers/staging/pi433/rf69.o*
text   data bss dec hex 
filename
   35820   5600   0   41420a1cc 
drivers/staging/pi433/rf69.o.new
   36968   5600   0   42568a648 
drivers/staging/pi433/rf69.o.old
---
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e69a2153c999..9e40f162ac77 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -423,19 +423,23 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
  
  int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum dccPercent dccPercent)

  {
+   int val;
+
switch (dccPercent) {
-   case dcc16Percent:  return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_16_PERCENT));
-   case dcc8Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_8_PERCENT));
-   case dcc4Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_4_PERCENT));
-   case dcc2Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_2_PERCENT));
-   case dcc1Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_1_PERCENT));
-   case dcc0_5Percent: return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_5_PERCENT));
-   case dcc0_25Percent:return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_25_PERCENT));
-   case dcc0_125Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_125_PERCENT));
+   case dcc16Percent:  val = BW_DCC_16_PERCENT; break;
+   case dcc8Percent:   val = BW_DCC_8_PERCENT; break;
+   case dcc4Percent:   val = BW_DCC_4_PERCENT; break;
+   case dcc2Percent:   val = BW_DCC_2_PERCENT; break;
+   case dcc1Percent:   val = BW_DCC_1_PERCENT; break;
+   case dcc0_5Percent: val = BW_DCC_0_5_PERCENT; break;
+   case dcc0_25Percent:val = BW_DCC_0_25_PERCENT; break;
+   case dcc0_125Percent:   val = BW_DCC_0_125_PERCENT; break;
default:
dev_dbg(>dev, "set: illegal input param");
return -EINVAL;
}
+
+   return WRITE_REG(reg, (READ_REG(reg) &

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Joe Perches 
On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote:
> rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
> Therefore removed the function from header and declared it staic in
> the implemtation.
> Signed-off-by: Marcus Wolf 
> ---
>  drivers/staging/pi433/rf69.c |2 +-
>  drivers/staging/pi433/rf69.h |1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index ec4b540..90ccf4e 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -442,7 +442,7 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
>   }
>  }
>  
> -int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, 
> enum dccPercent dccPercent)
> +static int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 
> reg, enum dccPercent dccPercent)
>  {
>   switch (dccPercent) {
>   case dcc16Percent:  return rmw(spi, reg, MASK_BW_DCC_FREQ, 
> BW_DCC_16_PERCENT);
> diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
> index 645c8df..7f580e9 100644
> --- a/drivers/staging/pi433/rf69.h
> +++ b/drivers/staging/pi433/rf69.h
> @@ -36,7 +36,6 @@
>  int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance 
> antennaImpedance);
>  int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
>  enum lnaGain rf69_get_lna_gain(struct spi_device *spi);
> -int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, 
> enum dccPercent dccPercent);
>  int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent 
> dccPercent);
>  int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum 
> dccPercent dccPercent);
>  int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 
> exponent);

Beyond the basics of learning to submit patches by
shutting up checkpatch messages, please always keep
in mind how to actually improve the logic and code
clarity for human readers.

The rf69_set_dc_cut_off_frequency_intern function
is actually pretty poorly written.

It's repeated logic that could be simplified and
code size reduced quite a bit.

For instance, the patch below makes it more obvious
what the function does and reduces boiler-plate
copy/paste to a single line.

And I don't particularly care that it is not
checkpatch 'clean'.  checkpatch is only a stupid,
mindless style checker.  Always try to be better
than a mindless script.

and you -really- want to make it checkpatch clean,
a new #define could be used like this below

#define case_dcc_percent(val, dcc, DCC) \
case dcc: val = DCC; break;

Anyway:

$ size drivers/staging/pi433/rf69.o*
   textdata bss dec hex 
filename
  358205600   0   41420a1cc 
drivers/staging/pi433/rf69.o.new
  369685600   0   42568a648 
drivers/staging/pi433/rf69.o.old
---
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e69a2153c999..9e40f162ac77 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -423,19 +423,23 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
 
 int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum 
dccPercent dccPercent)
 {
+   int val;
+
switch (dccPercent) {
-   case dcc16Percent:  return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_16_PERCENT));
-   case dcc8Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_8_PERCENT));
-   case dcc4Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_4_PERCENT));
-   case dcc2Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_2_PERCENT));
-   case dcc1Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_1_PERCENT));
-   case dcc0_5Percent: return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_5_PERCENT));
-   case dcc0_25Percent:return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_25_PERCENT));
-   case dcc0_125Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_125_PERCENT));
+   case dcc16Percent:  val = BW_DCC_16_PERCENT; break;
+   case dcc8Percent:   val = BW_DCC_8_PERCENT; break;
+   case dcc4Percent:   val = BW_DCC_4_PERCENT; break;
+   case dcc2Percent:   val = BW_DCC_2_PERCENT; break;
+   case dcc1Percent:   val = BW_DCC_1_PERCENT; break;
+   case dcc0_5Percent: val = BW_DCC_0_5_PERCENT; break;
+   case dcc0_25Percent:val = BW_DCC_0_25_PERCENT; break;
+   case dcc0_125Percent:   val = BW_DCC_0_125_PERCENT; break;
default:
dev_dbg(>dev, "set: illegal input param");
return -EINVAL;
}
+
+   return WRITE_REG(reg, (READ_REG(reg)

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Joe Perches 
On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote:
> rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
> Therefore removed the function from header and declared it staic in
> the implemtation.
> Signed-off-by: Marcus Wolf 
> ---
>  drivers/staging/pi433/rf69.c |2 +-
>  drivers/staging/pi433/rf69.h |1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index ec4b540..90ccf4e 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -442,7 +442,7 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
>   }
>  }
>  
> -int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, 
> enum dccPercent dccPercent)
> +static int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 
> reg, enum dccPercent dccPercent)
>  {
>   switch (dccPercent) {
>   case dcc16Percent:  return rmw(spi, reg, MASK_BW_DCC_FREQ, 
> BW_DCC_16_PERCENT);
> diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
> index 645c8df..7f580e9 100644
> --- a/drivers/staging/pi433/rf69.h
> +++ b/drivers/staging/pi433/rf69.h
> @@ -36,7 +36,6 @@
>  int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance 
> antennaImpedance);
>  int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
>  enum lnaGain rf69_get_lna_gain(struct spi_device *spi);
> -int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, 
> enum dccPercent dccPercent);
>  int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent 
> dccPercent);
>  int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum 
> dccPercent dccPercent);
>  int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 
> exponent);

Beyond the basics of learning to submit patches by
shutting up checkpatch messages, please always keep
in mind how to actually improve the logic and code
clarity for human readers.

The rf69_set_dc_cut_off_frequency_intern function
is actually pretty poorly written.

It's repeated logic that could be simplified and
code size reduced quite a bit.

For instance, the patch below makes it more obvious
what the function does and reduces boiler-plate
copy/paste to a single line.

And I don't particularly care that it is not
checkpatch 'clean'.  checkpatch is only a stupid,
mindless style checker.  Always try to be better
than a mindless script.

and you -really- want to make it checkpatch clean,
a new #define could be used like this below

#define case_dcc_percent(val, dcc, DCC) \
case dcc: val = DCC; break;

Anyway:

$ size drivers/staging/pi433/rf69.o*
   textdata bss dec hex 
filename
  358205600   0   41420a1cc 
drivers/staging/pi433/rf69.o.new
  369685600   0   42568a648 
drivers/staging/pi433/rf69.o.old
---
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e69a2153c999..9e40f162ac77 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -423,19 +423,23 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
 
 int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum 
dccPercent dccPercent)
 {
+   int val;
+
switch (dccPercent) {
-   case dcc16Percent:  return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_16_PERCENT));
-   case dcc8Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_8_PERCENT));
-   case dcc4Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_4_PERCENT));
-   case dcc2Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_2_PERCENT));
-   case dcc1Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_1_PERCENT));
-   case dcc0_5Percent: return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_5_PERCENT));
-   case dcc0_25Percent:return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_25_PERCENT));
-   case dcc0_125Percent:   return WRITE_REG(reg, ((READ_REG(reg) & 
~MASK_BW_DCC_FREQ) | BW_DCC_0_125_PERCENT));
+   case dcc16Percent:  val = BW_DCC_16_PERCENT; break;
+   case dcc8Percent:   val = BW_DCC_8_PERCENT; break;
+   case dcc4Percent:   val = BW_DCC_4_PERCENT; break;
+   case dcc2Percent:   val = BW_DCC_2_PERCENT; break;
+   case dcc1Percent:   val = BW_DCC_1_PERCENT; break;
+   case dcc0_5Percent: val = BW_DCC_0_5_PERCENT; break;
+   case dcc0_25Percent:val = BW_DCC_0_25_PERCENT; break;
+   case dcc0_125Percent:   val = BW_DCC_0_125_PERCENT; break;
default:
dev_dbg(>dev, "set: illegal input param");
return -EINVAL;
}
+
+   return WRITE_REG(reg, (READ_REG(reg) & ~MASK_BW_DCC_FREQ) | val);

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Greg KH 

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sat, Dec 02, 2017 at 06:01:59PM +0200, Marcus Wolf wrote:
> Hi!
> 
> I am sorry :-/
> 
> Can you recover, or do I need to resend?

I do not hand-edit patches, otherwise it would be impossible for me to
keep up with the review workload...

Do what I said earlier, fix all of these, take the time, verify they are
correct and in the correct format, and then send a patch series.

thanks,

greg k-h

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Greg KH 

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sat, Dec 02, 2017 at 06:01:59PM +0200, Marcus Wolf wrote:
> Hi!
> 
> I am sorry :-/
> 
> Can you recover, or do I need to resend?

I do not hand-edit patches, otherwise it would be impossible for me to
keep up with the review workload...

Do what I said earlier, fix all of these, take the time, verify they are
correct and in the correct format, and then send a patch series.

thanks,

greg k-h

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Marcus Wolf 

Hi!

I am sorry :-/

Can you recover, or do I need to resend?

Cheers,
Marcus

Am 02.12.2017 um 17:56 schrieb Greg KH:

On Sat, Dec 02, 2017 at 05:20:22PM +0200, Marcus Wolf wrote:

rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header and declared it staic in
the implemtation.
Signed-off-by: Marcus Wolf 


No blank line before signed-off-by :(



--
Marcus Wolf

Wolf-Entwicklungen
Helene-Lange-Weg 23
80637 München

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Marcus Wolf 

Hi!

I am sorry :-/

Can you recover, or do I need to resend?

Cheers,
Marcus

Am 02.12.2017 um 17:56 schrieb Greg KH:

On Sat, Dec 02, 2017 at 05:20:22PM +0200, Marcus Wolf wrote:

rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header and declared it staic in
the implemtation.
Signed-off-by: Marcus Wolf 


No blank line before signed-off-by :(



--
Marcus Wolf

Wolf-Entwicklungen
Helene-Lange-Weg 23
80637 München

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Greg KH 
On Sat, Dec 02, 2017 at 05:20:22PM +0200, Marcus Wolf wrote:
> rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
> Therefore removed the function from header and declared it staic in
> the implemtation.
> Signed-off-by: Marcus Wolf 

No blank line before signed-off-by :(

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Greg KH 
On Sat, Dec 02, 2017 at 05:20:22PM +0200, Marcus Wolf wrote:
> rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
> Therefore removed the function from header and declared it staic in
> the implemtation.
> Signed-off-by: Marcus Wolf 

No blank line before signed-off-by :(

[PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Marcus Wolf 
rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header and declared it staic in
the implemtation.
Signed-off-by: Marcus Wolf 
---
 drivers/staging/pi433/rf69.c |2 +-
 drivers/staging/pi433/rf69.h |1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index ec4b540..90ccf4e 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -442,7 +442,7 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
}
 }
 
-int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum 
dccPercent dccPercent)
+static int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 
reg, enum dccPercent dccPercent)
 {
switch (dccPercent) {
case dcc16Percent:  return rmw(spi, reg, MASK_BW_DCC_FREQ, 
BW_DCC_16_PERCENT);
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index 645c8df..7f580e9 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -36,7 +36,6 @@
 int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance 
antennaImpedance);
 int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
 enum lnaGain rf69_get_lna_gain(struct spi_device *spi);
-int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum 
dccPercent dccPercent);
 int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent 
dccPercent);
 int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum 
dccPercent dccPercent);
 int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 
exponent);
-- 
1.7.10.4

[PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-02 Thread Marcus Wolf 
rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header and declared it staic in
the implemtation.
Signed-off-by: Marcus Wolf 
---
 drivers/staging/pi433/rf69.c |2 +-
 drivers/staging/pi433/rf69.h |1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index ec4b540..90ccf4e 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -442,7 +442,7 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
}
 }
 
-int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum 
dccPercent dccPercent)
+static int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 
reg, enum dccPercent dccPercent)
 {
switch (dccPercent) {
case dcc16Percent:  return rmw(spi, reg, MASK_BW_DCC_FREQ, 
BW_DCC_16_PERCENT);
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index 645c8df..7f580e9 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -36,7 +36,6 @@
 int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance 
antennaImpedance);
 int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
 enum lnaGain rf69_get_lna_gain(struct spi_device *spi);
-int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum 
dccPercent dccPercent);
 int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent 
dccPercent);
 int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum 
dccPercent dccPercent);
 int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 
exponent);
-- 
1.7.10.4