Re: [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses

2015-03-24 Thread Joe Perches 
On Tue, 2015-03-24 at 20:28 -0400, Jes Sorensen wrote:
> Joe Perches  writes:
> > Create an rt_trace function using %pV to reduce overall code size.
> > Update the macro uses to remove unnecessary and now harmful parentheses.
[]
> This could be further improved by fixing up all the places where the
> function name is hard coded into the print statement, instead of using
> __func__. In particular as a lot of it is carried over from old code
> and has been renamed since.

There's a cocci script for that.

http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names

I expect someone will run it one day on staging.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses

2015-03-24 Thread Jes Sorensen 
Joe Perches  writes:
> Create an rt_trace function using %pV to reduce overall code size.
> Update the macro uses to remove unnecessary and now harmful parentheses.
>
> Miscellanea around these changes:
>
> o Coalesce formats
> o Realign arguments
> o Remove commented-out RT_TRACE uses
> o Spelling fixes in formats
> o Add missing newlines to formats
> o Remove multiple newlines from formats
> o Neaten formats where noticed
> o Use %pM in one instance
>
> Reduces code size ~20KB
>
> Signed-off-by: Joe Perches 
> ---
> Mostly done by various scripts&emacs.
> Compiled, untested, no hardware,

This could be further improved by fixing up all the places where the
function name is hard coded into the print statement, instead of using
__func__. In particular as a lot of it is carried over from old code
and has been renamed since.

It's OK with me to do this in a follow-on patch though.

Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/