[PATCH] staging: vt6655: Fixed two lines over 80 characters long
Two lines of code that were over 80 characters long is fixed by splitting them across multiple lines. The lines of code are now easier to comprehend. Issue found by checkpatch. Signed-off-by: Arjun Krishna Babu --- drivers/staging/vt6655/baseband.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 9e61f2d..1e6c0c4 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -2089,9 +2089,19 @@ bool BBbVT3253Init(struct vnt_private *priv) byVT3253B0_UW2451[ii][0], byVT3253B0_UW2451[ii][1]); - /* Init ANT B select,TX Config CR09 = 0x61->0x45, 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ + /* Init ANT B select, +* TX Config CR09 = 0x61->0x45, +* 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) +*/ + /*bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/ - /* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ + + /* Init ANT B select, +* RX Config CR10 = 0x28->0x2A, +* 0x2A->0x28(VC1/VC2 define, +* make the ANT_A, ANT_B inverted) +*/ + /*bResult &= BBbWriteEmbedded(dwIoBase,0x0a,0x28);*/ /* Select VC1/VC2, CR215 = 0x02->0x06 */ bResult &= BBbWriteEmbedded(priv, 0xd7, 0x06); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: vt6655: Fixed two lines over 80 characters
On Tue, Sep 29, 2015 at 10:37:24PM +0530, Arjun Krishna Babu wrote: > Two lines of code that were over 80 characters long is fixed by > splitting them into multiple lines. > > This way, the lines of code are now easier to read. > > Issue found by checkpatch. > > Signed-off-by: Arjun Krishna Babu > --- > drivers/staging/vt6655/baseband.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vt6655/baseband.c > b/drivers/staging/vt6655/baseband.c > index 9e61f2d..3639f9d 100644 > --- a/drivers/staging/vt6655/baseband.c > +++ b/drivers/staging/vt6655/baseband.c > @@ -2089,9 +2089,18 @@ bool BBbVT3253Init(struct vnt_private *priv) > byVT3253B0_UW2451[ii][0], > byVT3253B0_UW2451[ii][1]); > > - /* Init ANT B select,TX Config CR09 = 0x61->0x45, > 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ > + /* Init ANT B select, > + * TX Config CR09 = 0x61->0x45, > + * 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) > + */ > + > /*bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/ > - /* Init ANT B select,RX Config CR10 = 0x28->0x2A, > 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ > + > + /* Init ANT B select, > + * RX Config CR10 = 0x28->0x2A, > + * 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) > + */ > + Please always run your patches through checkpatch.pl, so that you don't get an email from the maintainers saying that you need to run your patch through checkpatch.pl. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: vt6655: Fixed two lines over 80 characters
Two lines of code that were over 80 characters long is fixed by splitting them into multiple lines. This way, the lines of code are now easier to read. Issue found by checkpatch. Signed-off-by: Arjun Krishna Babu --- drivers/staging/vt6655/baseband.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 9e61f2d..3639f9d 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -2089,9 +2089,18 @@ bool BBbVT3253Init(struct vnt_private *priv) byVT3253B0_UW2451[ii][0], byVT3253B0_UW2451[ii][1]); - /* Init ANT B select,TX Config CR09 = 0x61->0x45, 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ + /* Init ANT B select, +* TX Config CR09 = 0x61->0x45, +* 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) +*/ + /*bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/ - /* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ + + /* Init ANT B select, +* RX Config CR10 = 0x28->0x2A, +* 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) +*/ + /*bResult &= BBbWriteEmbedded(dwIoBase,0x0a,0x28);*/ /* Select VC1/VC2, CR215 = 0x02->0x06 */ bResult &= BBbWriteEmbedded(priv, 0xd7, 0x06); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
