Re: [PATCH] statx: remove incorrect part of vfs_statx() comment

2017-03-31 Thread Christoph Hellwig 
Looks good,

Reviewed-by: Christoph Hellwig

Re: [PATCH] statx: remove incorrect part of vfs_statx() comment

2017-03-31 Thread Christoph Hellwig 
Looks good,

Reviewed-by: Christoph Hellwig

Re: [PATCH] statx: remove incorrect part of vfs_statx() comment

2017-03-11 Thread David Howells 
Eric Biggers  wrote:

> From: Eric Biggers 
> 
> request_mask and query_flags are function arguments, not passed in
> struct kstat.  So remove the part of the comment which claims otherwise.
> This was apparently left over from an earlier version of the statx
> patch.
> 
> Signed-off-by: Eric Biggers 

Acked-by: David Howells

Re: [PATCH] statx: remove incorrect part of vfs_statx() comment

2017-03-11 Thread David Howells 
Eric Biggers  wrote:

> From: Eric Biggers 
> 
> request_mask and query_flags are function arguments, not passed in
> struct kstat.  So remove the part of the comment which claims otherwise.
> This was apparently left over from an earlier version of the statx
> patch.
> 
> Signed-off-by: Eric Biggers 

Acked-by: David Howells

[PATCH] statx: remove incorrect part of vfs_statx() comment

2017-03-11 Thread Eric Biggers 
From: Eric Biggers 

request_mask and query_flags are function arguments, not passed in
struct kstat.  So remove the part of the comment which claims otherwise.
This was apparently left over from an earlier version of the statx
patch.

Signed-off-by: Eric Biggers 
---
 fs/stat.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/stat.c b/fs/stat.c
index df484a60846d..b792dd201c31 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -159,9 +159,6 @@ EXPORT_SYMBOL(vfs_statx_fd);
  * Additionally, the use of AT_SYMLINK_NOFOLLOW in flags will prevent a symlink
  * at the given name from being referenced.
  *
- * The caller must have preset stat->request_mask as for vfs_getattr().  The
- * flags are also used to load up stat->query_flags.
- *
  * 0 will be returned on success, and a -ve error code if unsuccessful.
  */
 int vfs_statx(int dfd, const char __user *filename, int flags,
-- 
2.12.0

[PATCH] statx: remove incorrect part of vfs_statx() comment

2017-03-11 Thread Eric Biggers 
From: Eric Biggers 

request_mask and query_flags are function arguments, not passed in
struct kstat.  So remove the part of the comment which claims otherwise.
This was apparently left over from an earlier version of the statx
patch.

Signed-off-by: Eric Biggers 
---
 fs/stat.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/stat.c b/fs/stat.c
index df484a60846d..b792dd201c31 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -159,9 +159,6 @@ EXPORT_SYMBOL(vfs_statx_fd);
  * Additionally, the use of AT_SYMLINK_NOFOLLOW in flags will prevent a symlink
  * at the given name from being referenced.
  *
- * The caller must have preset stat->request_mask as for vfs_getattr().  The
- * flags are also used to load up stat->query_flags.
- *
  * 0 will be returned on success, and a -ve error code if unsuccessful.
  */
 int vfs_statx(int dfd, const char __user *filename, int flags,
-- 
2.12.0