Re: [PATCH] tools:virtio: fix compilation warning

2012-12-03 Thread Michael S. Tsirkin 
On Mon, Dec 03, 2012 at 10:24:54AM +, Cong Ding wrote:
> We do not allow old-style function definition.  Always spell foo(void) if
> a function does not take any parameters.
> 
> Signed-off-by: Cong Ding 

Thanks, applied.

> ---
>  tools/virtio/virtio_test.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index e626fa5..6d25dcd 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -232,7 +232,7 @@ const struct option longopts[] = {
>   }
>  };
>  
> -static void help()
> +static void help(void)
>  {
>   fprintf(stderr, "Usage: virtio_test [--help]"
>   " [--no-indirect]"
> -- 
> 1.7.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] tools:virtio: fix compilation warning

2012-12-03 Thread Cong Ding 
We do not allow old-style function definition.  Always spell foo(void) if
a function does not take any parameters.

Signed-off-by: Cong Ding 
---
 tools/virtio/virtio_test.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
index e626fa5..6d25dcd 100644
--- a/tools/virtio/virtio_test.c
+++ b/tools/virtio/virtio_test.c
@@ -232,7 +232,7 @@ const struct option longopts[] = {
}
 };
 
-static void help()
+static void help(void)
 {
fprintf(stderr, "Usage: virtio_test [--help]"
" [--no-indirect]"
-- 
1.7.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] tools:virtio: fix compilation warning

2012-12-03 Thread Cong Ding 
We do not allow old-style function definition.  Always spell foo(void) if
a function does not take any parameters.

Signed-off-by: Cong Ding ding...@gmail.com
---
 tools/virtio/virtio_test.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
index e626fa5..6d25dcd 100644
--- a/tools/virtio/virtio_test.c
+++ b/tools/virtio/virtio_test.c
@@ -232,7 +232,7 @@ const struct option longopts[] = {
}
 };
 
-static void help()
+static void help(void)
 {
fprintf(stderr, Usage: virtio_test [--help]
 [--no-indirect]
-- 
1.7.4.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] tools:virtio: fix compilation warning

2012-12-03 Thread Michael S. Tsirkin 
On Mon, Dec 03, 2012 at 10:24:54AM +, Cong Ding wrote:
 We do not allow old-style function definition.  Always spell foo(void) if
 a function does not take any parameters.
 
 Signed-off-by: Cong Ding ding...@gmail.com

Thanks, applied.

 ---
  tools/virtio/virtio_test.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
 index e626fa5..6d25dcd 100644
 --- a/tools/virtio/virtio_test.c
 +++ b/tools/virtio/virtio_test.c
 @@ -232,7 +232,7 @@ const struct option longopts[] = {
   }
  };
  
 -static void help()
 +static void help(void)
  {
   fprintf(stderr, Usage: virtio_test [--help]
[--no-indirect]
 -- 
 1.7.4.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/