[PATCH] usb: core: hub.c: Removed some warnings generated by checkpatch.pl
Removed some checkpatch.pl warnings saying there was an unwanted space between function names and their arguments. Signed-off-by: Chase Metzger --- drivers/usb/core/hub.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 73dfa19..9387cc20 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -50,8 +50,8 @@ DEFINE_MUTEX(usb_port_peer_mutex); /* cycle leds on hubs that aren't blinking for attention */ static bool blinkenlights = 0; -module_param (blinkenlights, bool, S_IRUGO); -MODULE_PARM_DESC (blinkenlights, "true to cycle leds on hubs"); +module_param(blinkenlights, bool, S_IRUGO); +MODULE_PARM_DESC(blinkenlights, "true to cycle leds on hubs"); /* * Device SATA8000 FW1.0 from DATAST0R Technology Corp requires about @@ -439,7 +439,7 @@ static void set_port_led(struct usb_hub *hub, int port1, int selector) #defineLED_CYCLE_PERIOD((2*HZ)/3) -static void led_work (struct work_struct *work) +static void led_work(struct work_struct *work) { struct usb_hub *hub = container_of(work, struct usb_hub, leds.work); @@ -646,7 +646,7 @@ static void hub_irq(struct urb *urb) default:/* presumably an error */ /* Cause a hub reset after 10 consecutive errors */ - dev_dbg (hub->intfdev, "transfer --> %d\n", status); + dev_dbg(hub->intfdev, "transfer --> %d\n", status); if ((++hub->nerrors < 10) || hub->error) goto resubmit; hub->error = status; @@ -671,14 +671,14 @@ resubmit: if (hub->quiescing) return; - if ((status = usb_submit_urb (hub->urb, GFP_ATOMIC)) != 0 + if ((status = usb_submit_urb(hub->urb, GFP_ATOMIC)) != 0 && status != -ENODEV && status != -EPERM) - dev_err (hub->intfdev, "resubmit --> %d\n", status); + dev_err(hub->intfdev, "resubmit --> %d\n", status); } /* USB 2.0 spec Section 11.24.2.3 */ static inline int -hub_clear_tt_buffer (struct usb_device *hdev, u16 devinfo, u16 tt) +hub_clear_tt_buffer(struct usb_device *hdev, u16 devinfo, u16 tt) { /* Need to clear both directions for control ep */ if (((devinfo >> 11) & USB_ENDPOINT_XFERTYPE_MASK) == @@ -706,7 +706,7 @@ static void hub_tt_work(struct work_struct *work) container_of(work, struct usb_hub, tt.clear_work); unsigned long flags; - spin_lock_irqsave (>tt.lock, flags); + spin_lock_irqsave(>tt.lock, flags); while (!list_empty(>tt.clear_list)) { struct list_head*next; struct usb_tt_clear *clear; @@ -715,14 +715,14 @@ static void hub_tt_work(struct work_struct *work) int status; next = hub->tt.clear_list.next; - clear = list_entry (next, struct usb_tt_clear, clear_list); - list_del (>clear_list); + clear = list_entry(next, struct usb_tt_clear, clear_list); + list_del(>clear_list); /* drop lock so HCD can concurrently report other TT errors */ - spin_unlock_irqrestore (>tt.lock, flags); - status = hub_clear_tt_buffer (hdev, clear->devinfo, clear->tt); + spin_unlock_irqrestore(>tt.lock, flags); + status = hub_clear_tt_buffer(hdev, clear->devinfo, clear->tt); if (status && status != -ENODEV) - dev_err (>dev, + dev_err(>dev, "clear tt %d (%04x) error %d\n", clear->tt, clear->devinfo, status); @@ -734,7 +734,7 @@ static void hub_tt_work(struct work_struct *work) kfree(clear); spin_lock_irqsave(>tt.lock, flags); } - spin_unlock_irqrestore (>tt.lock, flags); + spin_unlock_irqrestore(>tt.lock, flags); } /** @@ -797,7 +797,7 @@ int usb_hub_clear_tt_buffer(struct urb *urb) */ clear = kmalloc(sizeof *clear, GFP_ATOMIC); if (clear == NULL) { - dev_err (>dev, "can't save CLEAR_TT_BUFFER state\n"); + dev_err(>dev, "can't save CLEAR_TT_BUFFER state\n"); /* FIXME recover somehow ... RESET_TT? */ return -ENOMEM; } @@ -806,10 +806,10 @@ int usb_hub_clear_tt_buffer(struct urb *urb) clear->tt = tt->multi ? udev->ttport : 1; clear->devinfo = usb_pipeendpoint (pipe); clear->devinfo |= udev->devnum << 4; - clear->devinfo |= usb_pipecontrol (pipe) + clear->devinfo |= usb_pipecontrol(pipe) ? (USB_ENDPOINT_XFER_CONTROL << 11) : (USB_ENDPOINT_XFER_BULK << 11); - if (usb_pipein (pipe)) + if (usb_pipein(pipe))
[PATCH] usb: core: hub.c: Removed some warnings generated by checkpatch.pl
Removed some checkpatch.pl warnings saying there was an unwanted space between function names and their arguments. Signed-off-by: Chase Metzger chasemetzge...@gmail.com --- drivers/usb/core/hub.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 73dfa19..9387cc20 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -50,8 +50,8 @@ DEFINE_MUTEX(usb_port_peer_mutex); /* cycle leds on hubs that aren't blinking for attention */ static bool blinkenlights = 0; -module_param (blinkenlights, bool, S_IRUGO); -MODULE_PARM_DESC (blinkenlights, true to cycle leds on hubs); +module_param(blinkenlights, bool, S_IRUGO); +MODULE_PARM_DESC(blinkenlights, true to cycle leds on hubs); /* * Device SATA8000 FW1.0 from DATAST0R Technology Corp requires about @@ -439,7 +439,7 @@ static void set_port_led(struct usb_hub *hub, int port1, int selector) #defineLED_CYCLE_PERIOD((2*HZ)/3) -static void led_work (struct work_struct *work) +static void led_work(struct work_struct *work) { struct usb_hub *hub = container_of(work, struct usb_hub, leds.work); @@ -646,7 +646,7 @@ static void hub_irq(struct urb *urb) default:/* presumably an error */ /* Cause a hub reset after 10 consecutive errors */ - dev_dbg (hub-intfdev, transfer -- %d\n, status); + dev_dbg(hub-intfdev, transfer -- %d\n, status); if ((++hub-nerrors 10) || hub-error) goto resubmit; hub-error = status; @@ -671,14 +671,14 @@ resubmit: if (hub-quiescing) return; - if ((status = usb_submit_urb (hub-urb, GFP_ATOMIC)) != 0 + if ((status = usb_submit_urb(hub-urb, GFP_ATOMIC)) != 0 status != -ENODEV status != -EPERM) - dev_err (hub-intfdev, resubmit -- %d\n, status); + dev_err(hub-intfdev, resubmit -- %d\n, status); } /* USB 2.0 spec Section 11.24.2.3 */ static inline int -hub_clear_tt_buffer (struct usb_device *hdev, u16 devinfo, u16 tt) +hub_clear_tt_buffer(struct usb_device *hdev, u16 devinfo, u16 tt) { /* Need to clear both directions for control ep */ if (((devinfo 11) USB_ENDPOINT_XFERTYPE_MASK) == @@ -706,7 +706,7 @@ static void hub_tt_work(struct work_struct *work) container_of(work, struct usb_hub, tt.clear_work); unsigned long flags; - spin_lock_irqsave (hub-tt.lock, flags); + spin_lock_irqsave(hub-tt.lock, flags); while (!list_empty(hub-tt.clear_list)) { struct list_head*next; struct usb_tt_clear *clear; @@ -715,14 +715,14 @@ static void hub_tt_work(struct work_struct *work) int status; next = hub-tt.clear_list.next; - clear = list_entry (next, struct usb_tt_clear, clear_list); - list_del (clear-clear_list); + clear = list_entry(next, struct usb_tt_clear, clear_list); + list_del(clear-clear_list); /* drop lock so HCD can concurrently report other TT errors */ - spin_unlock_irqrestore (hub-tt.lock, flags); - status = hub_clear_tt_buffer (hdev, clear-devinfo, clear-tt); + spin_unlock_irqrestore(hub-tt.lock, flags); + status = hub_clear_tt_buffer(hdev, clear-devinfo, clear-tt); if (status status != -ENODEV) - dev_err (hdev-dev, + dev_err(hdev-dev, clear tt %d (%04x) error %d\n, clear-tt, clear-devinfo, status); @@ -734,7 +734,7 @@ static void hub_tt_work(struct work_struct *work) kfree(clear); spin_lock_irqsave(hub-tt.lock, flags); } - spin_unlock_irqrestore (hub-tt.lock, flags); + spin_unlock_irqrestore(hub-tt.lock, flags); } /** @@ -797,7 +797,7 @@ int usb_hub_clear_tt_buffer(struct urb *urb) */ clear = kmalloc(sizeof *clear, GFP_ATOMIC); if (clear == NULL) { - dev_err (udev-dev, can't save CLEAR_TT_BUFFER state\n); + dev_err(udev-dev, can't save CLEAR_TT_BUFFER state\n); /* FIXME recover somehow ... RESET_TT? */ return -ENOMEM; } @@ -806,10 +806,10 @@ int usb_hub_clear_tt_buffer(struct urb *urb) clear-tt = tt-multi ? udev-ttport : 1; clear-devinfo = usb_pipeendpoint (pipe); clear-devinfo |= udev-devnum 4; - clear-devinfo |= usb_pipecontrol (pipe) + clear-devinfo |= usb_pipecontrol(pipe) ? (USB_ENDPOINT_XFER_CONTROL 11) : (USB_ENDPOINT_XFER_BULK 11); - if (usb_pipein (pipe)) + if