Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Hi,
On Thu, Mar 20, 2014 at 09:02:52AM -0700, gre...@linuxfoundation.org wrote:
> On Thu, Mar 20, 2014 at 03:01:56PM +, suresh.gu...@freescale.com wrote:
> > > > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > > > > fsl_udc_devtype[] = {
> > > > > > > }, {
> > > > > > > .name = "imx-udc-mx51",
> > > > > > > }, {
> > > > > > > + .name = "fsl-usb2-udc",
> > > > > >
> > > > > > why aren't you just using chipidea ?
> > > > > > [SuresH] This is our legacy driver for all previous and existing
> > > > > > ppc socs. Many of our customers are already using this, and we
> > > > > > need to support them on this driver. We do have plans to shift to
> > > > > > chipidea, but after some time.
> > > > >
> > > > > cool, you already have plans, so we will see a new glue layer for
> > > > > v3.16 right ? Which means I don't need to take this patch either.
> > > > >
> > > > we do have plans, but in remote future. Right now, we need to support
> > > > customers on the present legacy driver. We'll phase out this driver
> > > > slowly when we integrate chipidea. At this time I would request you to
> > > > please accept this patch
> > >
> > > Even if Felipe takes the patch, I'll reject it as you should be doing the
> > > correct thing here, and if it's accepted, it will never be changed...
> >
> > Hi Greg, I agree that moving to the chipidea driver is the right thing to
> > do.
> > However, does this mean that companies have to phase out their current
> > legacy
> > drivers as soon as a new controller specific driver is introduced in kernel
> > ??
>
> If their drivers aren't merged upstream, then yes they do, we can't have
> duplicate drivers controlling the same hardware blobs.
>
> > Can't they decide their own schedule based on their own requirements. Our
> > only
> > concern is to keep supporting our customers till we move to the new driver.
>
> Your support issues / requirements is not any of our business, we just
> can't accept duplicate code, which I'm sure you can understand.
>
> > I would really appreciate if you could accept this as this would give us
> > some time to move to chipidea driver.
>
> What is preventing you from doing this within a week or so? Is it
> really that hard of a transistion? If so, is this a problem with the
> chipidea driver or something else?
Greg, many other freescale SoCs are *already* using chipidea driver. I
suppose 1 week effort is overestimation, it shouldn't take much more
than a couple days.
If there are any bugs in chipidea, let's find them and fix them up. We
really cannot continue with code duplication in the tree, it's just
moronic to do so, it's an unnecessary maintenance burden, extra review
time, same fixes having to written for separate drivers, and so on.
--
balbi
signature.asc
Description: Digital signature
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
On Thu, Mar 20, 2014 at 03:01:56PM +, suresh.gu...@freescale.com wrote:
> > > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > > > fsl_udc_devtype[] = {
> > > > > > }, {
> > > > > > .name = "imx-udc-mx51",
> > > > > > }, {
> > > > > > + .name = "fsl-usb2-udc",
> > > > >
> > > > > why aren't you just using chipidea ?
> > > > > [SuresH] This is our legacy driver for all previous and existing
> > > > > ppc socs. Many of our customers are already using this, and we
> > > > > need to support them on this driver. We do have plans to shift to
> > > > > chipidea, but after some time.
> > > >
> > > > cool, you already have plans, so we will see a new glue layer for
> > > > v3.16 right ? Which means I don't need to take this patch either.
> > > >
> > > we do have plans, but in remote future. Right now, we need to support
> > > customers on the present legacy driver. We'll phase out this driver
> > > slowly when we integrate chipidea. At this time I would request you to
> > > please accept this patch
> >
> > Even if Felipe takes the patch, I'll reject it as you should be doing the
> > correct thing here, and if it's accepted, it will never be changed...
>
> Hi Greg, I agree that moving to the chipidea driver is the right thing to do.
> However, does this mean that companies have to phase out their current legacy
> drivers as soon as a new controller specific driver is introduced in kernel ??
If their drivers aren't merged upstream, then yes they do, we can't have
duplicate drivers controlling the same hardware blobs.
> Can't they decide their own schedule based on their own requirements. Our
> only
> concern is to keep supporting our customers till we move to the new driver.
Your support issues / requirements is not any of our business, we just
can't accept duplicate code, which I'm sure you can understand.
> I would really appreciate if you could accept this as this would give us
> some time to move to chipidea driver.
What is preventing you from doing this within a week or so? Is it
really that hard of a transistion? If so, is this a problem with the
chipidea driver or something else?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
> > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > > fsl_udc_devtype[] = {
> > > > > }, {
> > > > > .name = "imx-udc-mx51",
> > > > > }, {
> > > > > + .name = "fsl-usb2-udc",
> > > >
> > > > why aren't you just using chipidea ?
> > > > [SuresH] This is our legacy driver for all previous and existing
> > > > ppc socs. Many of our customers are already using this, and we
> > > > need to support them on this driver. We do have plans to shift to
> > > > chipidea, but after some time.
> > >
> > > cool, you already have plans, so we will see a new glue layer for
> > > v3.16 right ? Which means I don't need to take this patch either.
> > >
> > we do have plans, but in remote future. Right now, we need to support
> > customers on the present legacy driver. We'll phase out this driver
> > slowly when we integrate chipidea. At this time I would request you to
> > please accept this patch
>
> Even if Felipe takes the patch, I'll reject it as you should be doing the
> correct thing here, and if it's accepted, it will never be changed...
Hi Greg, I agree that moving to the chipidea driver is the right thing to do.
However, does this mean that companies have to phase out their current legacy
drivers as soon as a new controller specific driver is introduced in kernel ??
Can't they decide their own schedule based on their own requirements. Our only
concern is to keep supporting our customers till we move to the new driver.
I would really appreciate if you could accept this as this would give us
some time to move to chipidea driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing
ppc socs. Many of our customers are already using this, and we
need to support them on this driver. We do have plans to shift to
chipidea, but after some time.
cool, you already have plans, so we will see a new glue layer for
v3.16 right ? Which means I don't need to take this patch either.
we do have plans, but in remote future. Right now, we need to support
customers on the present legacy driver. We'll phase out this driver
slowly when we integrate chipidea. At this time I would request you to
please accept this patch
Even if Felipe takes the patch, I'll reject it as you should be doing the
correct thing here, and if it's accepted, it will never be changed...
Hi Greg, I agree that moving to the chipidea driver is the right thing to do.
However, does this mean that companies have to phase out their current legacy
drivers as soon as a new controller specific driver is introduced in kernel ??
Can't they decide their own schedule based on their own requirements. Our only
concern is to keep supporting our customers till we move to the new driver.
I would really appreciate if you could accept this as this would give us
some time to move to chipidea driver.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
On Thu, Mar 20, 2014 at 03:01:56PM +, suresh.gu...@freescale.com wrote:
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing
ppc socs. Many of our customers are already using this, and we
need to support them on this driver. We do have plans to shift to
chipidea, but after some time.
cool, you already have plans, so we will see a new glue layer for
v3.16 right ? Which means I don't need to take this patch either.
we do have plans, but in remote future. Right now, we need to support
customers on the present legacy driver. We'll phase out this driver
slowly when we integrate chipidea. At this time I would request you to
please accept this patch
Even if Felipe takes the patch, I'll reject it as you should be doing the
correct thing here, and if it's accepted, it will never be changed...
Hi Greg, I agree that moving to the chipidea driver is the right thing to do.
However, does this mean that companies have to phase out their current legacy
drivers as soon as a new controller specific driver is introduced in kernel ??
If their drivers aren't merged upstream, then yes they do, we can't have
duplicate drivers controlling the same hardware blobs.
Can't they decide their own schedule based on their own requirements. Our
only
concern is to keep supporting our customers till we move to the new driver.
Your support issues / requirements is not any of our business, we just
can't accept duplicate code, which I'm sure you can understand.
I would really appreciate if you could accept this as this would give us
some time to move to chipidea driver.
What is preventing you from doing this within a week or so? Is it
really that hard of a transistion? If so, is this a problem with the
chipidea driver or something else?
thanks,
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Hi,
On Thu, Mar 20, 2014 at 09:02:52AM -0700, gre...@linuxfoundation.org wrote:
On Thu, Mar 20, 2014 at 03:01:56PM +, suresh.gu...@freescale.com wrote:
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing
ppc socs. Many of our customers are already using this, and we
need to support them on this driver. We do have plans to shift to
chipidea, but after some time.
cool, you already have plans, so we will see a new glue layer for
v3.16 right ? Which means I don't need to take this patch either.
we do have plans, but in remote future. Right now, we need to support
customers on the present legacy driver. We'll phase out this driver
slowly when we integrate chipidea. At this time I would request you to
please accept this patch
Even if Felipe takes the patch, I'll reject it as you should be doing the
correct thing here, and if it's accepted, it will never be changed...
Hi Greg, I agree that moving to the chipidea driver is the right thing to
do.
However, does this mean that companies have to phase out their current
legacy
drivers as soon as a new controller specific driver is introduced in kernel
??
If their drivers aren't merged upstream, then yes they do, we can't have
duplicate drivers controlling the same hardware blobs.
Can't they decide their own schedule based on their own requirements. Our
only
concern is to keep supporting our customers till we move to the new driver.
Your support issues / requirements is not any of our business, we just
can't accept duplicate code, which I'm sure you can understand.
I would really appreciate if you could accept this as this would give us
some time to move to chipidea driver.
What is preventing you from doing this within a week or so? Is it
really that hard of a transistion? If so, is this a problem with the
chipidea driver or something else?
Greg, many other freescale SoCs are *already* using chipidea driver. I
suppose 1 week effort is overestimation, it shouldn't take much more
than a couple days.
If there are any bugs in chipidea, let's find them and fix them up. We
really cannot continue with code duplication in the tree, it's just
moronic to do so, it's an unnecessary maintenance burden, extra review
time, same fixes having to written for separate drivers, and so on.
--
balbi
signature.asc
Description: Digital signature
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Ignore last mail, was not intended for you.
> -Original Message-
> From: Gupta Suresh-B42813
> Sent: Wednesday, March 19, 2014 11:33 PM
> To: 'gre...@linuxfoundation.org'
> Cc: ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> platform device id
>
> Hi Ramneek,
>
> Do you understand, what Greg want to communicate.
>
>
> Thanks
> SuresH
>
> > -Original Message-
> > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> > Sent: Wednesday, March 19, 2014 10:22 PM
> > To: Gupta Suresh-B42813
> > Cc: ba...@ti.com; linux-...@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > platform device id
> >
> > On Wed, Mar 19, 2014 at 02:25:25PM +, suresh.gu...@freescale.com
> > wrote:
> > > Hi
> > >
> > > > -Original Message-
> > > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > > Sent: Saturday, March 15, 2014 7:10 AM
> > > > To: Gupta Suresh-B42813
> > > > Cc: ba...@ti.com; gre...@linuxfoundation.org;
> > > > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org
> > > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > > > platform device id
> > > >
> > > > On Fri, Mar 14, 2014 at 08:52:19PM +,
> > > > suresh.gu...@freescale.com
> > > > wrote:
> > > > > Hi,
> > > > > Thanks for reviewing my patches.
> > > > > Please find my comments inline
> > > > >
> > > > > -Original Message-----
> > > > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > > > Sent: Thursday, March 13, 2014 8:56 PM
> > > > > To: Gupta Suresh-B42813
> > > > > Cc: ba...@ti.com; gre...@linuxfoundation.org;
> > > > > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta
> > > > > Suresh-B42813
> > > > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry
> > > > > in platform device id
> > > > >
> > > > > On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> > > > > > From: Suresh Gupta
> > > > > >
> > > > > > Add FSL USB Gadget entry in platform device id table
> > > > >
> > > > > why this tab ?
> > > > > [SuresH] I will remove it in next version.
> > > > >
> > > > > > Signed-off-by: Suresh Gupta
> > > > > > ---
> > > > > > drivers/usb/gadget/fsl_udc_core.c | 2 ++
> > > > > > 1 file changed, 2 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c
> > > > > > b/drivers/usb/gadget/fsl_udc_core.c
> > > > > > index b7dea4e..35b20e6 100644
> > > > > > --- a/drivers/usb/gadget/fsl_udc_core.c
> > > > > > +++ b/drivers/usb/gadget/fsl_udc_core.c
> > > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > > > fsl_udc_devtype[] = {
> > > > > > }, {
> > > > > > .name = "imx-udc-mx51",
> > > > > > }, {
> > > > > > + .name = "fsl-usb2-udc",
> > > > >
> > > > > why aren't you just using chipidea ?
> > > > > [SuresH] This is our legacy driver for all previous and existing
> > > > > ppc socs. Many of our customers are already using this, and we
> > > > > need to support them on this driver. We do have plans to shift
> > > > > to chipidea, but after some time.
> > > >
> > > > cool, you already have plans, so we will see a new glue layer for
> > > > v3.16 right ? Which means I don't need to take this patch either.
> > > >
> > > we do have plans, but in remote future. Right now, we need to
> > > support customers on the present legacy driver. We'll phase out this
> > > driver slowly when we integrate chipidea. At this time I would
> > > request you to please accept this patch
> >
> > Even if Felipe takes the patch, I'll reject it as you should be doing
> > the correct thing here, and if it's accepted, it will never be
> changed...
> >
> > greg k-h
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Hi Ramneek,
Do you understand, what Greg want to communicate.
Thanks
SuresH
> -Original Message-
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> Sent: Wednesday, March 19, 2014 10:22 PM
> To: Gupta Suresh-B42813
> Cc: ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> platform device id
>
> On Wed, Mar 19, 2014 at 02:25:25PM +, suresh.gu...@freescale.com
> wrote:
> > Hi
> >
> > > -Original Message-
> > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > Sent: Saturday, March 15, 2014 7:10 AM
> > > To: Gupta Suresh-B42813
> > > Cc: ba...@ti.com; gre...@linuxfoundation.org;
> > > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org
> > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > > platform device id
> > >
> > > On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com
> > > wrote:
> > > > Hi,
> > > > Thanks for reviewing my patches.
> > > > Please find my comments inline
> > > >
> > > > -Original Message-
> > > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > > Sent: Thursday, March 13, 2014 8:56 PM
> > > > To: Gupta Suresh-B42813
> > > > Cc: ba...@ti.com; gre...@linuxfoundation.org;
> > > > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta
> > > > Suresh-B42813
> > > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > > > platform device id
> > > >
> > > > On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> > > > > From: Suresh Gupta
> > > > >
> > > > > Add FSL USB Gadget entry in platform device id table
> > > >
> > > > why this tab ?
> > > > [SuresH] I will remove it in next version.
> > > >
> > > > > Signed-off-by: Suresh Gupta
> > > > > ---
> > > > > drivers/usb/gadget/fsl_udc_core.c | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c
> > > > > b/drivers/usb/gadget/fsl_udc_core.c
> > > > > index b7dea4e..35b20e6 100644
> > > > > --- a/drivers/usb/gadget/fsl_udc_core.c
> > > > > +++ b/drivers/usb/gadget/fsl_udc_core.c
> > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > > fsl_udc_devtype[] = {
> > > > > }, {
> > > > > .name = "imx-udc-mx51",
> > > > > }, {
> > > > > + .name = "fsl-usb2-udc",
> > > >
> > > > why aren't you just using chipidea ?
> > > > [SuresH] This is our legacy driver for all previous and existing
> > > > ppc socs. Many of our customers are already using this, and we
> > > > need to support them on this driver. We do have plans to shift to
> > > > chipidea, but after some time.
> > >
> > > cool, you already have plans, so we will see a new glue layer for
> > > v3.16 right ? Which means I don't need to take this patch either.
> > >
> > we do have plans, but in remote future. Right now, we need to support
> > customers on the present legacy driver. We'll phase out this driver
> > slowly when we integrate chipidea. At this time I would request you to
> > please accept this patch
>
> Even if Felipe takes the patch, I'll reject it as you should be doing the
> correct thing here, and if it's accepted, it will never be changed...
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
On Wed, Mar 19, 2014 at 02:25:25PM +, suresh.gu...@freescale.com wrote:
> Hi
>
> > -Original Message-
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Saturday, March 15, 2014 7:10 AM
> > To: Gupta Suresh-B42813
> > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > platform device id
> >
> > On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com
> > wrote:
> > > Hi,
> > > Thanks for reviewing my patches.
> > > Please find my comments inline
> > >
> > > -Original Message-
> > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > Sent: Thursday, March 13, 2014 8:56 PM
> > > To: Gupta Suresh-B42813
> > > Cc: ba...@ti.com; gre...@linuxfoundation.org;
> > > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta
> > > Suresh-B42813
> > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > > platform device id
> > >
> > > On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> > > > From: Suresh Gupta
> > > >
> > > > Add FSL USB Gadget entry in platform device id table
> > >
> > > why this tab ?
> > > [SuresH] I will remove it in next version.
> > >
> > > > Signed-off-by: Suresh Gupta
> > > > ---
> > > > drivers/usb/gadget/fsl_udc_core.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c
> > > > b/drivers/usb/gadget/fsl_udc_core.c
> > > > index b7dea4e..35b20e6 100644
> > > > --- a/drivers/usb/gadget/fsl_udc_core.c
> > > > +++ b/drivers/usb/gadget/fsl_udc_core.c
> > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > fsl_udc_devtype[] = {
> > > > }, {
> > > > .name = "imx-udc-mx51",
> > > > }, {
> > > > + .name = "fsl-usb2-udc",
> > >
> > > why aren't you just using chipidea ?
> > > [SuresH] This is our legacy driver for all previous and existing ppc
> > > socs. Many of our customers are already using this, and we need to
> > > support them on this driver. We do have plans to shift to chipidea,
> > > but after some time.
> >
> > cool, you already have plans, so we will see a new glue layer for v3.16
> > right ? Which means I don't need to take this patch either.
> >
> we do have plans, but in remote future. Right now, we need to support
> customers on the present legacy driver. We'll phase out this driver
> slowly when we integrate chipidea. At this time I would request you
> to please accept this patch
Even if Felipe takes the patch, I'll reject it as you should be doing
the correct thing here, and if it's accepted, it will never be
changed...
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Hi
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Saturday, March 15, 2014 7:10 AM
> To: Gupta Suresh-B42813
> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> platform device id
>
> On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com
> wrote:
> > Hi,
> > Thanks for reviewing my patches.
> > Please find my comments inline
> >
> > -Original Message-
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Thursday, March 13, 2014 8:56 PM
> > To: Gupta Suresh-B42813
> > Cc: ba...@ti.com; gre...@linuxfoundation.org;
> > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta
> > Suresh-B42813
> > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > platform device id
> >
> > On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> > > From: Suresh Gupta
> > >
> > > Add FSL USB Gadget entry in platform device id table
> >
> > why this tab ?
> > [SuresH] I will remove it in next version.
> >
> > > Signed-off-by: Suresh Gupta
> > > ---
> > > drivers/usb/gadget/fsl_udc_core.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/usb/gadget/fsl_udc_core.c
> > > b/drivers/usb/gadget/fsl_udc_core.c
> > > index b7dea4e..35b20e6 100644
> > > --- a/drivers/usb/gadget/fsl_udc_core.c
> > > +++ b/drivers/usb/gadget/fsl_udc_core.c
> > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> fsl_udc_devtype[] = {
> > > }, {
> > > .name = "imx-udc-mx51",
> > > }, {
> > > + .name = "fsl-usb2-udc",
> >
> > why aren't you just using chipidea ?
> > [SuresH] This is our legacy driver for all previous and existing ppc
> > socs. Many of our customers are already using this, and we need to
> > support them on this driver. We do have plans to shift to chipidea,
> > but after some time.
>
> cool, you already have plans, so we will see a new glue layer for v3.16
> right ? Which means I don't need to take this patch either.
>
we do have plans, but in remote future. Right now, we need to support
customers on the present legacy driver. We'll phase out this driver
slowly when we integrate chipidea. At this time I would request you
to please accept this patch
---
Thanks
SuresH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Hi
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Saturday, March 15, 2014 7:10 AM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com
wrote:
Hi,
Thanks for reviewing my patches.
Please find my comments inline
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, March 13, 2014 8:56 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org;
linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta
Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
From: Suresh Gupta b42...@freescale.com
Add FSL USB Gadget entry in platform device id table
why this tab ?
[SuresH] I will remove it in next version.
Signed-off-by: Suresh Gupta b42...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing ppc
socs. Many of our customers are already using this, and we need to
support them on this driver. We do have plans to shift to chipidea,
but after some time.
cool, you already have plans, so we will see a new glue layer for v3.16
right ? Which means I don't need to take this patch either.
we do have plans, but in remote future. Right now, we need to support
customers on the present legacy driver. We'll phase out this driver
slowly when we integrate chipidea. At this time I would request you
to please accept this patch
---
Thanks
SuresH
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
On Wed, Mar 19, 2014 at 02:25:25PM +, suresh.gu...@freescale.com wrote:
Hi
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Saturday, March 15, 2014 7:10 AM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com
wrote:
Hi,
Thanks for reviewing my patches.
Please find my comments inline
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, March 13, 2014 8:56 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org;
linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta
Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
From: Suresh Gupta b42...@freescale.com
Add FSL USB Gadget entry in platform device id table
why this tab ?
[SuresH] I will remove it in next version.
Signed-off-by: Suresh Gupta b42...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing ppc
socs. Many of our customers are already using this, and we need to
support them on this driver. We do have plans to shift to chipidea,
but after some time.
cool, you already have plans, so we will see a new glue layer for v3.16
right ? Which means I don't need to take this patch either.
we do have plans, but in remote future. Right now, we need to support
customers on the present legacy driver. We'll phase out this driver
slowly when we integrate chipidea. At this time I would request you
to please accept this patch
Even if Felipe takes the patch, I'll reject it as you should be doing
the correct thing here, and if it's accepted, it will never be
changed...
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Hi Ramneek,
Do you understand, what Greg want to communicate.
Thanks
SuresH
-Original Message-
From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
Sent: Wednesday, March 19, 2014 10:22 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Wed, Mar 19, 2014 at 02:25:25PM +, suresh.gu...@freescale.com
wrote:
Hi
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Saturday, March 15, 2014 7:10 AM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org;
linux-...@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com
wrote:
Hi,
Thanks for reviewing my patches.
Please find my comments inline
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, March 13, 2014 8:56 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org;
linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta
Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
From: Suresh Gupta b42...@freescale.com
Add FSL USB Gadget entry in platform device id table
why this tab ?
[SuresH] I will remove it in next version.
Signed-off-by: Suresh Gupta b42...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing
ppc socs. Many of our customers are already using this, and we
need to support them on this driver. We do have plans to shift to
chipidea, but after some time.
cool, you already have plans, so we will see a new glue layer for
v3.16 right ? Which means I don't need to take this patch either.
we do have plans, but in remote future. Right now, we need to support
customers on the present legacy driver. We'll phase out this driver
slowly when we integrate chipidea. At this time I would request you to
please accept this patch
Even if Felipe takes the patch, I'll reject it as you should be doing the
correct thing here, and if it's accepted, it will never be changed...
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Ignore last mail, was not intended for you.
-Original Message-
From: Gupta Suresh-B42813
Sent: Wednesday, March 19, 2014 11:33 PM
To: 'gre...@linuxfoundation.org'
Cc: ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
Hi Ramneek,
Do you understand, what Greg want to communicate.
Thanks
SuresH
-Original Message-
From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
Sent: Wednesday, March 19, 2014 10:22 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Wed, Mar 19, 2014 at 02:25:25PM +, suresh.gu...@freescale.com
wrote:
Hi
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Saturday, March 15, 2014 7:10 AM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org;
linux-...@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
platform device id
On Fri, Mar 14, 2014 at 08:52:19PM +,
suresh.gu...@freescale.com
wrote:
Hi,
Thanks for reviewing my patches.
Please find my comments inline
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, March 13, 2014 8:56 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org;
linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta
Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry
in platform device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
From: Suresh Gupta b42...@freescale.com
Add FSL USB Gadget entry in platform device id table
why this tab ?
[SuresH] I will remove it in next version.
Signed-off-by: Suresh Gupta b42...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing
ppc socs. Many of our customers are already using this, and we
need to support them on this driver. We do have plans to shift
to chipidea, but after some time.
cool, you already have plans, so we will see a new glue layer for
v3.16 right ? Which means I don't need to take this patch either.
we do have plans, but in remote future. Right now, we need to
support customers on the present legacy driver. We'll phase out this
driver slowly when we integrate chipidea. At this time I would
request you to please accept this patch
Even if Felipe takes the patch, I'll reject it as you should be doing
the correct thing here, and if it's accepted, it will never be
changed...
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com wrote:
> Hi,
> Thanks for reviewing my patches.
> Please find my comments inline
>
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Thursday, March 13, 2014 8:56 PM
> To: Gupta Suresh-B42813
> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
> linux-kernel@vger.kernel.org; Gupta Suresh-B42813
> Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform
> device id
>
> On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> > From: Suresh Gupta
> >
> > Add FSL USB Gadget entry in platform device id table
>
> why this tab ?
> [SuresH] I will remove it in next version.
>
> > Signed-off-by: Suresh Gupta
> > ---
> > drivers/usb/gadget/fsl_udc_core.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/gadget/fsl_udc_core.c
> > b/drivers/usb/gadget/fsl_udc_core.c
> > index b7dea4e..35b20e6 100644
> > --- a/drivers/usb/gadget/fsl_udc_core.c
> > +++ b/drivers/usb/gadget/fsl_udc_core.c
> > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > fsl_udc_devtype[] = {
> > }, {
> > .name = "imx-udc-mx51",
> > }, {
> > + .name = "fsl-usb2-udc",
>
> why aren't you just using chipidea ?
> [SuresH] This is our legacy driver for all previous and existing ppc
> socs. Many of our customers are already using this, and we need to
> support them on this driver. We do have plans to shift to chipidea,
> but after some time.
cool, you already have plans, so we will see a new glue layer for v3.16
right ? Which means I don't need to take this patch either.
--
balbi
signature.asc
Description: Digital signature
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Hi,
Thanks for reviewing my patches.
Please find my comments inline
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, March 13, 2014 8:56 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org; Gupta Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform
device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> From: Suresh Gupta
>
> Add FSL USB Gadget entry in platform device id table
why this tab ?
[SuresH] I will remove it in next version.
> Signed-off-by: Suresh Gupta
> ---
> drivers/usb/gadget/fsl_udc_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/fsl_udc_core.c
> b/drivers/usb/gadget/fsl_udc_core.c
> index b7dea4e..35b20e6 100644
> --- a/drivers/usb/gadget/fsl_udc_core.c
> +++ b/drivers/usb/gadget/fsl_udc_core.c
> @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> fsl_udc_devtype[] = {
> }, {
> .name = "imx-udc-mx51",
> }, {
> + .name = "fsl-usb2-udc",
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing ppc socs. Many
of our customers are already using this, and we need to support them on this
driver. We do have plans to shift to chipidea, but after some time.
--
Thanks
SuresH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
Hi,
Thanks for reviewing my patches.
Please find my comments inline
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, March 13, 2014 8:56 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org; Gupta Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform
device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
From: Suresh Gupta b42...@freescale.com
Add FSL USB Gadget entry in platform device id table
why this tab ?
[SuresH] I will remove it in next version.
Signed-off-by: Suresh Gupta b42...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing ppc socs. Many
of our customers are already using this, and we need to support them on this
driver. We do have plans to shift to chipidea, but after some time.
--
Thanks
SuresH
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com wrote:
Hi,
Thanks for reviewing my patches.
Please find my comments inline
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, March 13, 2014 8:56 PM
To: Gupta Suresh-B42813
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org; Gupta Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform
device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
From: Suresh Gupta b42...@freescale.com
Add FSL USB Gadget entry in platform device id table
why this tab ?
[SuresH] I will remove it in next version.
Signed-off-by: Suresh Gupta b42...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing ppc
socs. Many of our customers are already using this, and we need to
support them on this driver. We do have plans to shift to chipidea,
but after some time.
cool, you already have plans, so we will see a new glue layer for v3.16
right ? Which means I don't need to take this patch either.
--
balbi
signature.asc
Description: Digital signature
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> From: Suresh Gupta
>
> Add FSL USB Gadget entry in platform device id table
why this tab ?
> Signed-off-by: Suresh Gupta
> ---
> drivers/usb/gadget/fsl_udc_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/fsl_udc_core.c
> b/drivers/usb/gadget/fsl_udc_core.c
> index b7dea4e..35b20e6 100644
> --- a/drivers/usb/gadget/fsl_udc_core.c
> +++ b/drivers/usb/gadget/fsl_udc_core.c
> @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> fsl_udc_devtype[] = {
> }, {
> .name = "imx-udc-mx51",
> }, {
> + .name = "fsl-usb2-udc",
why aren't you just using chipidea ?
--
balbi
signature.asc
Description: Digital signature
[PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
From: Suresh Gupta
Add FSL USB Gadget entry in platform device id table
Signed-off-by: Suresh Gupta
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id fsl_udc_devtype[]
= {
}, {
.name = "imx-udc-mx51",
}, {
+ .name = "fsl-usb2-udc",
+ }, {
/* sentinel */
}
};
--
1.7.11.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
From: Suresh Gupta b42...@freescale.com
Add FSL USB Gadget entry in platform device id table
Signed-off-by: Suresh Gupta b42...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id fsl_udc_devtype[]
= {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
+ }, {
/* sentinel */
}
};
--
1.7.11.7
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
From: Suresh Gupta b42...@freescale.com
Add FSL USB Gadget entry in platform device id table
why this tab ?
Signed-off-by: Suresh Gupta b42...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index b7dea4e..35b20e6 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2654,6 +2654,8 @@ static const struct platform_device_id
fsl_udc_devtype[] = {
}, {
.name = imx-udc-mx51,
}, {
+ .name = fsl-usb2-udc,
why aren't you just using chipidea ?
--
balbi
signature.asc
Description: Digital signature
