Re: [PATCH] usb_serial: Stop passing NULL to functions that expect data

2007-09-26 Thread Alan Cox 
On Wed, 26 Sep 2007 15:52:48 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:

> On Wed, 26 Sep 2007 23:08:40 +0100
> Alan Cox <[EMAIL PROTECTED]> wrote:
> 
> > Earlier patches have removed the checking for old v new differences from
> > the USB drivers so we can now pass in a valid blank old termios so that
> > we don't to fill the drivers with magic hacks for console support
> 
> Are all the prerequisites for these patches in mainline, or are there
> dependencies on -mm stuff here?

Sorry pre-req for the USB serial ones is the tty patch I sent you last
chunk that added tty_encode_baud_rate

I'd prefer them to sit in -mm a bit. I'm pretty sure most of them are
100% solid but I also want to see if we get any app breakages caused
by correcting our behaviour

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] usb_serial: Stop passing NULL to functions that expect data

2007-09-26 Thread Andrew Morton 
On Wed, 26 Sep 2007 23:08:40 +0100
Alan Cox <[EMAIL PROTECTED]> wrote:

> Earlier patches have removed the checking for old v new differences from
> the USB drivers so we can now pass in a valid blank old termios so that
> we don't to fill the drivers with magic hacks for console support

Are all the prerequisites for these patches in mainline, or are there
dependencies on -mm stuff here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] usb_serial: Stop passing NULL to functions that expect data

2007-09-26 Thread Alan Cox 
Earlier patches have removed the checking for old v new differences from
the USB drivers so we can now pass in a valid blank old termios so that
we don't to fill the drivers with magic hacks for console support

Signed-off-by: Alan Cox <[EMAIL PROTECTED]>

diff -u --new-file --exclude-from /usr/src/exclude --recursive 
linux.vanilla-2.6.23rc8-mm1/drivers/serial/serial_core.c 
linux-2.6.23rc8-mm1/drivers/serial/serial_core.c
--- linux.vanilla-2.6.23rc8-mm1/drivers/serial/serial_core.c2007-09-26 
16:46:54.0 +0100
+++ linux-2.6.23rc8-mm1/drivers/serial/serial_core.c2007-09-18 
16:28:20.0 +0100
@@ -1885,6 +1885,7 @@
 int baud, int parity, int bits, int flow)
 {
struct ktermios termios;
+   static struct ktermios dummy;
int i;
 
/*
@@ -1930,7 +1931,7 @@
 */
port->mctrl |= TIOCM_DTR;
 
-   port->ops->set_termios(port, &termios, NULL);
+   port->ops->set_termios(port, &termios, &dummy);
co->cflag = termios.c_cflag;
 
return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/