Re: [PATCH] v850: const-qualify first parameter of find_next_zero_bit

2005-07-20 Thread Bernd Petrovitsch 
On Wed, 2005-07-20 at 17:38 +0900, Miles Bader wrote:
[...]
> @@ -157,7 +157,7 @@
>  #define find_first_zero_bit(addr, size) \
>find_next_zero_bit ((addr), (size), 0)
>  
> -extern __inline__ int find_next_zero_bit (void *addr, int size, int offset)
> +extern __inline__ int find_next_zero_bit(const void *addr, int size, int 
> offset)
>  {
>   unsigned long *p = ((unsigned long *) addr) + (offset >> 5);

Why not const-qualify *p and the cast also (avoiding warnings and
actually making the change complete)?

Bernd
-- 
Firmix Software GmbH   http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
  Embedded Linux Development and Services

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] v850: const-qualify first parameter of find_next_zero_bit

2005-07-20 Thread Miles Bader 
Signed-off-by: Miles Bader <[EMAIL PROTECTED]>

 include/asm-v850/bitops.h |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -ruN -X../cludes linux-2.6.12-uc0/include/asm-v850/bitops.h 
linux-2.6.12-uc0-v850-20050720/include/asm-v850/bitops.h
--- linux-2.6.12-uc0/include/asm-v850/bitops.h  2004-08-16 14:48:15.606748000 
+0900
+++ linux-2.6.12-uc0-v850-20050720/include/asm-v850/bitops.h2005-07-20 
17:08:31.442593000 +0900
@@ -1,8 +1,8 @@
 /*
  * include/asm-v850/bitops.h -- Bit operations
  *
- *  Copyright (C) 2001,02,03,04  NEC Electronics Corporation
- *  Copyright (C) 2001,02,03,04  Miles Bader <[EMAIL PROTECTED]>
+ *  Copyright (C) 2001,02,03,04,05  NEC Electronics Corporation
+ *  Copyright (C) 2001,02,03,04,05  Miles Bader <[EMAIL PROTECTED]>
  *  Copyright (C) 1992  Linus Torvalds.
  *
  * This file is subject to the terms and conditions of the GNU General
@@ -157,7 +157,7 @@
 #define find_first_zero_bit(addr, size) \
   find_next_zero_bit ((addr), (size), 0)
 
-extern __inline__ int find_next_zero_bit (void *addr, int size, int offset)
+extern __inline__ int find_next_zero_bit(const void *addr, int size, int 
offset)
 {
unsigned long *p = ((unsigned long *) addr) + (offset >> 5);
unsigned long result = offset & ~31UL;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] v850: const-qualify first parameter of find_next_zero_bit

2005-07-20 Thread Miles Bader 
Signed-off-by: Miles Bader [EMAIL PROTECTED]

 include/asm-v850/bitops.h |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -ruN -X../cludes linux-2.6.12-uc0/include/asm-v850/bitops.h 
linux-2.6.12-uc0-v850-20050720/include/asm-v850/bitops.h
--- linux-2.6.12-uc0/include/asm-v850/bitops.h  2004-08-16 14:48:15.606748000 
+0900
+++ linux-2.6.12-uc0-v850-20050720/include/asm-v850/bitops.h2005-07-20 
17:08:31.442593000 +0900
@@ -1,8 +1,8 @@
 /*
  * include/asm-v850/bitops.h -- Bit operations
  *
- *  Copyright (C) 2001,02,03,04  NEC Electronics Corporation
- *  Copyright (C) 2001,02,03,04  Miles Bader [EMAIL PROTECTED]
+ *  Copyright (C) 2001,02,03,04,05  NEC Electronics Corporation
+ *  Copyright (C) 2001,02,03,04,05  Miles Bader [EMAIL PROTECTED]
  *  Copyright (C) 1992  Linus Torvalds.
  *
  * This file is subject to the terms and conditions of the GNU General
@@ -157,7 +157,7 @@
 #define find_first_zero_bit(addr, size) \
   find_next_zero_bit ((addr), (size), 0)
 
-extern __inline__ int find_next_zero_bit (void *addr, int size, int offset)
+extern __inline__ int find_next_zero_bit(const void *addr, int size, int 
offset)
 {
unsigned long *p = ((unsigned long *) addr) + (offset  5);
unsigned long result = offset  ~31UL;
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] v850: const-qualify first parameter of find_next_zero_bit

2005-07-20 Thread Bernd Petrovitsch 
On Wed, 2005-07-20 at 17:38 +0900, Miles Bader wrote:
[...]
 @@ -157,7 +157,7 @@
  #define find_first_zero_bit(addr, size) \
find_next_zero_bit ((addr), (size), 0)
  
 -extern __inline__ int find_next_zero_bit (void *addr, int size, int offset)
 +extern __inline__ int find_next_zero_bit(const void *addr, int size, int 
 offset)
  {
   unsigned long *p = ((unsigned long *) addr) + (offset  5);

Why not const-qualify *p and the cast also (avoiding warnings and
actually making the change complete)?

Bernd
-- 
Firmix Software GmbH   http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
  Embedded Linux Development and Services

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/