[PATCH] vt: fix potential dual con_driver register for conswitchp
We should check whether conswitchp is registered before add it to registered_con_driver in con_init, or it will cause dual con_driver register for conswitchp. Although I haven't met it in reality, but I think it could happen for Embeded devices, who register platform con_driver earlier than call con_init. Signed-off-by: Wang YanQing --- drivers/tty/vt/vt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index edcd6b8..3de4504 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -2876,6 +2876,8 @@ static int __init con_init(void) for (i = 0; i < MAX_NR_CON_DRIVER; i++) { struct con_driver *con_driver = _con_driver[i]; + if (con_driver->con == conswitchp) + break; if (con_driver->con == NULL) { con_driver->con = conswitchp; con_driver->desc = display_desc; -- 1.8.3.4.8.g69490f3.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] vt: fix potential dual con_driver register for conswitchp
We should check whether conswitchp is registered before add it to registered_con_driver in con_init, or it will cause dual con_driver register for conswitchp. Although I haven't met it in reality, but I think it could happen for Embeded devices, who register platform con_driver earlier than call con_init. Signed-off-by: Wang YanQing udkni...@gmail.com --- drivers/tty/vt/vt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index edcd6b8..3de4504 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -2876,6 +2876,8 @@ static int __init con_init(void) for (i = 0; i MAX_NR_CON_DRIVER; i++) { struct con_driver *con_driver = registered_con_driver[i]; + if (con_driver-con == conswitchp) + break; if (con_driver-con == NULL) { con_driver-con = conswitchp; con_driver-desc = display_desc; -- 1.8.3.4.8.g69490f3.dirty -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/