[PATCH] x86, setup: Additional __flush_tlb for Quak X1000
Hi, With respect to submission sent below: "x86: Quark: Comment setup_arch for TLB/PGE bugfix" __flush_tlb_all() does not take __flush_tlb() because cpu_has_pge flag that is setup in head_32.S by CPUID and not changed much later. So, the comment added are incorrect. Explaination below: For change on: "x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead" The X86_FEATURE_PGE cap is cleared in early_cpu_init() --> early_identify_cpu() --> early_init_intel(). And, early_cpu_init() is performed after the __flush_tlb_all() step. Anyway, thanks to Bryan for submitting patch for Quark SoC. FYI, the suggestion to add __flush_tlb() has been discussed with some of the kernel developers CC'ed below inclusing HPA himself. Thank you very much, Ong Boon Leong Ong Boon Leong (1): x86, setup: add __flush_tlb() for Intel Quark X1000 arch/x86/kernel/setup.c |7 +++ 1 file changed, 7 insertions(+) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] x86, setup: Additional __flush_tlb for Quak X1000
Hi, With respect to submission sent below: x86: Quark: Comment setup_arch for TLB/PGE bugfix __flush_tlb_all() does not take __flush_tlb() because cpu_has_pge flag that is setup in head_32.S by CPUID and not changed much later. So, the comment added are incorrect. Explaination below: For change on: x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead The X86_FEATURE_PGE cap is cleared in early_cpu_init() -- early_identify_cpu() -- early_init_intel(). And, early_cpu_init() is performed after the __flush_tlb_all() step. Anyway, thanks to Bryan for submitting patch for Quark SoC. FYI, the suggestion to add __flush_tlb() has been discussed with some of the kernel developers CC'ed below inclusing HPA himself. Thank you very much, Ong Boon Leong Ong Boon Leong (1): x86, setup: add __flush_tlb() for Intel Quark X1000 arch/x86/kernel/setup.c |7 +++ 1 file changed, 7 insertions(+) -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
