Re: [PATCH] x86/boot: Fix if_changed build flip/flop
2018-07-16 7:58 GMT+09:00 Ingo Molnar :
>
> * Kees Cook wrote:
>
>> The if_changed kbuild function can only be used once per target. If not
>> it will effectively always trigger, flipping back and forth between the
>> two commands getting recorded. Instead, merge the two commands into a
>> single function to get stable build artifacts (i.e. .vmlinux.cmd).
>>
>> Reported-by: Dirk Gouders
>
> What actual symptoms does this bug have?
>
> I.e. it would be nice if the changelog started with such an explanation:
>
> Dirk Gouders reported that ...
> and bisected it back to:
>
> 98f78525371b ("x86/boot: Refuse to build with data relocations")
>
> The root cause of the bug is that the if_changed kbuild function ...
>
> Or something like that.
>
> Thanks,
>
> Ingo
Anyway, the code diff looks good to me.
Reviewed-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
Re: [PATCH] x86/boot: Fix if_changed build flip/flop
2018-07-16 7:58 GMT+09:00 Ingo Molnar :
>
> * Kees Cook wrote:
>
>> The if_changed kbuild function can only be used once per target. If not
>> it will effectively always trigger, flipping back and forth between the
>> two commands getting recorded. Instead, merge the two commands into a
>> single function to get stable build artifacts (i.e. .vmlinux.cmd).
>>
>> Reported-by: Dirk Gouders
>
> What actual symptoms does this bug have?
>
> I.e. it would be nice if the changelog started with such an explanation:
>
> Dirk Gouders reported that ...
> and bisected it back to:
>
> 98f78525371b ("x86/boot: Refuse to build with data relocations")
>
> The root cause of the bug is that the if_changed kbuild function ...
>
> Or something like that.
>
> Thanks,
>
> Ingo
Anyway, the code diff looks good to me.
Reviewed-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
Re: [PATCH] x86/boot: Fix if_changed build flip/flop
* Kees Cook wrote:
> The if_changed kbuild function can only be used once per target. If not
> it will effectively always trigger, flipping back and forth between the
> two commands getting recorded. Instead, merge the two commands into a
> single function to get stable build artifacts (i.e. .vmlinux.cmd).
>
> Reported-by: Dirk Gouders
What actual symptoms does this bug have?
I.e. it would be nice if the changelog started with such an explanation:
Dirk Gouders reported that ...
and bisected it back to:
98f78525371b ("x86/boot: Refuse to build with data relocations")
The root cause of the bug is that the if_changed kbuild function ...
Or something like that.
Thanks,
Ingo
Re: [PATCH] x86/boot: Fix if_changed build flip/flop
* Kees Cook wrote:
> The if_changed kbuild function can only be used once per target. If not
> it will effectively always trigger, flipping back and forth between the
> two commands getting recorded. Instead, merge the two commands into a
> single function to get stable build artifacts (i.e. .vmlinux.cmd).
>
> Reported-by: Dirk Gouders
What actual symptoms does this bug have?
I.e. it would be nice if the changelog started with such an explanation:
Dirk Gouders reported that ...
and bisected it back to:
98f78525371b ("x86/boot: Refuse to build with data relocations")
The root cause of the bug is that the if_changed kbuild function ...
Or something like that.
Thanks,
Ingo
[PATCH] x86/boot: Fix if_changed build flip/flop
The if_changed kbuild function can only be used once per target. If not
it will effectively always trigger, flipping back and forth between the
two commands getting recorded. Instead, merge the two commands into a
single function to get stable build artifacts (i.e. .vmlinux.cmd).
Reported-by: Dirk Gouders
Suggested-by: Masahiro Yamada
Fixes: 98f78525371b ("x86/boot: Refuse to build with data relocations")
Signed-off-by: Kees Cook
---
arch/x86/boot/compressed/Makefile | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/x86/boot/compressed/Makefile
b/arch/x86/boot/compressed/Makefile
index fa42f895fdde..169c2feda14a 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -106,9 +106,13 @@ define cmd_check_data_rel
done
endef
+# We need to run two commands under "if_changed", so merge them into a
+# single invocation.
+quiet_cmd_check-and-link-vmlinux = LD $@
+ cmd_check-and-link-vmlinux = $(cmd_check_data_rel); $(cmd_ld)
+
$(obj)/vmlinux: $(vmlinux-objs-y) FORCE
- $(call if_changed,check_data_rel)
- $(call if_changed,ld)
+ $(call if_changed,check-and-link-vmlinux)
OBJCOPYFLAGS_vmlinux.bin := -R .comment -S
$(obj)/vmlinux.bin: vmlinux FORCE
--
2.17.1
--
Kees Cook
Pixel Security
[PATCH] x86/boot: Fix if_changed build flip/flop
The if_changed kbuild function can only be used once per target. If not
it will effectively always trigger, flipping back and forth between the
two commands getting recorded. Instead, merge the two commands into a
single function to get stable build artifacts (i.e. .vmlinux.cmd).
Reported-by: Dirk Gouders
Suggested-by: Masahiro Yamada
Fixes: 98f78525371b ("x86/boot: Refuse to build with data relocations")
Signed-off-by: Kees Cook
---
arch/x86/boot/compressed/Makefile | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/x86/boot/compressed/Makefile
b/arch/x86/boot/compressed/Makefile
index fa42f895fdde..169c2feda14a 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -106,9 +106,13 @@ define cmd_check_data_rel
done
endef
+# We need to run two commands under "if_changed", so merge them into a
+# single invocation.
+quiet_cmd_check-and-link-vmlinux = LD $@
+ cmd_check-and-link-vmlinux = $(cmd_check_data_rel); $(cmd_ld)
+
$(obj)/vmlinux: $(vmlinux-objs-y) FORCE
- $(call if_changed,check_data_rel)
- $(call if_changed,ld)
+ $(call if_changed,check-and-link-vmlinux)
OBJCOPYFLAGS_vmlinux.bin := -R .comment -S
$(obj)/vmlinux.bin: vmlinux FORCE
--
2.17.1
--
Kees Cook
Pixel Security
