Re: [PATCH] x86/dumpstack: make show_trace_log_lvl() static

[Petr Mladek]

On Fri 2020-11-13 21:39:43, Hui Su wrote:
> show_trace_log_lvl() won't be used by other files, so
> make it static and remove the declaration from the header
> file.
> 
> Signed-off-by: Hui Su 

I would make sense to add:

Fixes: 16d1cb0bc43642a4d9 ("x86/dumpstack: Unify show_regs()")

Othrewise, it looks good:

Reviewed-by: Petr Mladek 

Best Regards,
Petr

[PATCH] x86/dumpstack: make show_trace_log_lvl() static

[Hui Su]

show_trace_log_lvl() won't be used by other files, so
make it static and remove the declaration from the header
file.

Signed-off-by: Hui Su 
---
 arch/x86/include/asm/stacktrace.h | 3 ---
 arch/x86/kernel/dumpstack.c   | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/x86/include/asm/stacktrace.h 
b/arch/x86/include/asm/stacktrace.h
index 49600643faba..f248eb2ac2d4 100644
--- a/arch/x86/include/asm/stacktrace.h
+++ b/arch/x86/include/asm/stacktrace.h
@@ -88,9 +88,6 @@ get_stack_pointer(struct task_struct *task, struct pt_regs 
*regs)
return (unsigned long *)task->thread.sp;
 }
 
-void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
-   unsigned long *stack, const char *log_lvl);
-
 /* The form of the top of the frame on the stack */
 struct stack_frame {
struct stack_frame *next_frame;
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 25c06b67e7e0..067de0d0fa4f 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -168,7 +168,7 @@ static void show_regs_if_on_stack(struct stack_info *info, 
struct pt_regs *regs,
}
 }
 
-void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
+static void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
unsigned long *stack, const char *log_lvl)
 {
struct unwind_state state;
-- 
2.29.0