Re: [PATCH] x86: Reset FPU on exec

2015-04-21 Thread Thomas Gleixner 
Andi,

On Tue, 21 Apr 2015, Andi Kleen wrote:
> > What's the exact purpose of this patch aside of breaking the build?
> 
> Try reading the description?

I'll try to decrypt that once I have a functional patch.
 
> Also it builds fine here.

I don't care whether it builds for you on your random tree. I care
whether it compiles against the relevant reference trees (tip/linus).

And it CANNOT compile against them at all. Simply because
drop_init_fpu() does not exist.

You are just out there to waste maintainer time and annoy everyone
who has the displeasure to handle your sloppy patches and deal with
your obnoxious unwillingness to cooperate, aren't you?

Thanks,

tglx






--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: Reset FPU on exec

2015-04-21 Thread Andi Kleen 
On Tue, Apr 21, 2015 at 11:35:58AM +0200, Thomas Gleixner wrote:
> On Fri, 17 Apr 2015, Andi Kleen wrote:
> 
> > +void reset_fpu(void)
> > +{
> > +   drop_init_fpu(current);
> > +}
> 
> So we have a new function which is merily a wrapper around a non
> existent function. 

I originally tried to use the inline function directly, but 
it's defined in "fpu-internal.h" and including it in asm/elf.h
causing all kinds of issues.

> 
> What's the exact purpose of this patch aside of breaking the build?

Try reading the description?

Also it builds fine here.

-Andi
-- 
a...@linux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: Reset FPU on exec

2015-04-21 Thread Thomas Gleixner 
On Fri, 17 Apr 2015, Andi Kleen wrote:

> +void reset_fpu(void)
> +{
> + drop_init_fpu(current);
> +}

So we have a new function which is merily a wrapper around a non
existent function. 

What's the exact purpose of this patch aside of breaking the build?

May I recommend reading and following Documentation/SubmittingPatches?

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: Reset FPU on exec

2015-04-21 Thread Thomas Gleixner 
On Fri, 17 Apr 2015, Andi Kleen wrote:

 +void reset_fpu(void)
 +{
 + drop_init_fpu(current);
 +}

So we have a new function which is merily a wrapper around a non
existent function. 

What's the exact purpose of this patch aside of breaking the build?

May I recommend reading and following Documentation/SubmittingPatches?

Thanks,

tglx
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: Reset FPU on exec

2015-04-21 Thread Andi Kleen 
On Tue, Apr 21, 2015 at 11:35:58AM +0200, Thomas Gleixner wrote:
 On Fri, 17 Apr 2015, Andi Kleen wrote:
 
  +void reset_fpu(void)
  +{
  +   drop_init_fpu(current);
  +}
 
 So we have a new function which is merily a wrapper around a non
 existent function. 

I originally tried to use the inline function directly, but 
it's defined in fpu-internal.h and including it in asm/elf.h
causing all kinds of issues.

 
 What's the exact purpose of this patch aside of breaking the build?

Try reading the description?

Also it builds fine here.

-Andi
-- 
a...@linux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: Reset FPU on exec

2015-04-21 Thread Thomas Gleixner 
Andi,

On Tue, 21 Apr 2015, Andi Kleen wrote:
  What's the exact purpose of this patch aside of breaking the build?
 
 Try reading the description?

I'll try to decrypt that once I have a functional patch.
 
 Also it builds fine here.

I don't care whether it builds for you on your random tree. I care
whether it compiles against the relevant reference trees (tip/linus).

And it CANNOT compile against them at all. Simply because
drop_init_fpu() does not exist.

You are just out there to waste maintainer time and annoy everyone
who has the displeasure to handle your sloppy patches and deal with
your obnoxious unwillingness to cooperate, aren't you?

Thanks,

tglx






--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] x86: Reset FPU on exec

2015-04-17 Thread Andi Kleen 
From: Andi Kleen 

Currently we don't reset FPU state on exec. This can be seen as a
(minor) security issue. The bigger issue however is that the
AVX state also does not get reset. So a program that uses SSE
without VZEROUPPER may get a large penalty.

Always set the FPU to the init state at exec time.

For the eager FPU case this restores the init state,
for non eager it forces an init on the next FPU use.

Signed-off-by: Andi Kleen 
---
 arch/x86/include/asm/elf.h | 4 
 arch/x86/kernel/xsave.c| 5 +
 2 files changed, 9 insertions(+)

diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h
index ca3347a..56ab629 100644
--- a/arch/x86/include/asm/elf.h
+++ b/arch/x86/include/asm/elf.h
@@ -90,6 +90,8 @@ extern unsigned int vdso32_enabled;
 
 #include 
 
+extern void reset_fpu(void);
+
 #ifdef CONFIG_X86_32
 #include 
 
@@ -110,6 +112,7 @@ extern unsigned int vdso32_enabled;
_r->bx = 0; _r->cx = 0; _r->dx = 0; \
_r->si = 0; _r->di = 0; _r->bp = 0; \
_r->ax = 0; \
+   reset_fpu();\
 } while (0)
 
 /*
@@ -178,6 +181,7 @@ static inline void elf_common_init(struct thread_struct *t,
t->fs = t->gs = 0;
t->fsindex = t->gsindex = 0;
t->ds = t->es = ds;
+   reset_fpu();
 }
 
 #define ELF_PLAT_INIT(_r, load_addr)   \
diff --git a/arch/x86/kernel/xsave.c b/arch/x86/kernel/xsave.c
index cdc6cf9..520e505 100644
--- a/arch/x86/kernel/xsave.c
+++ b/arch/x86/kernel/xsave.c
@@ -741,3 +741,8 @@ void *get_xsave_addr(struct xsave_struct *xsave, int xstate)
return (void *)xsave + xstate_comp_offsets[feature];
 }
 EXPORT_SYMBOL_GPL(get_xsave_addr);
+
+void reset_fpu(void)
+{
+   drop_init_fpu(current);
+}
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] x86: Reset FPU on exec

2015-04-17 Thread Andi Kleen 
From: Andi Kleen a...@linux.intel.com

Currently we don't reset FPU state on exec. This can be seen as a
(minor) security issue. The bigger issue however is that the
AVX state also does not get reset. So a program that uses SSE
without VZEROUPPER may get a large penalty.

Always set the FPU to the init state at exec time.

For the eager FPU case this restores the init state,
for non eager it forces an init on the next FPU use.

Signed-off-by: Andi Kleen a...@linux.intel.com
---
 arch/x86/include/asm/elf.h | 4 
 arch/x86/kernel/xsave.c| 5 +
 2 files changed, 9 insertions(+)

diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h
index ca3347a..56ab629 100644
--- a/arch/x86/include/asm/elf.h
+++ b/arch/x86/include/asm/elf.h
@@ -90,6 +90,8 @@ extern unsigned int vdso32_enabled;
 
 #include asm/processor.h
 
+extern void reset_fpu(void);
+
 #ifdef CONFIG_X86_32
 #include asm/desc.h
 
@@ -110,6 +112,7 @@ extern unsigned int vdso32_enabled;
_r-bx = 0; _r-cx = 0; _r-dx = 0; \
_r-si = 0; _r-di = 0; _r-bp = 0; \
_r-ax = 0; \
+   reset_fpu();\
 } while (0)
 
 /*
@@ -178,6 +181,7 @@ static inline void elf_common_init(struct thread_struct *t,
t-fs = t-gs = 0;
t-fsindex = t-gsindex = 0;
t-ds = t-es = ds;
+   reset_fpu();
 }
 
 #define ELF_PLAT_INIT(_r, load_addr)   \
diff --git a/arch/x86/kernel/xsave.c b/arch/x86/kernel/xsave.c
index cdc6cf9..520e505 100644
--- a/arch/x86/kernel/xsave.c
+++ b/arch/x86/kernel/xsave.c
@@ -741,3 +741,8 @@ void *get_xsave_addr(struct xsave_struct *xsave, int xstate)
return (void *)xsave + xstate_comp_offsets[feature];
 }
 EXPORT_SYMBOL_GPL(get_xsave_addr);
+
+void reset_fpu(void)
+{
+   drop_init_fpu(current);
+}
-- 
1.9.3

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/