Re: [PATCH] xen/xtime: remove incorrect preemption enabled assert

2015-01-14 Thread Boris Ostrovsky 

On 01/14/2015 04:34 PM, Imre Deak wrote:

Signed-off-by: Imre Deak 
---
  arch/x86/xen/time.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index f473d26..23019b4 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -458,8 +458,6 @@ void xen_setup_timer(int cpu)
  
  void xen_setup_cpu_clockevents(void)

  {
-   BUG_ON(preemptible());
-
clockevents_register_device(this_cpu_ptr(_clock_events.evt));
  }
  



This is already in the tree. Commit 8b8cd8a3673d.

Thanks.
-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] xen/xtime: remove incorrect preemption enabled assert

2015-01-14 Thread Imre Deak 
Since

commit 250a1ac685f147d4f4b2f132cfaffcce1a6792c1
Author: Thomas Gleixner 
Date:   Fri Dec 5 08:48:29 2014 +

x86, smpboot: Remove pointless preempt_disable() in
native_smp_prepare_cpus()

the assert in xen_setup_cpu_clockevents() is incorrect, causing the
following BUG:

[0.192725] smpboot: CPU0: Intel(R) Core(TM) i7-3770S CPU @ 3.10GHz (fam: 
06, model: 2e, stepping: 09)
[0.201926] Xen: using vcpuop timer interface
[0.204011] installing Xen timer for CPU 0
[0.208085] [ cut here ]
[0.212000] kernel BUG at arch/x86/xen/time.c:461!
[0.212000] invalid opcode:  [#1] PREEMPT SMP
[0.212000] Modules linked in:
[0.212000] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc4-imre+ #4
[0.212000] Hardware name: Xen HVM domU, BIOS 4.1.2 10/16/2014
[0.212000] task: 88003c17 ti: 88003c178000 task.ti: 
88003c178000
[0.212000] RIP: 0010:[]  [] 
xen_setup_cpu_clockevents+0x23/0x50
[0.212000] RSP: :88003c17be58  EFLAGS: 00010202
[0.212000] RAX: 0246 RBX:  RCX: 
[0.212000] RDX:  RSI: 81800240 RDI: 88003dc0af40
[0.212000] RBP: 88003c17be68 R08: 0048 R09: 000d
[0.212000] R10:  R11: 0282 R12: a0e8
[0.212000] R13: a0f0 R14: 000f R15: 000e
[0.212000] FS:  () GS:88003dc0() 
knlGS:
[0.212000] CS:  0010 DS:  ES:  CR0: 8005003b
[0.212000] CR2: 880002ec CR3: 01c12000 CR4: 001006f0
[0.212000] Stack:
[0.212000]  000f  88003c17be98 
81daf60d
[0.212000]  54b5c08c 3435ca0a  

[0.212000]  88003c17bee8 81dbc286 88003c17 
2282
[0.212000] Call Trace:
[0.212000]  [] xen_time_init+0x85/0xb3
[0.212000]  [] native_smp_prepare_cpus+0x34e/0x396
[0.212000]  [] xen_hvm_smp_prepare_cpus+0x9/0x27
[0.212000]  [] kernel_init_freeable+0x120/0x26a
[0.212000]  [] ? kernel_init+0xe/0xf0
[0.212000]  [] ? rest_init+0xd0/0xd0
[0.212000]  [] kernel_init+0xe/0xf0
[0.212000]  [] ret_from_fork+0x7c/0xb0
[0.212000]  [] ? rest_init+0xd0/0xd0
[0.212000] Code: 5e 41 5f 5d c3 0f 1f 00 55 48 89 e5 53 48 83 ec 08 65 8b 
05 80 dd ff 7e a9 ff ff ff 7f 75 11 9c 58 66 66 90 66 90 f6 c4 02 74 05 <0f> 0b 
0f 1f 00 e8 33 47 34 00 89 c0 48 c7 c3 80 ae 00 00 48 89
[0.212000] RIP  [] xen_setup_cpu_clockevents+0x23/0x50
[0.212000]  RSP 
[0.428007] ---[ end trace 73a740f3f01d4332 ]---
[0.432017] Kernel panic - not syncing: Attempted to kill init! 
exitcode=0x000b

Signed-off-by: Imre Deak 
---
 arch/x86/xen/time.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index f473d26..23019b4 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -458,8 +458,6 @@ void xen_setup_timer(int cpu)
 
 void xen_setup_cpu_clockevents(void)
 {
-   BUG_ON(preemptible());
-
clockevents_register_device(this_cpu_ptr(_clock_events.evt));
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] xen/xtime: remove incorrect preemption enabled assert

2015-01-14 Thread Imre Deak 
Since

commit 250a1ac685f147d4f4b2f132cfaffcce1a6792c1
Author: Thomas Gleixner t...@linutronix.de
Date:   Fri Dec 5 08:48:29 2014 +

x86, smpboot: Remove pointless preempt_disable() in
native_smp_prepare_cpus()

the assert in xen_setup_cpu_clockevents() is incorrect, causing the
following BUG:

[0.192725] smpboot: CPU0: Intel(R) Core(TM) i7-3770S CPU @ 3.10GHz (fam: 
06, model: 2e, stepping: 09)
[0.201926] Xen: using vcpuop timer interface
[0.204011] installing Xen timer for CPU 0
[0.208085] [ cut here ]
[0.212000] kernel BUG at arch/x86/xen/time.c:461!
[0.212000] invalid opcode:  [#1] PREEMPT SMP
[0.212000] Modules linked in:
[0.212000] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc4-imre+ #4
[0.212000] Hardware name: Xen HVM domU, BIOS 4.1.2 10/16/2014
[0.212000] task: 88003c17 ti: 88003c178000 task.ti: 
88003c178000
[0.212000] RIP: 0010:[8100dc73]  [8100dc73] 
xen_setup_cpu_clockevents+0x23/0x50
[0.212000] RSP: :88003c17be58  EFLAGS: 00010202
[0.212000] RAX: 0246 RBX:  RCX: 
[0.212000] RDX:  RSI: 81800240 RDI: 88003dc0af40
[0.212000] RBP: 88003c17be68 R08: 0048 R09: 000d
[0.212000] R10:  R11: 0282 R12: a0e8
[0.212000] R13: a0f0 R14: 000f R15: 000e
[0.212000] FS:  () GS:88003dc0() 
knlGS:
[0.212000] CS:  0010 DS:  ES:  CR0: 8005003b
[0.212000] CR2: 880002ec CR3: 01c12000 CR4: 001006f0
[0.212000] Stack:
[0.212000]  000f  88003c17be98 
81daf60d
[0.212000]  54b5c08c 3435ca0a  

[0.212000]  88003c17bee8 81dbc286 88003c17 
2282
[0.212000] Call Trace:
[0.212000]  [81daf60d] xen_time_init+0x85/0xb3
[0.212000]  [81dbc286] native_smp_prepare_cpus+0x34e/0x396
[0.212000]  [81db0cc0] xen_hvm_smp_prepare_cpus+0x9/0x27
[0.212000]  [81dab20b] kernel_init_freeable+0x120/0x26a
[0.212000]  [8175c4fe] ? kernel_init+0xe/0xf0
[0.212000]  [8175c4f0] ? rest_init+0xd0/0xd0
[0.212000]  [8175c4fe] kernel_init+0xe/0xf0
[0.212000]  [8176e7bc] ret_from_fork+0x7c/0xb0
[0.212000]  [8175c4f0] ? rest_init+0xd0/0xd0
[0.212000] Code: 5e 41 5f 5d c3 0f 1f 00 55 48 89 e5 53 48 83 ec 08 65 8b 
05 80 dd ff 7e a9 ff ff ff 7f 75 11 9c 58 66 66 90 66 90 f6 c4 02 74 05 0f 0b 
0f 1f 00 e8 33 47 34 00 89 c0 48 c7 c3 80 ae 00 00 48 89
[0.212000] RIP  [8100dc73] xen_setup_cpu_clockevents+0x23/0x50
[0.212000]  RSP 88003c17be58
[0.428007] ---[ end trace 73a740f3f01d4332 ]---
[0.432017] Kernel panic - not syncing: Attempted to kill init! 
exitcode=0x000b

Signed-off-by: Imre Deak imre.d...@intel.com
---
 arch/x86/xen/time.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index f473d26..23019b4 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -458,8 +458,6 @@ void xen_setup_timer(int cpu)
 
 void xen_setup_cpu_clockevents(void)
 {
-   BUG_ON(preemptible());
-
clockevents_register_device(this_cpu_ptr(xen_clock_events.evt));
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] xen/xtime: remove incorrect preemption enabled assert

2015-01-14 Thread Boris Ostrovsky 

On 01/14/2015 04:34 PM, Imre Deak wrote:

Signed-off-by: Imre Deak imre.d...@intel.com
---
  arch/x86/xen/time.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index f473d26..23019b4 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -458,8 +458,6 @@ void xen_setup_timer(int cpu)
  
  void xen_setup_cpu_clockevents(void)

  {
-   BUG_ON(preemptible());
-
clockevents_register_device(this_cpu_ptr(xen_clock_events.evt));
  }
  



This is already in the tree. Commit 8b8cd8a3673d.

Thanks.
-boris
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/