Re: [PATCH] xen-blkfront: use a right index when checking requests
On Wed, Aug 09, 2017 at 03:31:40PM -0700, Munehisa Kamata wrote:
> Since commit d05d7f40791c ("Merge branch 'for-4.8/core' of
> git://git.kernel.dk/linux-block") and 3fc9d690936f ("Merge branch
> 'for-4.8/drivers' of git://git.kernel.dk/linux-block"), blkfront_resume()
> has been using an index for iterating ring_info to check request when
> iterating blk_shadow in an inner loop. This seems to have been
> accidentally introduced during the massive rewrite of the block layer
> macros in the commits.
>
> This may cause crash like this:
>
> [11798.057074] BUG: unable to handle kernel NULL pointer dereference at
> 0048
> [11798.058832] IP: [] blkfront_resume+0x10a/0x610
>
> [11798.061063] Call Trace:
> [11798.061063] [] xenbus_dev_resume+0x53/0x140
> [11798.061063] [] ? xenbus_dev_probe+0x150/0x150
> [11798.061063] [] dpm_run_callback+0x3e/0x110
> [11798.061063] [] device_resume+0x88/0x190
> [11798.061063] [] dpm_resume+0x100/0x2d0
> [11798.061063] [] dpm_resume_end+0x11/0x20
> [11798.061063] [] do_suspend+0xe8/0x1a0
> [11798.061063] [] shutdown_handler+0xfd/0x130
> [11798.061063] [] ? split+0x110/0x110
> [11798.061063] [] xenwatch_thread+0x86/0x120
> [11798.061063] [] ? prepare_to_wait_event+0x110/0x110
> [11798.061063] [] kthread+0xd7/0xf0
> [11798.061063] [] ? kfree+0x121/0x170
> [11798.061063] [] ? kthread_park+0x60/0x60
> [11798.061063] [] ?
> call_usermodehelper_exec_work+0xb0/0xb0
> [11798.061063] [] ?
> call_usermodehelper_exec_async+0x13a/0x140
> [11798.061063] [] ret_from_fork+0x25/0x30
>
> Use the right index in the inner loop.
>
> Fixes: d05d7f40791c ("Merge branch 'for-4.8/core' of
> git://git.kernel.dk/linux-block")
> Fixes: 3fc9d690936f ("Merge branch 'for-4.8/drivers' of
> git://git.kernel.dk/linux-block")
> Signed-off-by: Munehisa Kamata
> Reviewed-by: Thomas Friebel
> Reviewed-by: Eduardo Valentin
> Cc: Boris Ostrovsky
> Cc: Juergen Gross
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monne
> Cc: xen-de...@lists.xenproject.org
> Cc: sta...@vger.kernel.org
Reviewed-by: Roger Pau Monné
Thanks, Roger.
Re: [PATCH] xen-blkfront: use a right index when checking requests
On Wed, Aug 09, 2017 at 03:31:40PM -0700, Munehisa Kamata wrote:
> Since commit d05d7f40791c ("Merge branch 'for-4.8/core' of
> git://git.kernel.dk/linux-block") and 3fc9d690936f ("Merge branch
> 'for-4.8/drivers' of git://git.kernel.dk/linux-block"), blkfront_resume()
> has been using an index for iterating ring_info to check request when
> iterating blk_shadow in an inner loop. This seems to have been
> accidentally introduced during the massive rewrite of the block layer
> macros in the commits.
>
> This may cause crash like this:
>
> [11798.057074] BUG: unable to handle kernel NULL pointer dereference at
> 0048
> [11798.058832] IP: [] blkfront_resume+0x10a/0x610
>
> [11798.061063] Call Trace:
> [11798.061063] [] xenbus_dev_resume+0x53/0x140
> [11798.061063] [] ? xenbus_dev_probe+0x150/0x150
> [11798.061063] [] dpm_run_callback+0x3e/0x110
> [11798.061063] [] device_resume+0x88/0x190
> [11798.061063] [] dpm_resume+0x100/0x2d0
> [11798.061063] [] dpm_resume_end+0x11/0x20
> [11798.061063] [] do_suspend+0xe8/0x1a0
> [11798.061063] [] shutdown_handler+0xfd/0x130
> [11798.061063] [] ? split+0x110/0x110
> [11798.061063] [] xenwatch_thread+0x86/0x120
> [11798.061063] [] ? prepare_to_wait_event+0x110/0x110
> [11798.061063] [] kthread+0xd7/0xf0
> [11798.061063] [] ? kfree+0x121/0x170
> [11798.061063] [] ? kthread_park+0x60/0x60
> [11798.061063] [] ?
> call_usermodehelper_exec_work+0xb0/0xb0
> [11798.061063] [] ?
> call_usermodehelper_exec_async+0x13a/0x140
> [11798.061063] [] ret_from_fork+0x25/0x30
>
> Use the right index in the inner loop.
>
> Fixes: d05d7f40791c ("Merge branch 'for-4.8/core' of
> git://git.kernel.dk/linux-block")
> Fixes: 3fc9d690936f ("Merge branch 'for-4.8/drivers' of
> git://git.kernel.dk/linux-block")
> Signed-off-by: Munehisa Kamata
> Reviewed-by: Thomas Friebel
> Reviewed-by: Eduardo Valentin
> Cc: Boris Ostrovsky
> Cc: Juergen Gross
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monne
> Cc: xen-de...@lists.xenproject.org
> Cc: sta...@vger.kernel.org
Reviewed-by: Roger Pau Monné
Thanks, Roger.
Re: [PATCH] xen-blkfront: use a right index when checking requests
On 08/09/2017 06:31 PM, Munehisa Kamata wrote:
Since commit d05d7f40791c ("Merge branch 'for-4.8/core' of
git://git.kernel.dk/linux-block") and 3fc9d690936f ("Merge branch
'for-4.8/drivers' of git://git.kernel.dk/linux-block"), blkfront_resume()
has been using an index for iterating ring_info to check request when
iterating blk_shadow in an inner loop. This seems to have been
accidentally introduced during the massive rewrite of the block layer
macros in the commits.
This may cause crash like this:
[11798.057074] BUG: unable to handle kernel NULL pointer dereference at
0048
[11798.058832] IP: [] blkfront_resume+0x10a/0x610
[11798.061063] Call Trace:
[11798.061063] [] xenbus_dev_resume+0x53/0x140
[11798.061063] [] ? xenbus_dev_probe+0x150/0x150
[11798.061063] [] dpm_run_callback+0x3e/0x110
[11798.061063] [] device_resume+0x88/0x190
[11798.061063] [] dpm_resume+0x100/0x2d0
[11798.061063] [] dpm_resume_end+0x11/0x20
[11798.061063] [] do_suspend+0xe8/0x1a0
[11798.061063] [] shutdown_handler+0xfd/0x130
[11798.061063] [] ? split+0x110/0x110
[11798.061063] [] xenwatch_thread+0x86/0x120
[11798.061063] [] ? prepare_to_wait_event+0x110/0x110
[11798.061063] [] kthread+0xd7/0xf0
[11798.061063] [] ? kfree+0x121/0x170
[11798.061063] [] ? kthread_park+0x60/0x60
[11798.061063] [] ? call_usermodehelper_exec_work+0xb0/0xb0
[11798.061063] [] ?
call_usermodehelper_exec_async+0x13a/0x140
[11798.061063] [] ret_from_fork+0x25/0x30
Use the right index in the inner loop.
Fixes: d05d7f40791c ("Merge branch 'for-4.8/core' of
git://git.kernel.dk/linux-block")
Fixes: 3fc9d690936f ("Merge branch 'for-4.8/drivers' of
git://git.kernel.dk/linux-block")
Signed-off-by: Munehisa Kamata
Reviewed-by: Thomas Friebel
Reviewed-by: Eduardo Valentin
Cc: Boris Ostrovsky
Cc: Juergen Gross
Cc: Konrad Rzeszutek Wilk
Cc: Roger Pau Monne
Cc: xen-de...@lists.xenproject.org
Cc: sta...@vger.kernel.org
Reviewed-by: Boris Ostrovsky
Re: [PATCH] xen-blkfront: use a right index when checking requests
On 08/09/2017 06:31 PM, Munehisa Kamata wrote:
Since commit d05d7f40791c ("Merge branch 'for-4.8/core' of
git://git.kernel.dk/linux-block") and 3fc9d690936f ("Merge branch
'for-4.8/drivers' of git://git.kernel.dk/linux-block"), blkfront_resume()
has been using an index for iterating ring_info to check request when
iterating blk_shadow in an inner loop. This seems to have been
accidentally introduced during the massive rewrite of the block layer
macros in the commits.
This may cause crash like this:
[11798.057074] BUG: unable to handle kernel NULL pointer dereference at
0048
[11798.058832] IP: [] blkfront_resume+0x10a/0x610
[11798.061063] Call Trace:
[11798.061063] [] xenbus_dev_resume+0x53/0x140
[11798.061063] [] ? xenbus_dev_probe+0x150/0x150
[11798.061063] [] dpm_run_callback+0x3e/0x110
[11798.061063] [] device_resume+0x88/0x190
[11798.061063] [] dpm_resume+0x100/0x2d0
[11798.061063] [] dpm_resume_end+0x11/0x20
[11798.061063] [] do_suspend+0xe8/0x1a0
[11798.061063] [] shutdown_handler+0xfd/0x130
[11798.061063] [] ? split+0x110/0x110
[11798.061063] [] xenwatch_thread+0x86/0x120
[11798.061063] [] ? prepare_to_wait_event+0x110/0x110
[11798.061063] [] kthread+0xd7/0xf0
[11798.061063] [] ? kfree+0x121/0x170
[11798.061063] [] ? kthread_park+0x60/0x60
[11798.061063] [] ? call_usermodehelper_exec_work+0xb0/0xb0
[11798.061063] [] ?
call_usermodehelper_exec_async+0x13a/0x140
[11798.061063] [] ret_from_fork+0x25/0x30
Use the right index in the inner loop.
Fixes: d05d7f40791c ("Merge branch 'for-4.8/core' of
git://git.kernel.dk/linux-block")
Fixes: 3fc9d690936f ("Merge branch 'for-4.8/drivers' of
git://git.kernel.dk/linux-block")
Signed-off-by: Munehisa Kamata
Reviewed-by: Thomas Friebel
Reviewed-by: Eduardo Valentin
Cc: Boris Ostrovsky
Cc: Juergen Gross
Cc: Konrad Rzeszutek Wilk
Cc: Roger Pau Monne
Cc: xen-de...@lists.xenproject.org
Cc: sta...@vger.kernel.org
Reviewed-by: Boris Ostrovsky
[PATCH] xen-blkfront: use a right index when checking requests
Since commit d05d7f40791c ("Merge branch 'for-4.8/core' of
git://git.kernel.dk/linux-block") and 3fc9d690936f ("Merge branch
'for-4.8/drivers' of git://git.kernel.dk/linux-block"), blkfront_resume()
has been using an index for iterating ring_info to check request when
iterating blk_shadow in an inner loop. This seems to have been
accidentally introduced during the massive rewrite of the block layer
macros in the commits.
This may cause crash like this:
[11798.057074] BUG: unable to handle kernel NULL pointer dereference at
0048
[11798.058832] IP: [] blkfront_resume+0x10a/0x610
[11798.061063] Call Trace:
[11798.061063] [] xenbus_dev_resume+0x53/0x140
[11798.061063] [] ? xenbus_dev_probe+0x150/0x150
[11798.061063] [] dpm_run_callback+0x3e/0x110
[11798.061063] [] device_resume+0x88/0x190
[11798.061063] [] dpm_resume+0x100/0x2d0
[11798.061063] [] dpm_resume_end+0x11/0x20
[11798.061063] [] do_suspend+0xe8/0x1a0
[11798.061063] [] shutdown_handler+0xfd/0x130
[11798.061063] [] ? split+0x110/0x110
[11798.061063] [] xenwatch_thread+0x86/0x120
[11798.061063] [] ? prepare_to_wait_event+0x110/0x110
[11798.061063] [] kthread+0xd7/0xf0
[11798.061063] [] ? kfree+0x121/0x170
[11798.061063] [] ? kthread_park+0x60/0x60
[11798.061063] [] ? call_usermodehelper_exec_work+0xb0/0xb0
[11798.061063] [] ?
call_usermodehelper_exec_async+0x13a/0x140
[11798.061063] [] ret_from_fork+0x25/0x30
Use the right index in the inner loop.
Fixes: d05d7f40791c ("Merge branch 'for-4.8/core' of
git://git.kernel.dk/linux-block")
Fixes: 3fc9d690936f ("Merge branch 'for-4.8/drivers' of
git://git.kernel.dk/linux-block")
Signed-off-by: Munehisa Kamata
Reviewed-by: Thomas Friebel
Reviewed-by: Eduardo Valentin
Cc: Boris Ostrovsky
Cc: Juergen Gross
Cc: Konrad Rzeszutek Wilk
Cc: Roger Pau Monne
Cc: xen-de...@lists.xenproject.org
Cc: sta...@vger.kernel.org
---
drivers/block/xen-blkfront.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 98e34e4c62b8..2468c28d4771 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -2075,9 +2075,9 @@ static int blkfront_resume(struct xenbus_device *dev)
/*
* Get the bios in the request so we can re-queue them.
*/
- if (req_op(shadow[i].request) == REQ_OP_FLUSH ||
- req_op(shadow[i].request) == REQ_OP_DISCARD ||
- req_op(shadow[i].request) == REQ_OP_SECURE_ERASE ||
+ if (req_op(shadow[j].request) == REQ_OP_FLUSH ||
+ req_op(shadow[j].request) == REQ_OP_DISCARD ||
+ req_op(shadow[j].request) == REQ_OP_SECURE_ERASE ||
shadow[j].request->cmd_flags & REQ_FUA) {
/*
* Flush operations don't contain bios, so
--
2.13.0
[PATCH] xen-blkfront: use a right index when checking requests
Since commit d05d7f40791c ("Merge branch 'for-4.8/core' of
git://git.kernel.dk/linux-block") and 3fc9d690936f ("Merge branch
'for-4.8/drivers' of git://git.kernel.dk/linux-block"), blkfront_resume()
has been using an index for iterating ring_info to check request when
iterating blk_shadow in an inner loop. This seems to have been
accidentally introduced during the massive rewrite of the block layer
macros in the commits.
This may cause crash like this:
[11798.057074] BUG: unable to handle kernel NULL pointer dereference at
0048
[11798.058832] IP: [] blkfront_resume+0x10a/0x610
[11798.061063] Call Trace:
[11798.061063] [] xenbus_dev_resume+0x53/0x140
[11798.061063] [] ? xenbus_dev_probe+0x150/0x150
[11798.061063] [] dpm_run_callback+0x3e/0x110
[11798.061063] [] device_resume+0x88/0x190
[11798.061063] [] dpm_resume+0x100/0x2d0
[11798.061063] [] dpm_resume_end+0x11/0x20
[11798.061063] [] do_suspend+0xe8/0x1a0
[11798.061063] [] shutdown_handler+0xfd/0x130
[11798.061063] [] ? split+0x110/0x110
[11798.061063] [] xenwatch_thread+0x86/0x120
[11798.061063] [] ? prepare_to_wait_event+0x110/0x110
[11798.061063] [] kthread+0xd7/0xf0
[11798.061063] [] ? kfree+0x121/0x170
[11798.061063] [] ? kthread_park+0x60/0x60
[11798.061063] [] ? call_usermodehelper_exec_work+0xb0/0xb0
[11798.061063] [] ?
call_usermodehelper_exec_async+0x13a/0x140
[11798.061063] [] ret_from_fork+0x25/0x30
Use the right index in the inner loop.
Fixes: d05d7f40791c ("Merge branch 'for-4.8/core' of
git://git.kernel.dk/linux-block")
Fixes: 3fc9d690936f ("Merge branch 'for-4.8/drivers' of
git://git.kernel.dk/linux-block")
Signed-off-by: Munehisa Kamata
Reviewed-by: Thomas Friebel
Reviewed-by: Eduardo Valentin
Cc: Boris Ostrovsky
Cc: Juergen Gross
Cc: Konrad Rzeszutek Wilk
Cc: Roger Pau Monne
Cc: xen-de...@lists.xenproject.org
Cc: sta...@vger.kernel.org
---
drivers/block/xen-blkfront.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 98e34e4c62b8..2468c28d4771 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -2075,9 +2075,9 @@ static int blkfront_resume(struct xenbus_device *dev)
/*
* Get the bios in the request so we can re-queue them.
*/
- if (req_op(shadow[i].request) == REQ_OP_FLUSH ||
- req_op(shadow[i].request) == REQ_OP_DISCARD ||
- req_op(shadow[i].request) == REQ_OP_SECURE_ERASE ||
+ if (req_op(shadow[j].request) == REQ_OP_FLUSH ||
+ req_op(shadow[j].request) == REQ_OP_DISCARD ||
+ req_op(shadow[j].request) == REQ_OP_SECURE_ERASE ||
shadow[j].request->cmd_flags & REQ_FUA) {
/*
* Flush operations don't contain bios, so
--
2.13.0
