Re: [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC.
On Wed, Jul 18, 2012 at 09:57:30AM +0300, Denis Turischev wrote:
> On 07/17/2012 07:54 AM, Sarah Sharp wrote:
> > On Mon, Jul 16, 2012 at 07:46:06PM +0300, Denis Turischev wrote:
> >> Intense-PC is Compulab's mini-desktop with Intel Panther Point
> >> chipset.
> >>
> >> Unconditional ports switching provided by function
> >> usb_enable_xhci_ports() leads to surprising results, after shutdown
> >> system powered-on again after a few seconds. On Windows power
> >> related problems were not observed.
> >
> > Do you have wake on lan enabled in the BIOS? I have heard reports from
> > other users that this is a BIOS bug triggered by WOL.
>
> Bug appears with WOL disabled too, moreover, it appears with PCH LAN
> disabled at all in the BIOS.
Hmm, ok, not the same bug then.
> > No, this fix is not acceptable. You won't get USB 3.0 speeds if the
> > ports are not switched over. Now, we can add a quirk to the xHCI
> > shutdown function to switch the ports back to EHCI on shutdown. That
> > might not trigger the BIOS bug.
>
> Yes, switching back to EHCI in xhci_shutdown() solves the problem.
Ok, good to know.
The other thing to try would be to turn off all "wake on" bits in the
port status registers in xhci_shutdown(). That might cause the xHCI
host to stop generating spurious PMEs.
It would actually be good to check that the xHCI host is the cause of
the PME that reboots the system. I'm pretty sure there's a sysfs or
proc file that shows where the PMEs are coming from, but I can't
remember where it is off the top of my head.
> I suppose to do something like this in xhci_shutdown:
> pdev = to_pci_dev(hcd->self.controller);
>
> if (usb_is_intel_switchable_xhci(pdev)){
> brd_name = dmi_get_system_info(DMI_BOARD_NAME);
>
> /* quirk for Compulab's Intense-PC board */
> if (brd_name && strstr(brd_name, "Intense-PC"))
> usb_disable_xhci_ports(pdev);
> }
>
> Is it ok?
>
> May be it worth to disable xhci ports for all intel switchable
> devices, not only for Intense-PC?
I'm not sure. I'm still talking with our hardware and BIOS team to
determine which boards have this issue. I suspect it's more than just
your board.
The only thing I wonder is if the PCI quirks will run when the xHCI
driver is reloaded. If not, the ports will never be switched back to
xHCI.
We might need to add a port switch back to xHCI in the xhci_init
function. That means if someone unloads the xHCI driver and reloads it,
their devices will appear under EHCI, and then disconnect and switch
over to xHCI.
However, I suppose that's the same as what happens if you unload the
EHCI driver on a system with an OHCI or UHCI companion controller. So I
think it should be OK to attempt to switchover the ports in xhci_init.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC.
On 07/17/2012 07:54 AM, Sarah Sharp wrote:
> On Mon, Jul 16, 2012 at 07:46:06PM +0300, Denis Turischev wrote:
>> Intense-PC is Compulab's mini-desktop with Intel Panther Point
>> chipset.
>>
>> Unconditional ports switching provided by function
>> usb_enable_xhci_ports() leads to surprising results, after shutdown
>> system powered-on again after a few seconds. On Windows power
>> related problems were not observed.
>
> Do you have wake on lan enabled in the BIOS? I have heard reports from
> other users that this is a BIOS bug triggered by WOL.
Bug appears with WOL disabled too, moreover, it appears with PCH LAN
disabled at all in the BIOS.
>
>> The patch avoids ports switching for Intense-PC.
>>
>> Signed-off-by: Denis Turischev
>> ---
>> drivers/usb/host/pci-quirks.c |7 +++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
>> index df0828c..6f72593 100644
>> --- a/drivers/usb/host/pci-quirks.c
>> +++ b/drivers/usb/host/pci-quirks.c
>> @@ -759,6 +759,13 @@ void usb_enable_xhci_ports(struct pci_dev *xhci_pdev)
>> {
>> u32 ports_available;
>>
>> +const char *brd_name;
>> +brd_name = dmi_get_system_info(DMI_BOARD_NAME);
>> +
>> +/* quirk for Compulab's Intense-PC board */
>> +if (brd_name && strstr(brd_name, "Intense-PC"))
>> +return;
>> +
>
> No, this fix is not acceptable. You won't get USB 3.0 speeds if the
> ports are not switched over. Now, we can add a quirk to the xHCI
> shutdown function to switch the ports back to EHCI on shutdown. That
> might not trigger the BIOS bug.
Yes, switching back to EHCI in xhci_shutdown() solves the problem.
I suppose to do something like this in xhci_shutdown:
pdev = to_pci_dev(hcd->self.controller);
if (usb_is_intel_switchable_xhci(pdev)){
brd_name = dmi_get_system_info(DMI_BOARD_NAME);
/* quirk for Compulab's Intense-PC board */
if (brd_name && strstr(brd_name, "Intense-PC"))
usb_disable_xhci_ports(pdev);
}
Is it ok?
May be it worth to disable xhci ports for all intel switchable
devices, not only for Intense-PC?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC.
Hello.
On 16-07-2012 20:46, Denis Turischev wrote:
Intense-PC is Compulab's mini-desktop with Intel Panther Point
chipset.
Unconditional ports switching provided by function
usb_enable_xhci_ports() leads to surprising results, after shutdown
system powered-on again after a few seconds. On Windows power
related problems were not observed.
The patch avoids ports switching for Intense-PC.
Signed-off-by: Denis Turischev
---
drivers/usb/host/pci-quirks.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index df0828c..6f72593 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -759,6 +759,13 @@ void usb_enable_xhci_ports(struct pci_dev *xhci_pdev)
{
u32 ports_available;
+ const char *brd_name;
Group this declaration with the above one please.
+ brd_name = dmi_get_system_info(DMI_BOARD_NAME);
Could be an initializer...
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC.
On Mon, Jul 16, 2012 at 07:46:06PM +0300, Denis Turischev wrote:
> Intense-PC is Compulab's mini-desktop with Intel Panther Point
> chipset.
>
> Unconditional ports switching provided by function
> usb_enable_xhci_ports() leads to surprising results, after shutdown
> system powered-on again after a few seconds. On Windows power
> related problems were not observed.
Do you have wake on lan enabled in the BIOS? I have heard reports from
other users that this is a BIOS bug triggered by WOL.
> The patch avoids ports switching for Intense-PC.
>
> Signed-off-by: Denis Turischev
> ---
> drivers/usb/host/pci-quirks.c |7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index df0828c..6f72593 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -759,6 +759,13 @@ void usb_enable_xhci_ports(struct pci_dev *xhci_pdev)
> {
> u32 ports_available;
>
> + const char *brd_name;
> + brd_name = dmi_get_system_info(DMI_BOARD_NAME);
> +
> + /* quirk for Compulab's Intense-PC board */
> + if (brd_name && strstr(brd_name, "Intense-PC"))
> + return;
> +
No, this fix is not acceptable. You won't get USB 3.0 speeds if the
ports are not switched over. Now, we can add a quirk to the xHCI
shutdown function to switch the ports back to EHCI on shutdown. That
might not trigger the BIOS bug.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] xhci: EHCI/xHCI ports switching on Intense-PC.
Intense-PC is Compulab's mini-desktop with Intel Panther Point
chipset.
Unconditional ports switching provided by function
usb_enable_xhci_ports() leads to surprising results, after shutdown
system powered-on again after a few seconds. On Windows power
related problems were not observed.
The patch avoids ports switching for Intense-PC.
Signed-off-by: Denis Turischev
---
drivers/usb/host/pci-quirks.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index df0828c..6f72593 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -759,6 +759,13 @@ void usb_enable_xhci_ports(struct pci_dev *xhci_pdev)
{
u32 ports_available;
+ const char *brd_name;
+ brd_name = dmi_get_system_info(DMI_BOARD_NAME);
+
+ /* quirk for Compulab's Intense-PC board */
+ if (brd_name && strstr(brd_name, "Intense-PC"))
+ return;
+
/* Don't switchover the ports if the user hasn't compiled the xHCI
* driver. Otherwise they will see "dead" USB ports that don't power
* the devices.
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
