Re: [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static

2019-03-22 Thread Mathieu Poirier 
On Thu, 21 Mar 2019 at 09:19, Yue Haibing  wrote:
>
> From: YueHaibing 
>
> Fix sparse warnings:
>
> drivers/hwtracing/coresight/coresight-catu.c:488:35: warning:
>  symbol 'catu_helper_ops' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-catu.c:493:28: warning:
>  symbol 'catu_ops' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing 
> ---
>  drivers/hwtracing/coresight/coresight-catu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-catu.c 
> b/drivers/hwtracing/coresight/coresight-catu.c
> index 170fbb6..057627a 100644
> --- a/drivers/hwtracing/coresight/coresight-catu.c
> +++ b/drivers/hwtracing/coresight/coresight-catu.c
> @@ -485,12 +485,12 @@ static int catu_disable(struct coresight_device *csdev, 
> void *__unused)
> return rc;
>  }
>
> -const struct coresight_ops_helper catu_helper_ops = {
> +static const struct coresight_ops_helper catu_helper_ops = {
> .enable = catu_enable,
> .disable = catu_disable,
>  };
>
> -const struct coresight_ops catu_ops = {
> +static const struct coresight_ops catu_ops = {
> .helper_ops = _helper_ops,
>  };
>

Applied thanks.
Mathieu

> --
> 2.7.0
>
>

Re: [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static

2019-03-22 Thread Suzuki K Poulose 

On 03/21/2019 03:18 PM, Yue Haibing wrote:

From: YueHaibing 

Fix sparse warnings:

drivers/hwtracing/coresight/coresight-catu.c:488:35: warning:
  symbol 'catu_helper_ops' was not declared. Should it be static?
drivers/hwtracing/coresight/coresight-catu.c:493:28: warning:
  symbol 'catu_ops' was not declared. Should it be static?

Signed-off-by: YueHaibing 
---
  drivers/hwtracing/coresight/coresight-catu.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-catu.c 
b/drivers/hwtracing/coresight/coresight-catu.c
index 170fbb6..057627a 100644
--- a/drivers/hwtracing/coresight/coresight-catu.c
+++ b/drivers/hwtracing/coresight/coresight-catu.c
@@ -485,12 +485,12 @@ static int catu_disable(struct coresight_device *csdev, 
void *__unused)
return rc;
  }
  
-const struct coresight_ops_helper catu_helper_ops = {

+static const struct coresight_ops_helper catu_helper_ops = {
.enable = catu_enable,
.disable = catu_disable,
  };
  
-const struct coresight_ops catu_ops = {

+static const struct coresight_ops catu_ops = {
.helper_ops = _helper_ops,
  };
  



Reviewed-by: Suzuki K Poulose

[PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static

2019-03-21 Thread Yue Haibing 
From: YueHaibing 

Fix sparse warnings:

drivers/hwtracing/coresight/coresight-catu.c:488:35: warning:
 symbol 'catu_helper_ops' was not declared. Should it be static?
drivers/hwtracing/coresight/coresight-catu.c:493:28: warning:
 symbol 'catu_ops' was not declared. Should it be static?

Signed-off-by: YueHaibing 
---
 drivers/hwtracing/coresight/coresight-catu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-catu.c 
b/drivers/hwtracing/coresight/coresight-catu.c
index 170fbb6..057627a 100644
--- a/drivers/hwtracing/coresight/coresight-catu.c
+++ b/drivers/hwtracing/coresight/coresight-catu.c
@@ -485,12 +485,12 @@ static int catu_disable(struct coresight_device *csdev, 
void *__unused)
return rc;
 }
 
-const struct coresight_ops_helper catu_helper_ops = {
+static const struct coresight_ops_helper catu_helper_ops = {
.enable = catu_enable,
.disable = catu_disable,
 };
 
-const struct coresight_ops catu_ops = {
+static const struct coresight_ops catu_ops = {
.helper_ops = _helper_ops,
 };
 
-- 
2.7.0