Re: [PATCH -next] hinic: Use kmemdup instead of kzalloc and memcpy

[David Miller]

From: Zou Wei 
Date: Wed, 29 Apr 2020 11:35:28 +0800

> Fixes coccicheck warnings:
> 
>  drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:452:17-24: WARNING 
> opportunity for kmemdup
>  drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:458:23-30: WARNING 
> opportunity for kmemdup
> 
> Reported-by: Hulk Robot 
> Signed-off-by: Zou Wei 

Applied.

[PATCH -next] hinic: Use kmemdup instead of kzalloc and memcpy

[Zou Wei]

Fixes coccicheck warnings:

 drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:452:17-24: WARNING 
opportunity for kmemdup
 drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:458:23-30: WARNING 
opportunity for kmemdup

Reported-by: Hulk Robot 
Signed-off-by: Zou Wei 
---
 drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c | 9 +++--
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c 
b/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c
index f8626df..a39cc16 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c
@@ -449,18 +449,15 @@ static void recv_mbox_handler(struct 
hinic_mbox_func_to_func *func_to_func,
return;
}
 
-   rcv_mbox_temp = kzalloc(sizeof(*rcv_mbox_temp), GFP_KERNEL);
+   rcv_mbox_temp = kmemdup(recv_mbox, sizeof(*rcv_mbox_temp), GFP_KERNEL);
if (!rcv_mbox_temp)
return;
 
-   memcpy(rcv_mbox_temp, recv_mbox, sizeof(*rcv_mbox_temp));
-
-   rcv_mbox_temp->mbox = kzalloc(MBOX_MAX_BUF_SZ, GFP_KERNEL);
+   rcv_mbox_temp->mbox = kmemdup(recv_mbox->mbox, MBOX_MAX_BUF_SZ,
+ GFP_KERNEL);
if (!rcv_mbox_temp->mbox)
goto err_alloc_rcv_mbox_msg;
 
-   memcpy(rcv_mbox_temp->mbox, recv_mbox->mbox, MBOX_MAX_BUF_SZ);
-
rcv_mbox_temp->buf_out = kzalloc(MBOX_MAX_BUF_SZ, GFP_KERNEL);
if (!rcv_mbox_temp->buf_out)
goto err_alloc_rcv_mbox_buf;
-- 
2.6.2