Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static

2019-03-20 Thread Mukesh Ojha 



On 3/20/2019 7:52 PM, Yue Haibing wrote:

From: YueHaibing 

Fix sparse warnings:

drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
  symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
  symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?

Signed-off-by: YueHaibing 
---
  drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
index 83364fe..5e4ca13 100644
--- a/drivers/irqchip/irq-brcmstb-l2.c
+++ b/drivers/irqchip/irq-brcmstb-l2.c
@@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct 
device_node *np,
return ret;
  }
  
-int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,

+static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
struct device_node *parent)
  {
return brcmstb_l2_intc_of_init(np, parent, _edge_intc_init);
  }
  IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", 
brcmstb_l2_edge_intc_of_init);
  
-int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,

+static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
struct device_node *parent)
  {
return



Acked-by: Mukesh Ojha 


Thanks,
Mukesh


  brcmstb_l2_intc_of_init(np, parent, _lvl_intc_init);

Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static

2019-03-20 Thread Mukesh Ojha 



On 3/20/2019 7:52 PM, Yue Haibing wrote:

From: YueHaibing 

Fix sparse warnings:

drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
  symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
  symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?

Signed-off-by: YueHaibing 
---
  drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
index 83364fe..5e4ca13 100644
--- a/drivers/irqchip/irq-brcmstb-l2.c
+++ b/drivers/irqchip/irq-brcmstb-l2.c
@@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct 
device_node *np,
return ret;
  }
  
-int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,

+static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
struct device_node *parent)
  {
return brcmstb_l2_intc_of_init(np, parent, _edge_intc_init);
  }
  IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", 
brcmstb_l2_edge_intc_of_init);
  
-int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,

+static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
struct device_node *parent)
  {
return brcmstb_l2_intc_of_init(np, parent, _lvl_intc_init);



Reviewed-by: Mukesh Ojha 


Thanks,
Mukesh

Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static

2019-03-20 Thread Florian Fainelli 
On 3/20/19 7:22 AM, Yue Haibing wrote:
> From: YueHaibing 
> 
> Fix sparse warnings:
> 
> drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
>  symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
> drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
>  symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing 

Reviewed-by: Florian Fainelli 
-- 
Florian

[PATCH -next] irqchip/brcmstb-l2: Make two init functions static

2019-03-20 Thread Yue Haibing 
From: YueHaibing 

Fix sparse warnings:

drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
 symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
 symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?

Signed-off-by: YueHaibing 
---
 drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
index 83364fe..5e4ca13 100644
--- a/drivers/irqchip/irq-brcmstb-l2.c
+++ b/drivers/irqchip/irq-brcmstb-l2.c
@@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct 
device_node *np,
return ret;
 }
 
-int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
+static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
struct device_node *parent)
 {
return brcmstb_l2_intc_of_init(np, parent, _edge_intc_init);
 }
 IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", brcmstb_l2_edge_intc_of_init);
 
-int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
+static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
struct device_node *parent)
 {
return brcmstb_l2_intc_of_init(np, parent, _lvl_intc_init);
-- 
2.7.0