Re: [PATCH -next] nfsd: remove set but not used variable 'len'

[J. Bruce Fields]

Thanks, applying for 5.5.--b.

On Sat, Sep 28, 2019 at 12:21:56PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> fs/nfsd/nfs4xdr.c: In function nfsd4_encode_splice_read:
> fs/nfsd/nfs4xdr.c:3464:7: warning: variable len set but not used 
> [-Wunused-but-set-variable]
> 
> It is not used since commit 83a63072c815 ("nfsd: fix nfs read eof detection")
> 
> Reported-by: Hulk Robot 
> Signed-off-by: YueHaibing 
> ---
>  fs/nfsd/nfs4xdr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 533d0fc..1883370 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -3461,7 +3461,6 @@ static __be32 nfsd4_encode_splice_read(
>   struct xdr_stream *xdr = &resp->xdr;
>   struct xdr_buf *buf = xdr->buf;
>   u32 eof;
> - long len;
>   int space_left;
>   __be32 nfserr;
>   __be32 *p = xdr->p - 2;
> @@ -3470,7 +3469,6 @@ static __be32 nfsd4_encode_splice_read(
>   if (xdr->end - xdr->p < 1)
>   return nfserr_resource;
>  
> - len = maxcount;
>   nfserr = nfsd_splice_read(read->rd_rqstp, read->rd_fhp,
> file, read->rd_offset, &maxcount, &eof);
>   read->rd_length = maxcount;
> -- 
> 2.7.4
> 

[PATCH -next] nfsd: remove set but not used variable 'len'

[YueHaibing]

Fixes gcc '-Wunused-but-set-variable' warning:

fs/nfsd/nfs4xdr.c: In function nfsd4_encode_splice_read:
fs/nfsd/nfs4xdr.c:3464:7: warning: variable len set but not used 
[-Wunused-but-set-variable]

It is not used since commit 83a63072c815 ("nfsd: fix nfs read eof detection")

Reported-by: Hulk Robot 
Signed-off-by: YueHaibing 
---
 fs/nfsd/nfs4xdr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 533d0fc..1883370 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -3461,7 +3461,6 @@ static __be32 nfsd4_encode_splice_read(
struct xdr_stream *xdr = &resp->xdr;
struct xdr_buf *buf = xdr->buf;
u32 eof;
-   long len;
int space_left;
__be32 nfserr;
__be32 *p = xdr->p - 2;
@@ -3470,7 +3469,6 @@ static __be32 nfsd4_encode_splice_read(
if (xdr->end - xdr->p < 1)
return nfserr_resource;
 
-   len = maxcount;
nfserr = nfsd_splice_read(read->rd_rqstp, read->rd_fhp,
  file, read->rd_offset, &maxcount, &eof);
read->rd_length = maxcount;
-- 
2.7.4