Re: [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

[Martin K. Petersen]

YueHaibing,

> The return code should be check while qla4xxx_copy_from_fwddb_param
> fails.

Applied to 4.21/scsi-fixes, thank you.

-- 
Martin K. Petersen  Oracle Linux Engineering

RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

[Manish Rangankar]

> -Original Message-
> From: YueHaibing 
> Sent: Thursday, December 20, 2018 8:46 AM
> To: qlogic-storage-upstr...@qlogic.com; j...@linux.ibm.com;
> martin.peter...@oracle.com
> Cc: linux-kernel@vger.kernel.org; linux-s...@vger.kernel.org; YueHaibing
> 
> Subject: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
> qla4xxx_copy_from_fwddb_param
> 
> External Email
> 
> --
> External Email
> 
> The return code should be check while qla4xxx_copy_from_fwddb_param fails.
> 
> Signed-off-by: YueHaibing 
> ---
>  drivers/scsi/qla4xxx/ql4_os.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c 
> index
> 949e186..1bc4db6 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct
> scsi_qla_host *ha,
> 
> rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
>fw_ddb_entry);
> +   if (rc)
> +   goto free_sess;
> 
> ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
>__func__, fnode_sess->dev.kobj.name);
> --
> 2.7.0
> 

Thanks
Acked-by: Manish Rangankar 

[PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

[YueHaibing]

The return code should be check while qla4xxx_copy_from_fwddb_param
fails.

Signed-off-by: YueHaibing 
---
 drivers/scsi/qla4xxx/ql4_os.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 949e186..1bc4db6 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct 
scsi_qla_host *ha,
 
rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
   fw_ddb_entry);
+   if (rc)
+   goto free_sess;
 
ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
   __func__, fnode_sess->dev.kobj.name);
-- 
2.7.0