Re: [PATCH -next] staging: spmi: hisi-spmi-controller: Use proper format in call to dev_err()

[Mauro Carvalho Chehab]

Em Tue, 1 Sep 2020 11:57:22 +0800
YueHaibing  escreveu:

> The correct format string for a size_t argument should be %zu.
> 
> Signed-off-by: YueHaibing 

Reviewed-by: Mauro Carvalho Chehab 

> ---
>  drivers/staging/hikey9xx/hisi-spmi-controller.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c 
> b/drivers/staging/hikey9xx/hisi-spmi-controller.c
> index 66a0b296e06f..34c690da09e3 100644
> --- a/drivers/staging/hikey9xx/hisi-spmi-controller.c
> +++ b/drivers/staging/hikey9xx/hisi-spmi-controller.c
> @@ -121,7 +121,7 @@ static int spmi_read_cmd(struct spmi_controller *ctrl,
>  
>   if (bc > SPMI_CONTROLLER_MAX_TRANS_BYTES) {
>   dev_err(&ctrl->dev,
> - "spmi_controller supports 1..%d bytes per trans, 
> but:%ld requested\n",
> + "spmi_controller supports 1..%d bytes per trans, 
> but:%zu requested\n",
>   SPMI_CONTROLLER_MAX_TRANS_BYTES, bc);
>   return  -EINVAL;
>   }
> @@ -175,7 +175,7 @@ static int spmi_read_cmd(struct spmi_controller *ctrl,
>   spin_unlock_irqrestore(&spmi_controller->lock, flags);
>   if (rc)
>   dev_err(&ctrl->dev,
> - "spmi read wait timeout op:0x%x slave_id:%d 
> slave_addr:0x%x bc:%ld\n",
> + "spmi read wait timeout op:0x%x slave_id:%d 
> slave_addr:0x%x bc:%zu\n",
>   opc, slave_id, slave_addr, bc + 1);
>   else
>   dev_dbg(&ctrl->dev, "%s: id:%d slave_addr:0x%x, read value: 
> %*ph\n",
> @@ -197,7 +197,7 @@ static int spmi_write_cmd(struct spmi_controller *ctrl,
>  
>   if (bc > SPMI_CONTROLLER_MAX_TRANS_BYTES) {
>   dev_err(&ctrl->dev,
> - "spmi_controller supports 1..%d bytes per trans, 
> but:%ld requested\n",
> + "spmi_controller supports 1..%d bytes per trans, 
> but:%zu requested\n",
>   SPMI_CONTROLLER_MAX_TRANS_BYTES, bc);
>   return  -EINVAL;
>   }
> @@ -251,7 +251,7 @@ static int spmi_write_cmd(struct spmi_controller *ctrl,
>   spin_unlock_irqrestore(&spmi_controller->lock, flags);
>  
>   if (rc)
> - dev_err(&ctrl->dev, "spmi write wait timeout op:0x%x 
> slave_id:%d slave_addr:0x%x bc:%ld\n",
> + dev_err(&ctrl->dev, "spmi write wait timeout op:0x%x 
> slave_id:%d slave_addr:0x%x bc:%zu\n",
>   opc, slave_id, slave_addr, bc);
>   else
>   dev_dbg(&ctrl->dev, "%s: id:%d slave_addr:0x%x, wrote value: 
> %*ph\n",



Thanks,
Mauro

[PATCH -next] staging: spmi: hisi-spmi-controller: Use proper format in call to dev_err()

[YueHaibing]

The correct format string for a size_t argument should be %zu.

Signed-off-by: YueHaibing 
---
 drivers/staging/hikey9xx/hisi-spmi-controller.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c 
b/drivers/staging/hikey9xx/hisi-spmi-controller.c
index 66a0b296e06f..34c690da09e3 100644
--- a/drivers/staging/hikey9xx/hisi-spmi-controller.c
+++ b/drivers/staging/hikey9xx/hisi-spmi-controller.c
@@ -121,7 +121,7 @@ static int spmi_read_cmd(struct spmi_controller *ctrl,
 
if (bc > SPMI_CONTROLLER_MAX_TRANS_BYTES) {
dev_err(&ctrl->dev,
-   "spmi_controller supports 1..%d bytes per trans, 
but:%ld requested\n",
+   "spmi_controller supports 1..%d bytes per trans, 
but:%zu requested\n",
SPMI_CONTROLLER_MAX_TRANS_BYTES, bc);
return  -EINVAL;
}
@@ -175,7 +175,7 @@ static int spmi_read_cmd(struct spmi_controller *ctrl,
spin_unlock_irqrestore(&spmi_controller->lock, flags);
if (rc)
dev_err(&ctrl->dev,
-   "spmi read wait timeout op:0x%x slave_id:%d 
slave_addr:0x%x bc:%ld\n",
+   "spmi read wait timeout op:0x%x slave_id:%d 
slave_addr:0x%x bc:%zu\n",
opc, slave_id, slave_addr, bc + 1);
else
dev_dbg(&ctrl->dev, "%s: id:%d slave_addr:0x%x, read value: 
%*ph\n",
@@ -197,7 +197,7 @@ static int spmi_write_cmd(struct spmi_controller *ctrl,
 
if (bc > SPMI_CONTROLLER_MAX_TRANS_BYTES) {
dev_err(&ctrl->dev,
-   "spmi_controller supports 1..%d bytes per trans, 
but:%ld requested\n",
+   "spmi_controller supports 1..%d bytes per trans, 
but:%zu requested\n",
SPMI_CONTROLLER_MAX_TRANS_BYTES, bc);
return  -EINVAL;
}
@@ -251,7 +251,7 @@ static int spmi_write_cmd(struct spmi_controller *ctrl,
spin_unlock_irqrestore(&spmi_controller->lock, flags);
 
if (rc)
-   dev_err(&ctrl->dev, "spmi write wait timeout op:0x%x 
slave_id:%d slave_addr:0x%x bc:%ld\n",
+   dev_err(&ctrl->dev, "spmi write wait timeout op:0x%x 
slave_id:%d slave_addr:0x%x bc:%zu\n",
opc, slave_id, slave_addr, bc);
else
dev_dbg(&ctrl->dev, "%s: id:%d slave_addr:0x%x, wrote value: 
%*ph\n",
-- 
2.17.1