Re: [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()

[Andrew Lunn]

On Sat, Mar 10, 2018 at 07:22:55PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 10 Mar 2018 19:05:45 +0100
> 
> Two update suggestions were taken into account
> from static source code analysis.

Hi Markus

How about re-writing this driver to use phylib. The whole of
ax88179_chk_eee() would then go away, since it is a duplication of
phy_init_eee().

Andrew

Re: [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()

[Andrew Lunn]

On Sat, Mar 10, 2018 at 07:22:55PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 10 Mar 2018 19:05:45 +0100
> 
> Two update suggestions were taken into account
> from static source code analysis.

Hi Markus

How about re-writing this driver to use phylib. The whole of
ax88179_chk_eee() would then go away, since it is a duplication of
phy_init_eee().

Andrew

[PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sat, 10 Mar 2018 19:05:45 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Use common code
  Delete three unnecessary variables

 drivers/net/usb/ax88179_178a.c | 45 +++---
 1 file changed, 16 insertions(+), 29 deletions(-)

-- 
2.16.2

[PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sat, 10 Mar 2018 19:05:45 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Use common code
  Delete three unnecessary variables

 drivers/net/usb/ax88179_178a.c | 45 +++---
 1 file changed, 16 insertions(+), 29 deletions(-)

-- 
2.16.2