Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Tony Lindgren]

* Roger Quadros  [160803 02:56]:
> On 03/08/16 11:01, Johan Hovold wrote:
> > On Wed, Aug 03, 2016 at 10:46:24AM +0300, Roger Quadros wrote:
> >> On 02/08/16 13:35, Tony Lindgren wrote:
> >>> * Johan Hovold  [160724 05:11]:
>  Networking is currently broken for Overo boards due to a regression in
>  4.7. I bisected it down to
> 
>   d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
>   for WAITPINs")
> >>> ...
> >>>
>  Note that simply fixing the Overo NAND issue would fix the Overo
>  networking regression, but by restoring the 4.6 gpmc-probe behaviour
>  similar regressions on other OMAP systems are also avoided.
> >>>
> >>> Roger, got a better fix in mind?
> >>>
> >>
> >> Nope. I'll take patch 1 in my omap-gpmc queue for v4.8.
> >> Thanks for the fixes Johan.
> > 
> > Now that 4.7 has been released, you may want to consider adding a stable
> > tag also for the first patch to avoid similar issues on other systems
> > when they get updated to 4.7-stable.
> > 
> 
> Yes, that was my plan as well.

OK and I'm now finally applying the dts fixes into omap-for-v4.8/fixes.
Sorry for the delay.

Tony

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Tony Lindgren]

* Roger Quadros  [160803 02:56]:
> On 03/08/16 11:01, Johan Hovold wrote:
> > On Wed, Aug 03, 2016 at 10:46:24AM +0300, Roger Quadros wrote:
> >> On 02/08/16 13:35, Tony Lindgren wrote:
> >>> * Johan Hovold  [160724 05:11]:
>  Networking is currently broken for Overo boards due to a regression in
>  4.7. I bisected it down to
> 
>   d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
>   for WAITPINs")
> >>> ...
> >>>
>  Note that simply fixing the Overo NAND issue would fix the Overo
>  networking regression, but by restoring the 4.6 gpmc-probe behaviour
>  similar regressions on other OMAP systems are also avoided.
> >>>
> >>> Roger, got a better fix in mind?
> >>>
> >>
> >> Nope. I'll take patch 1 in my omap-gpmc queue for v4.8.
> >> Thanks for the fixes Johan.
> > 
> > Now that 4.7 has been released, you may want to consider adding a stable
> > tag also for the first patch to avoid similar issues on other systems
> > when they get updated to 4.7-stable.
> > 
> 
> Yes, that was my plan as well.

OK and I'm now finally applying the dts fixes into omap-for-v4.8/fixes.
Sorry for the delay.

Tony

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Johan Hovold]

On Wed, Aug 03, 2016 at 10:46:24AM +0300, Roger Quadros wrote:
> On 02/08/16 13:35, Tony Lindgren wrote:
> > * Johan Hovold  [160724 05:11]:
> >> Networking is currently broken for Overo boards due to a regression in
> >> 4.7. I bisected it down to
> >>
> >>d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
> >>for WAITPINs")
> > ...
> > 
> >> Note that simply fixing the Overo NAND issue would fix the Overo
> >> networking regression, but by restoring the 4.6 gpmc-probe behaviour
> >> similar regressions on other OMAP systems are also avoided.
> > 
> > Roger, got a better fix in mind?
> > 
> 
> Nope. I'll take patch 1 in my omap-gpmc queue for v4.8.
> Thanks for the fixes Johan.

Now that 4.7 has been released, you may want to consider adding a stable
tag also for the first patch to avoid similar issues on other systems
when they get updated to 4.7-stable.

Thanks,
Johan

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Johan Hovold]

On Wed, Aug 03, 2016 at 10:46:24AM +0300, Roger Quadros wrote:
> On 02/08/16 13:35, Tony Lindgren wrote:
> > * Johan Hovold  [160724 05:11]:
> >> Networking is currently broken for Overo boards due to a regression in
> >> 4.7. I bisected it down to
> >>
> >>d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
> >>for WAITPINs")
> > ...
> > 
> >> Note that simply fixing the Overo NAND issue would fix the Overo
> >> networking regression, but by restoring the 4.6 gpmc-probe behaviour
> >> similar regressions on other OMAP systems are also avoided.
> > 
> > Roger, got a better fix in mind?
> > 
> 
> Nope. I'll take patch 1 in my omap-gpmc queue for v4.8.
> Thanks for the fixes Johan.

Now that 4.7 has been released, you may want to consider adding a stable
tag also for the first patch to avoid similar issues on other systems
when they get updated to 4.7-stable.

Thanks,
Johan

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Roger Quadros]

On 03/08/16 11:01, Johan Hovold wrote:
> On Wed, Aug 03, 2016 at 10:46:24AM +0300, Roger Quadros wrote:
>> On 02/08/16 13:35, Tony Lindgren wrote:
>>> * Johan Hovold  [160724 05:11]:
 Networking is currently broken for Overo boards due to a regression in
 4.7. I bisected it down to

d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
for WAITPINs")
>>> ...
>>>
 Note that simply fixing the Overo NAND issue would fix the Overo
 networking regression, but by restoring the 4.6 gpmc-probe behaviour
 similar regressions on other OMAP systems are also avoided.
>>>
>>> Roger, got a better fix in mind?
>>>
>>
>> Nope. I'll take patch 1 in my omap-gpmc queue for v4.8.
>> Thanks for the fixes Johan.
> 
> Now that 4.7 has been released, you may want to consider adding a stable
> tag also for the first patch to avoid similar issues on other systems
> when they get updated to 4.7-stable.
> 

Yes, that was my plan as well.

cheers,
-roger

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Roger Quadros]

On 03/08/16 11:01, Johan Hovold wrote:
> On Wed, Aug 03, 2016 at 10:46:24AM +0300, Roger Quadros wrote:
>> On 02/08/16 13:35, Tony Lindgren wrote:
>>> * Johan Hovold  [160724 05:11]:
 Networking is currently broken for Overo boards due to a regression in
 4.7. I bisected it down to

d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
for WAITPINs")
>>> ...
>>>
 Note that simply fixing the Overo NAND issue would fix the Overo
 networking regression, but by restoring the 4.6 gpmc-probe behaviour
 similar regressions on other OMAP systems are also avoided.
>>>
>>> Roger, got a better fix in mind?
>>>
>>
>> Nope. I'll take patch 1 in my omap-gpmc queue for v4.8.
>> Thanks for the fixes Johan.
> 
> Now that 4.7 has been released, you may want to consider adding a stable
> tag also for the first patch to avoid similar issues on other systems
> when they get updated to 4.7-stable.
> 

Yes, that was my plan as well.

cheers,
-roger

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Roger Quadros]

On 02/08/16 13:35, Tony Lindgren wrote:
> * Johan Hovold  [160724 05:11]:
>> Networking is currently broken for Overo boards due to a regression in
>> 4.7. I bisected it down to
>>
>>  d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
>>  for WAITPINs")
> ...
> 
>> Note that simply fixing the Overo NAND issue would fix the Overo
>> networking regression, but by restoring the 4.6 gpmc-probe behaviour
>> similar regressions on other OMAP systems are also avoided.
> 
> Roger, got a better fix in mind?
> 

Nope. I'll take patch 1 in my omap-gpmc queue for v4.8.
Thanks for the fixes Johan.

cheers,
-roger

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Roger Quadros]

On 02/08/16 13:35, Tony Lindgren wrote:
> * Johan Hovold  [160724 05:11]:
>> Networking is currently broken for Overo boards due to a regression in
>> 4.7. I bisected it down to
>>
>>  d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
>>  for WAITPINs")
> ...
> 
>> Note that simply fixing the Overo NAND issue would fix the Overo
>> networking regression, but by restoring the 4.6 gpmc-probe behaviour
>> similar regressions on other OMAP systems are also avoided.
> 
> Roger, got a better fix in mind?
> 

Nope. I'll take patch 1 in my omap-gpmc queue for v4.8.
Thanks for the fixes Johan.

cheers,
-roger

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Tony Lindgren]

* Johan Hovold  [160724 05:11]:
> Networking is currently broken for Overo boards due to a regression in
> 4.7. I bisected it down to
> 
>   d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
>   for WAITPINs")
...

> Note that simply fixing the Overo NAND issue would fix the Overo
> networking regression, but by restoring the 4.6 gpmc-probe behaviour
> similar regressions on other OMAP systems are also avoided.

Roger, got a better fix in mind?

Regards,

Tony

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Tony Lindgren]

* Johan Hovold  [160724 05:11]:
> Networking is currently broken for Overo boards due to a regression in
> 4.7. I bisected it down to
> 
>   d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
>   for WAITPINs")
...

> Note that simply fixing the Overo NAND issue would fix the Overo
> networking regression, but by restoring the 4.6 gpmc-probe behaviour
> similar regressions on other OMAP systems are also avoided.

Roger, got a better fix in mind?

Regards,

Tony

[PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Johan Hovold]

Networking is currently broken for Overo boards due to a regression in
4.7. I bisected it down to

d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
for WAITPINs")

which changed how errors when probing gpmc child nodes are handled.
Instead of proceeding with setting up any other children as before, a
single error now aborts the whole process.

Due to an unrelated issue with a nand gpmc-node, this change broke
networking for Overo Tobi and other Overo boards with gpmc ethernet:

[0.823364] omap-gpmc 6e00.gpmc: GPMC revision 5.0
[0.823822] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x100
[0.823974] gpiochip_find_base: found new base at 508
[0.824096] gpio gpiochip6: (omap-gpmc): added GPIO chardev (254:6)
[0.827148] gpiochip_setup_dev: registered GPIOs 508 to 511 on device: 
gpiochip6 (omap-gpmc)
[0.827362] omap-gpmc 6e00.gpmc: /ocp/gpmc@6e00/nand@0,0 has 
malformed 'reg' property
[0.827392] omap-gpmc 6e00.gpmc: failed to probe DT children

This series restores the 4.6 behaviour of allowing probe of gpmc child
nodes to fail, and also fixes the problems with the Overo nand node.

Note that simply fixing the Overo NAND issue would fix the Overo
networking regression, but by restoring the 4.6 gpmc-probe behaviour
similar regressions on other OMAP systems are also avoided.

Johan


Johan Hovold (3):
  memory: omap-gpmc: allow probe of child nodes to fail
  ARM: dts: overo: fix gpmc nand cs0 range
  ARM: dts: overo: fix gpmc nand on boards with ethernet

 arch/arm/boot/dts/omap3-overo-base.dtsi |  4 +++-
 .../arm/boot/dts/omap3-overo-chestnut43-common.dtsi |  2 --
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi  |  2 --
 arch/arm/boot/dts/omap3-overo-tobiduo-common.dtsi   |  3 ---
 drivers/memory/omap-gpmc.c  | 21 +++--
 5 files changed, 10 insertions(+), 22 deletions(-)

-- 
2.7.3

[PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

[Johan Hovold]

Networking is currently broken for Overo boards due to a regression in
4.7. I bisected it down to

d2d00862dfbb ("memory: omap-gpmc: Support general purpose input
for WAITPINs")

which changed how errors when probing gpmc child nodes are handled.
Instead of proceeding with setting up any other children as before, a
single error now aborts the whole process.

Due to an unrelated issue with a nand gpmc-node, this change broke
networking for Overo Tobi and other Overo boards with gpmc ethernet:

[0.823364] omap-gpmc 6e00.gpmc: GPMC revision 5.0
[0.823822] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x100
[0.823974] gpiochip_find_base: found new base at 508
[0.824096] gpio gpiochip6: (omap-gpmc): added GPIO chardev (254:6)
[0.827148] gpiochip_setup_dev: registered GPIOs 508 to 511 on device: 
gpiochip6 (omap-gpmc)
[0.827362] omap-gpmc 6e00.gpmc: /ocp/gpmc@6e00/nand@0,0 has 
malformed 'reg' property
[0.827392] omap-gpmc 6e00.gpmc: failed to probe DT children

This series restores the 4.6 behaviour of allowing probe of gpmc child
nodes to fail, and also fixes the problems with the Overo nand node.

Note that simply fixing the Overo NAND issue would fix the Overo
networking regression, but by restoring the 4.6 gpmc-probe behaviour
similar regressions on other OMAP systems are also avoided.

Johan


Johan Hovold (3):
  memory: omap-gpmc: allow probe of child nodes to fail
  ARM: dts: overo: fix gpmc nand cs0 range
  ARM: dts: overo: fix gpmc nand on boards with ethernet

 arch/arm/boot/dts/omap3-overo-base.dtsi |  4 +++-
 .../arm/boot/dts/omap3-overo-chestnut43-common.dtsi |  2 --
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi  |  2 --
 arch/arm/boot/dts/omap3-overo-tobiduo-common.dtsi   |  3 ---
 drivers/memory/omap-gpmc.c  | 21 +++--
 5 files changed, 10 insertions(+), 22 deletions(-)

-- 
2.7.3