Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor (resend)
On 11/05/2015 05:34 PM, Rafael J. Wysocki wrote: > On Tuesday, November 03, 2015 05:34:16 PM r...@redhat.com wrote: >> While working on a paravirt cpuidle driver for KVM guests, I >> noticed a number of small logic errors in the menu governor >> code. >> >> These patches should get rid of some artifacts that can break >> the logic in the menu governor under certain corner cases, and >> make idle state selection work better on CPUs with long C1 exit >> latencies. >> >> I have not seen any adverse effects with them in my (quick) >> tests. As expected, they do not seem to do much on systems with >> many power states and very low C1 exit latencies and target residencies. > > Thanks! > > The patches look good to me. > > I might apply [1-2/3] right away, but I'm a bit hesitant about the [3/3] (I'd > like it to spend some time in linux-next before it goes to Linus). Also, > we've > lived without these changes for quite some time and I don't want to stretch > the > process too much, so I'll queue them up for v4.5 if that's not a problem. Not a problem at all. I am all for taking these changes carefully, and seeing what happens. I did some basic testing with it, but the permutations of what can happen with cpuidle management are just too many to predict in advance everything that could happen. -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor (resend)
On Tuesday, November 03, 2015 05:34:16 PM r...@redhat.com wrote: > While working on a paravirt cpuidle driver for KVM guests, I > noticed a number of small logic errors in the menu governor > code. > > These patches should get rid of some artifacts that can break > the logic in the menu governor under certain corner cases, and > make idle state selection work better on CPUs with long C1 exit > latencies. > > I have not seen any adverse effects with them in my (quick) > tests. As expected, they do not seem to do much on systems with > many power states and very low C1 exit latencies and target residencies. Thanks! The patches look good to me. I might apply [1-2/3] right away, but I'm a bit hesitant about the [3/3] (I'd like it to spend some time in linux-next before it goes to Linus). Also, we've lived without these changes for quite some time and I don't want to stretch the process too much, so I'll queue them up for v4.5 if that's not a problem. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor
On Wed, 2015-11-04 at 15:02 +0100, Rafael J. Wysocki wrote: > On 11/4/2015 7:56 AM, Joe Perches wrote: > > On Wed, 2015-11-04 at 00:03 +0100, Rafael J. Wysocki wrote: > > > On 11/3/2015 11:35 PM, Rik van Riel wrote: > > > > On 11/03/2015 05:05 PM, Rafael J. Wysocki wrote: > > > > > On 10/28/2015 11:46 PM, r...@redhat.com wrote: [] > > > > > Sorry for the trouble, but can you please resend the series > > > > > with > > > > > CCs to > > > > > linux...@vger.kernel.org? That will make it way easier to > > > > > handle > > > > > for me. > > > > Not a problem. Done. > > > > > > > > What change do I need to send in to ensure that the > > > > linux-pm mailing list shows up in get_maintainer.pl output? [] > > > I'm not sure why it doesn't show up in there. [] > > > If you look at MAINTAINERS under CPUIDLE DRIVERS, linux-pm is > > > actually listed there. > > Because the pattern is just the files in the top level directory > > of drivers/cpuidle and not any files in any directory below > Care to send this patch with a proper changelog/sign-off? Sending patches with my current version of the evolution email client (3.16.5) is a bit troublesome. I'm going to either upgrade to 3.19, downgrade back to 3.12 or change clients altogether. Can you do it instead please? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor
On 11/4/2015 7:56 AM, Joe Perches wrote: On Wed, 2015-11-04 at 00:03 +0100, Rafael J. Wysocki wrote: On 11/3/2015 11:35 PM, Rik van Riel wrote: On 11/03/2015 05:05 PM, Rafael J. Wysocki wrote: On 10/28/2015 11:46 PM, r...@redhat.com wrote: While working on a paravirt cpuidle driver for KVM guests, I noticed a number of small logic errors in the menu governor code. These patches should get rid of some artifacts that can break the logic in the menu governor under certain corner cases, and make idle state selection work better on CPUs with long C1 exit latencies. I have not seen any adverse effects with them in my (quick) tests. As expected, they do not seem to do much on systems with many power states and very low C1 exit latencies and target residencies. Sorry for the trouble, but can you please resend the series with CCs to linux...@vger.kernel.org? That will make it way easier to handle for me. Not a problem. Done. What change do I need to send in to ensure that the linux-pm mailing list shows up in get_maintainer.pl output? $ ./scripts/get_maintainer.pl -f drivers/cpuidle/governors/menu.c "Rafael J. Wysocki" (commit_signer:4/7=57%,authored:1/7=14%,added_lines:2/19=11%,remove d_lines:2/28=7%) Daniel Lezcano (commit_signer:3/7=43%,authored:1/7=14%,added_lines:1/19=5%) Rik van Riel (commit_signer:3/7=43%,authored:3/7=43%,added_lines:5/19=26%,remove d_lines:3/28=11%) Len Brown (commit_signer:1/7=14%,authored:1/7=14%,added_lines:10/19=53%,remov ed_lines:15/28=54%) "Peter Zijlstra (Intel)" (commit_signer:1/7=14%) Javi Merino (authored:1/7=14%,added_lines:1/19=5%,removed_lines:7/28=25%) linux-kernel@vger.kernel.org (open list) I'm not sure why it doesn't show up in there. If you look at MAINTAINERS under CPUIDLE DRIVERS, linux-pm is actually listed there. Because the pattern is just the files in the top level directory of drivers/cpuidle and not any files in any directory below From the MAINTAINERS pattern descriptions: F: Files and directories with wildcard patterns. A trailing slash includes all files and subdirectory files. F: drivers/net/all files in and below drivers/net F: drivers/net/* all files in drivers/net, but not below Maybe the answer is that get_maintainer.pl needs to be fixed ... Nope, the MAINTAINERS - CPUIDLE DRIVERS entry does though. OK, I see. Care to send this patch with a proper changelog/sign-off? --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 77ed3a0..8bd5c7e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3004,7 +3004,7 @@ M:Daniel Lezcano L:linux...@vger.kernel.org S:Maintained T:git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git -F: drivers/cpuidle/* +F: drivers/cpuidle/ F:include/linux/cpuidle.h CPUID/MSR DRIVER -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor
On Wed, 2015-11-04 at 00:03 +0100, Rafael J. Wysocki wrote: > On 11/3/2015 11:35 PM, Rik van Riel wrote: > > On 11/03/2015 05:05 PM, Rafael J. Wysocki wrote: > > > On 10/28/2015 11:46 PM, r...@redhat.com wrote: > > > > While working on a paravirt cpuidle driver for KVM guests, I > > > > noticed a number of small logic errors in the menu governor > > > > code. > > > > > > > > These patches should get rid of some artifacts that can break > > > > the logic in the menu governor under certain corner cases, and > > > > make idle state selection work better on CPUs with long C1 exit > > > > latencies. > > > > > > > > I have not seen any adverse effects with them in my (quick) > > > > tests. As expected, they do not seem to do much on systems with > > > > many power states and very low C1 exit latencies and target > > > > residencies. > > > > > > > Sorry for the trouble, but can you please resend the series with > > > CCs to > > > linux...@vger.kernel.org? That will make it way easier to handle > > > for me. > > Not a problem. Done. > > > > What change do I need to send in to ensure that the > > linux-pm mailing list shows up in get_maintainer.pl > > output? > > > > $ ./scripts/get_maintainer.pl -f drivers/cpuidle/governors/menu.c > > "Rafael J. Wysocki" > > (commit_signer:4/7=57%,authored:1/7=14%,added_lines:2/19=11%,remove > > d_lines:2/28=7%) > > Daniel Lezcano > > (commit_signer:3/7=43%,authored:1/7=14%,added_lines:1/19=5%) > > Rik van Riel > > (commit_signer:3/7=43%,authored:3/7=43%,added_lines:5/19=26%,remove > > d_lines:3/28=11%) > > Len Brown > > (commit_signer:1/7=14%,authored:1/7=14%,added_lines:10/19=53%,remov > > ed_lines:15/28=54%) > > "Peter Zijlstra (Intel)" > > (commit_signer:1/7=14%) > > Javi Merino > > (authored:1/7=14%,added_lines:1/19=5%,removed_lines:7/28=25%) > > linux-kernel@vger.kernel.org (open list) > > > > I'm not sure why it doesn't show up in there. > If you look at MAINTAINERS under CPUIDLE DRIVERS, linux-pm is > actually listed there. Because the pattern is just the files in the top level directory of drivers/cpuidle and not any files in any directory below >From the MAINTAINERS pattern descriptions: F: Files and directories with wildcard patterns. A trailing slash includes all files and subdirectory files. F: drivers/net/all files in and below drivers/net F: drivers/net/* all files in drivers/net, but not below > Maybe the answer is that get_maintainer.pl needs to be fixed ... Nope, the MAINTAINERS - CPUIDLE DRIVERS entry does though. --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 77ed3a0..8bd5c7e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3004,7 +3004,7 @@ M:Daniel Lezcano L: linux...@vger.kernel.org S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git -F: drivers/cpuidle/* +F: drivers/cpuidle/ F: include/linux/cpuidle.h CPUID/MSR DRIVER -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor
On 11/3/2015 11:35 PM, Rik van Riel wrote: On 11/03/2015 05:05 PM, Rafael J. Wysocki wrote: On 10/28/2015 11:46 PM, r...@redhat.com wrote: While working on a paravirt cpuidle driver for KVM guests, I noticed a number of small logic errors in the menu governor code. These patches should get rid of some artifacts that can break the logic in the menu governor under certain corner cases, and make idle state selection work better on CPUs with long C1 exit latencies. I have not seen any adverse effects with them in my (quick) tests. As expected, they do not seem to do much on systems with many power states and very low C1 exit latencies and target residencies. Sorry for the trouble, but can you please resend the series with CCs to linux...@vger.kernel.org? That will make it way easier to handle for me. Not a problem. Done. What change do I need to send in to ensure that the linux-pm mailing list shows up in get_maintainer.pl output? $ ./scripts/get_maintainer.pl -f drivers/cpuidle/governors/menu.c "Rafael J. Wysocki" (commit_signer:4/7=57%,authored:1/7=14%,added_lines:2/19=11%,removed_lines:2/28=7%) Daniel Lezcano (commit_signer:3/7=43%,authored:1/7=14%,added_lines:1/19=5%) Rik van Riel (commit_signer:3/7=43%,authored:3/7=43%,added_lines:5/19=26%,removed_lines:3/28=11%) Len Brown (commit_signer:1/7=14%,authored:1/7=14%,added_lines:10/19=53%,removed_lines:15/28=54%) "Peter Zijlstra (Intel)" (commit_signer:1/7=14%) Javi Merino (authored:1/7=14%,added_lines:1/19=5%,removed_lines:7/28=25%) linux-kernel@vger.kernel.org (open list) I'm not sure why it doesn't show up in there. If you look at MAINTAINERS under CPUIDLE DRIVERS, linux-pm is actually listed there. Maybe the answer is that get_maintainer.pl needs to be fixed ... Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor
On 11/03/2015 05:05 PM, Rafael J. Wysocki wrote: > On 10/28/2015 11:46 PM, r...@redhat.com wrote: >> While working on a paravirt cpuidle driver for KVM guests, I >> noticed a number of small logic errors in the menu governor >> code. >> >> These patches should get rid of some artifacts that can break >> the logic in the menu governor under certain corner cases, and >> make idle state selection work better on CPUs with long C1 exit >> latencies. >> >> I have not seen any adverse effects with them in my (quick) >> tests. As expected, they do not seem to do much on systems with >> many power states and very low C1 exit latencies and target residencies. >> > > Sorry for the trouble, but can you please resend the series with CCs to > linux...@vger.kernel.org? That will make it way easier to handle for me. Not a problem. Done. What change do I need to send in to ensure that the linux-pm mailing list shows up in get_maintainer.pl output? $ ./scripts/get_maintainer.pl -f drivers/cpuidle/governors/menu.c "Rafael J. Wysocki" (commit_signer:4/7=57%,authored:1/7=14%,added_lines:2/19=11%,removed_lines:2/28=7%) Daniel Lezcano (commit_signer:3/7=43%,authored:1/7=14%,added_lines:1/19=5%) Rik van Riel (commit_signer:3/7=43%,authored:3/7=43%,added_lines:5/19=26%,removed_lines:3/28=11%) Len Brown (commit_signer:1/7=14%,authored:1/7=14%,added_lines:10/19=53%,removed_lines:15/28=54%) "Peter Zijlstra (Intel)" (commit_signer:1/7=14%) Javi Merino (authored:1/7=14%,added_lines:1/19=5%,removed_lines:7/28=25%) linux-kernel@vger.kernel.org (open list) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/3] cpuidle: small improvements & fixes for menu governor (resend)
While working on a paravirt cpuidle driver for KVM guests, I noticed a number of small logic errors in the menu governor code. These patches should get rid of some artifacts that can break the logic in the menu governor under certain corner cases, and make idle state selection work better on CPUs with long C1 exit latencies. I have not seen any adverse effects with them in my (quick) tests. As expected, they do not seem to do much on systems with many power states and very low C1 exit latencies and target residencies. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor
On 10/28/2015 11:46 PM, r...@redhat.com wrote: While working on a paravirt cpuidle driver for KVM guests, I noticed a number of small logic errors in the menu governor code. These patches should get rid of some artifacts that can break the logic in the menu governor under certain corner cases, and make idle state selection work better on CPUs with long C1 exit latencies. I have not seen any adverse effects with them in my (quick) tests. As expected, they do not seem to do much on systems with many power states and very low C1 exit latencies and target residencies. Sorry for the trouble, but can you please resend the series with CCs to linux...@vger.kernel.org? That will make it way easier to handle for me. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/3] cpuidle: small improvements & fixes for menu governor
While working on a paravirt cpuidle driver for KVM guests, I noticed a number of small logic errors in the menu governor code. These patches should get rid of some artifacts that can break the logic in the menu governor under certain corner cases, and make idle state selection work better on CPUs with long C1 exit latencies. I have not seen any adverse effects with them in my (quick) tests. As expected, they do not seem to do much on systems with many power states and very low C1 exit latencies and target residencies. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/