Re: [PATCH 0/3] fs/efs: Follow kernel style guide
On Fri, Feb 05, 2021 at 11:37:46PM +0100, Richard Weinberger wrote: > On Fri, Feb 5, 2021 at 11:26 PM Amy Parker wrote: > > > > On Fri, Feb 5, 2021 at 5:1 AM David Sterba wrote: > > > > > > On Thu, Feb 04, 2021 at 08:52:14PM -0800, Amy Parker wrote: > > > > As the EFS driver is old and non-maintained, > > > > > > Is anybody using EFS on current kernels? There's not much point updating > > > it to current coding style, deleting fs/efs is probably the best option. > > > > > > > Wouldn't be surprised if there's a few systems out there that haven't > > migrated at all. > > Before ripping it from the kernel source you could do a FUSE port of EFS. > That way old filesystems can still get used on Linux. Agreed, replacing the obsolete filesystems by FUSE implementations would be great. Regarding EFS I got pointed to https://github.com/sophaskins/efs2tar that allows to access the old IRIX CDs (can be found on archive.org), so there's something.
Re: [PATCH 0/3] fs/efs: Follow kernel style guide
On Fri, Feb 5, 2021 at 11:26 PM Amy Parker wrote: > > On Fri, Feb 5, 2021 at 5:1 AM David Sterba wrote: > > > > On Thu, Feb 04, 2021 at 08:52:14PM -0800, Amy Parker wrote: > > > As the EFS driver is old and non-maintained, > > > > Is anybody using EFS on current kernels? There's not much point updating > > it to current coding style, deleting fs/efs is probably the best option. > > > > Wouldn't be surprised if there's a few systems out there that haven't > migrated at all. Before ripping it from the kernel source you could do a FUSE port of EFS. That way old filesystems can still get used on Linux. -- Thanks, //richard
Re: [PATCH 0/3] fs/efs: Follow kernel style guide
On Fri, Feb 5, 2021 at 2:37 PM Richard Weinberger wrote: > > On Fri, Feb 5, 2021 at 11:26 PM Amy Parker wrote: > > > > On Fri, Feb 5, 2021 at 5:1 AM David Sterba wrote: > > > > > > On Thu, Feb 04, 2021 at 08:52:14PM -0800, Amy Parker wrote: > > > > As the EFS driver is old and non-maintained, > > > > > > Is anybody using EFS on current kernels? There's not much point updating > > > it to current coding style, deleting fs/efs is probably the best option. > > > > > > > Wouldn't be surprised if there's a few systems out there that haven't > > migrated at all. > > Before ripping it from the kernel source you could do a FUSE port of EFS. > That way old filesystems can still get used on Linux. A FUSE port of EFS would be a great idea. Know anyone that would be interested in working on it? I might try picking it up if no one else wants it, we'll see.
Re: [PATCH 0/3] fs/efs: Follow kernel style guide
On Fri, Feb 5, 2021 at 5:1 AM David Sterba wrote: > > On Thu, Feb 04, 2021 at 08:52:14PM -0800, Amy Parker wrote: > > As the EFS driver is old and non-maintained, > > Is anybody using EFS on current kernels? There's not much point updating > it to current coding style, deleting fs/efs is probably the best option. > Wouldn't be surprised if there's a few systems out there that haven't migrated at all. > The EFS name is common for several filesystems, not to be confused with > eg. Encrypted File System. In linux it's the IRIX version, check > Kconfig, and you could hardly find the utilities to create such > filesystem. Ah yep, good point. -Amy IP
Re: [PATCH 0/3] fs/efs: Follow kernel style guide
On Thu, Feb 04, 2021 at 08:52:14PM -0800, Amy Parker wrote: > As the EFS driver is old and non-maintained, Is anybody using EFS on current kernels? There's not much point updating it to current coding style, deleting fs/efs is probably the best option. The EFS name is common for several filesystems, not to be confused with eg. Encrypted File System. In linux it's the IRIX version, check Kconfig, and you could hardly find the utilities to create such filesystem.
[PATCH 0/3] fs/efs: Follow kernel style guide
As the EFS driver is old and non-maintained, many kernel style guide rules have not been followed, and their violations have not been noticed. This patchset corrects those violations. Amy Parker (3): fs/efs: Use correct brace styling for statements fs/efs: Correct spacing after C keywords fs/efs: Fix line breakage for C keywords fs/efs/inode.c | 36 ++-- fs/efs/namei.c | 2 +- fs/efs/super.c | 25 +++-- 3 files changed, 34 insertions(+), 29 deletions(-) -- 2.29.2
