Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-11 Thread Chris Ball
Hi Matt,

On Fri, Feb 01 2013, Matt Porter wrote:
> This series adds DT DMA Engine Client support to the omap_hsmmc.
> It leverages the generic DMA OF helpers in -next and the
> dma_request_slave_channel_compat() wrapper introduced in the
> AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
> booting via DT. These platforms include omap2/3/4/5 and am33xx.
>
> These patches were split out from the v5 version of the AM33XX DMA
> series and split from the EDMA-specific omap_hsmmc changes.

Thanks, pushed to mmc-next for 3.9.

- Chris.
-- 
Chris Ball  
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-11 Thread Chris Ball
Hi Matt,

On Fri, Feb 01 2013, Matt Porter wrote:
 This series adds DT DMA Engine Client support to the omap_hsmmc.
 It leverages the generic DMA OF helpers in -next and the
 dma_request_slave_channel_compat() wrapper introduced in the
 AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
 booting via DT. These platforms include omap2/3/4/5 and am33xx.

 These patches were split out from the v5 version of the AM33XX DMA
 series and split from the EDMA-specific omap_hsmmc changes.

Thanks, pushed to mmc-next for 3.9.

- Chris.
-- 
Chris Ball   c...@laptop.org   http://printf.net/
One Laptop Per Child
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-06 Thread Arnd Bergmann
On Friday 01 February 2013, Matt Porter wrote:
> 
> This series adds DT DMA Engine Client support to the omap_hsmmc.
> It leverages the generic DMA OF helpers in -next and the
> dma_request_slave_channel_compat() wrapper introduced in the
> AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
> booting via DT. These platforms include omap2/3/4/5 and am33xx.
> 
> These patches were split out from the v5 version of the AM33XX DMA
> series and split from the EDMA-specific omap_hsmmc changes.
> 
> The series depends on the following patches:
> 
> - dmaengine DT support and edma dmaengine driver fix from
>   the git://git.infradead.org/users/vkoul/slave-dma.git next
>   branch
> - dma_request_slave_channel_compat() support
>   https://patchwork.kernel.org/patch/2081671/
> 
> The series with all dependencies can be found at
> https://github.com/ohporter/linux/tree/omap-hsmmc-dt-dmaengine-v1

Nice series,

Acked-by: Arnd Bergmann 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-06 Thread Matt Porter
On Wed, Feb 06, 2013 at 01:41:06PM +0100, Lars Poeschel wrote:
> Hi Matt!
> 
> At first thanks for you efforts on DMA Engine on AM33XX.
> 
> On Friday 01 February 2013 at 22:01:17, Matt Porter wrote:
> > This series adds DT DMA Engine Client support to the omap_hsmmc.
> > It leverages the generic DMA OF helpers in -next and the
> > dma_request_slave_channel_compat() wrapper introduced in the
> > AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
> > booting via DT. These platforms include omap2/3/4/5 and am33xx.
> > 
> > These patches were split out from the v5 version of the AM33XX DMA
> > series and split from the EDMA-specific omap_hsmmc changes.
> > 
> > The series depends on the following patches:
> > 
> > - dmaengine DT support and edma dmaengine driver fix from
> >   the git://git.infradead.org/users/vkoul/slave-dma.git next
> >   branch
> > - dma_request_slave_channel_compat() support
> >   https://patchwork.kernel.org/patch/2081671/
> > 
> > The series with all dependencies can be found at
> > https://github.com/ohporter/linux/tree/omap-hsmmc-dt-dmaengine-v1
> 
> I cloned your github repository and did short testing with it. I get the 
> following error when the kernel mounts my sd-card:
> 
> Starting udev
> [5.884738] udevd[72]: starting version 182
> [8.879651] edma-dma-engine edma-dma-engine.0: Exceeded max SG segments 33 

Hi Lars,

I left it somewhat ambiguous as to what this series claims to support,
sorry about that. This series, by itself, supports only platforms using
SDMA (omap 2/3/4/5 assuming you add the appropriate DMA dts bits). This
is only part of what am33xx requires for working mmc support. I've also
posted v3 of dmaengine slave sg caps series at
https://lkml.org/lkml/2013/2/4/561

I have to rebase the am33xx specific bits for omap_hsmmc on top of that
and post. That was previously all contained in one series but I didn't
want to block omap2/3/4/5 from working DMA on DT support until the api
change is resolved for am33xx.

-Matt

> [8.887377] omap_hsmmc mmc.3: prep_slave_sg() failed
> [8.892588] omap_hsmmc mmc.3: MMC start dma failure
> [8.897725] mmcblk0: unknown error -1 sending read/write command, card 
> status 0x900
> [8.905889] end_request: I/O error, dev mmcblk0, sector 17039
> [8.911926] end_request: I/O error, dev mmcblk0, sector 17047
> [8.917934] end_request: I/O error, dev mmcblk0, sector 17055
> [8.923960] end_request: I/O error, dev mmcblk0, sector 17063
> [8.929967] end_request: I/O error, dev mmcblk0, sector 17071
> [8.935988] end_request: I/O error, dev mmcblk0, sector 17079
> [8.942010] end_request: I/O error, dev mmcblk0, sector 17087
> [8.948016] end_request: I/O error, dev mmcblk0, sector 17095
> [8.954037] end_request: I/O error, dev mmcblk0, sector 17103
> [8.960043] end_request: I/O error, dev mmcblk0, sector 17111
> [9.020919] EXT4-fs error (device mmcblk0p2): __ext4_get_inode_loc:3764: 
> inode #8: block 239: comm mount: unable to read itable block
> [9.033514] EXT4-fs (mmcblk0p2): no journal found
> [9.043799] kjournald starting.  Commit interval 5 seconds
> [9.049589] EXT3-fs (mmcblk0p2): warning: mounting fs with errors, running 
> e2fsck is recommended
> [9.060940] EXT3-fs (mmcblk0p2): using internal journal
> [9.066437] EXT3-fs (mmcblk0p2): recovery complete
> [9.071460] EXT3-fs (mmcblk0p2): mounted filesystem with ordered data mode
> 
> After that the filesystem on the sd-card has an error that I have to fix with 
> e2fsck. As rootfs I use a nfsroot.
> In my quick tests, same setup, I don't get any error on edma-dmaengine-
> am33xx-v5 branch of your repository.
> If you need any further information, let me now.
> 
> Regards,
> Lars
> ___
> devicetree-discuss mailing list
> devicetree-disc...@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-06 Thread Lars Poeschel
Hi Matt!

At first thanks for you efforts on DMA Engine on AM33XX.

On Friday 01 February 2013 at 22:01:17, Matt Porter wrote:
> This series adds DT DMA Engine Client support to the omap_hsmmc.
> It leverages the generic DMA OF helpers in -next and the
> dma_request_slave_channel_compat() wrapper introduced in the
> AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
> booting via DT. These platforms include omap2/3/4/5 and am33xx.
> 
> These patches were split out from the v5 version of the AM33XX DMA
> series and split from the EDMA-specific omap_hsmmc changes.
> 
> The series depends on the following patches:
> 
>   - dmaengine DT support and edma dmaengine driver fix from
> the git://git.infradead.org/users/vkoul/slave-dma.git next
> branch
>   - dma_request_slave_channel_compat() support
> https://patchwork.kernel.org/patch/2081671/
> 
> The series with all dependencies can be found at
> https://github.com/ohporter/linux/tree/omap-hsmmc-dt-dmaengine-v1

I cloned your github repository and did short testing with it. I get the 
following error when the kernel mounts my sd-card:

Starting udev
[5.884738] udevd[72]: starting version 182
[8.879651] edma-dma-engine edma-dma-engine.0: Exceeded max SG segments 33 
> 16
[8.887377] omap_hsmmc mmc.3: prep_slave_sg() failed
[8.892588] omap_hsmmc mmc.3: MMC start dma failure
[8.897725] mmcblk0: unknown error -1 sending read/write command, card 
status 0x900
[8.905889] end_request: I/O error, dev mmcblk0, sector 17039
[8.911926] end_request: I/O error, dev mmcblk0, sector 17047
[8.917934] end_request: I/O error, dev mmcblk0, sector 17055
[8.923960] end_request: I/O error, dev mmcblk0, sector 17063
[8.929967] end_request: I/O error, dev mmcblk0, sector 17071
[8.935988] end_request: I/O error, dev mmcblk0, sector 17079
[8.942010] end_request: I/O error, dev mmcblk0, sector 17087
[8.948016] end_request: I/O error, dev mmcblk0, sector 17095
[8.954037] end_request: I/O error, dev mmcblk0, sector 17103
[8.960043] end_request: I/O error, dev mmcblk0, sector 17111
[9.020919] EXT4-fs error (device mmcblk0p2): __ext4_get_inode_loc:3764: 
inode #8: block 239: comm mount: unable to read itable block
[9.033514] EXT4-fs (mmcblk0p2): no journal found
[9.043799] kjournald starting.  Commit interval 5 seconds
[9.049589] EXT3-fs (mmcblk0p2): warning: mounting fs with errors, running 
e2fsck is recommended
[9.060940] EXT3-fs (mmcblk0p2): using internal journal
[9.066437] EXT3-fs (mmcblk0p2): recovery complete
[9.071460] EXT3-fs (mmcblk0p2): mounted filesystem with ordered data mode

After that the filesystem on the sd-card has an error that I have to fix with 
e2fsck. As rootfs I use a nfsroot.
In my quick tests, same setup, I don't get any error on edma-dmaengine-
am33xx-v5 branch of your repository.
If you need any further information, let me now.

Regards,
Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-06 Thread Lars Poeschel
Hi Matt!

At first thanks for you efforts on DMA Engine on AM33XX.

On Friday 01 February 2013 at 22:01:17, Matt Porter wrote:
 This series adds DT DMA Engine Client support to the omap_hsmmc.
 It leverages the generic DMA OF helpers in -next and the
 dma_request_slave_channel_compat() wrapper introduced in the
 AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
 booting via DT. These platforms include omap2/3/4/5 and am33xx.
 
 These patches were split out from the v5 version of the AM33XX DMA
 series and split from the EDMA-specific omap_hsmmc changes.
 
 The series depends on the following patches:
 
   - dmaengine DT support and edma dmaengine driver fix from
 the git://git.infradead.org/users/vkoul/slave-dma.git next
 branch
   - dma_request_slave_channel_compat() support
 https://patchwork.kernel.org/patch/2081671/
 
 The series with all dependencies can be found at
 https://github.com/ohporter/linux/tree/omap-hsmmc-dt-dmaengine-v1

I cloned your github repository and did short testing with it. I get the 
following error when the kernel mounts my sd-card:

Starting udev
[5.884738] udevd[72]: starting version 182
[8.879651] edma-dma-engine edma-dma-engine.0: Exceeded max SG segments 33 
 16
[8.887377] omap_hsmmc mmc.3: prep_slave_sg() failed
[8.892588] omap_hsmmc mmc.3: MMC start dma failure
[8.897725] mmcblk0: unknown error -1 sending read/write command, card 
status 0x900
[8.905889] end_request: I/O error, dev mmcblk0, sector 17039
[8.911926] end_request: I/O error, dev mmcblk0, sector 17047
[8.917934] end_request: I/O error, dev mmcblk0, sector 17055
[8.923960] end_request: I/O error, dev mmcblk0, sector 17063
[8.929967] end_request: I/O error, dev mmcblk0, sector 17071
[8.935988] end_request: I/O error, dev mmcblk0, sector 17079
[8.942010] end_request: I/O error, dev mmcblk0, sector 17087
[8.948016] end_request: I/O error, dev mmcblk0, sector 17095
[8.954037] end_request: I/O error, dev mmcblk0, sector 17103
[8.960043] end_request: I/O error, dev mmcblk0, sector 17111
[9.020919] EXT4-fs error (device mmcblk0p2): __ext4_get_inode_loc:3764: 
inode #8: block 239: comm mount: unable to read itable block
[9.033514] EXT4-fs (mmcblk0p2): no journal found
[9.043799] kjournald starting.  Commit interval 5 seconds
[9.049589] EXT3-fs (mmcblk0p2): warning: mounting fs with errors, running 
e2fsck is recommended
[9.060940] EXT3-fs (mmcblk0p2): using internal journal
[9.066437] EXT3-fs (mmcblk0p2): recovery complete
[9.071460] EXT3-fs (mmcblk0p2): mounted filesystem with ordered data mode

After that the filesystem on the sd-card has an error that I have to fix with 
e2fsck. As rootfs I use a nfsroot.
In my quick tests, same setup, I don't get any error on edma-dmaengine-
am33xx-v5 branch of your repository.
If you need any further information, let me now.

Regards,
Lars
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-06 Thread Matt Porter
On Wed, Feb 06, 2013 at 01:41:06PM +0100, Lars Poeschel wrote:
 Hi Matt!
 
 At first thanks for you efforts on DMA Engine on AM33XX.
 
 On Friday 01 February 2013 at 22:01:17, Matt Porter wrote:
  This series adds DT DMA Engine Client support to the omap_hsmmc.
  It leverages the generic DMA OF helpers in -next and the
  dma_request_slave_channel_compat() wrapper introduced in the
  AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
  booting via DT. These platforms include omap2/3/4/5 and am33xx.
  
  These patches were split out from the v5 version of the AM33XX DMA
  series and split from the EDMA-specific omap_hsmmc changes.
  
  The series depends on the following patches:
  
  - dmaengine DT support and edma dmaengine driver fix from
the git://git.infradead.org/users/vkoul/slave-dma.git next
branch
  - dma_request_slave_channel_compat() support
https://patchwork.kernel.org/patch/2081671/
  
  The series with all dependencies can be found at
  https://github.com/ohporter/linux/tree/omap-hsmmc-dt-dmaengine-v1
 
 I cloned your github repository and did short testing with it. I get the 
 following error when the kernel mounts my sd-card:
 
 Starting udev
 [5.884738] udevd[72]: starting version 182
 [8.879651] edma-dma-engine edma-dma-engine.0: Exceeded max SG segments 33 

Hi Lars,

I left it somewhat ambiguous as to what this series claims to support,
sorry about that. This series, by itself, supports only platforms using
SDMA (omap 2/3/4/5 assuming you add the appropriate DMA dts bits). This
is only part of what am33xx requires for working mmc support. I've also
posted v3 of dmaengine slave sg caps series at
https://lkml.org/lkml/2013/2/4/561

I have to rebase the am33xx specific bits for omap_hsmmc on top of that
and post. That was previously all contained in one series but I didn't
want to block omap2/3/4/5 from working DMA on DT support until the api
change is resolved for am33xx.

-Matt

 [8.887377] omap_hsmmc mmc.3: prep_slave_sg() failed
 [8.892588] omap_hsmmc mmc.3: MMC start dma failure
 [8.897725] mmcblk0: unknown error -1 sending read/write command, card 
 status 0x900
 [8.905889] end_request: I/O error, dev mmcblk0, sector 17039
 [8.911926] end_request: I/O error, dev mmcblk0, sector 17047
 [8.917934] end_request: I/O error, dev mmcblk0, sector 17055
 [8.923960] end_request: I/O error, dev mmcblk0, sector 17063
 [8.929967] end_request: I/O error, dev mmcblk0, sector 17071
 [8.935988] end_request: I/O error, dev mmcblk0, sector 17079
 [8.942010] end_request: I/O error, dev mmcblk0, sector 17087
 [8.948016] end_request: I/O error, dev mmcblk0, sector 17095
 [8.954037] end_request: I/O error, dev mmcblk0, sector 17103
 [8.960043] end_request: I/O error, dev mmcblk0, sector 17111
 [9.020919] EXT4-fs error (device mmcblk0p2): __ext4_get_inode_loc:3764: 
 inode #8: block 239: comm mount: unable to read itable block
 [9.033514] EXT4-fs (mmcblk0p2): no journal found
 [9.043799] kjournald starting.  Commit interval 5 seconds
 [9.049589] EXT3-fs (mmcblk0p2): warning: mounting fs with errors, running 
 e2fsck is recommended
 [9.060940] EXT3-fs (mmcblk0p2): using internal journal
 [9.066437] EXT3-fs (mmcblk0p2): recovery complete
 [9.071460] EXT3-fs (mmcblk0p2): mounted filesystem with ordered data mode
 
 After that the filesystem on the sd-card has an error that I have to fix with 
 e2fsck. As rootfs I use a nfsroot.
 In my quick tests, same setup, I don't get any error on edma-dmaengine-
 am33xx-v5 branch of your repository.
 If you need any further information, let me now.
 
 Regards,
 Lars
 ___
 devicetree-discuss mailing list
 devicetree-disc...@lists.ozlabs.org
 https://lists.ozlabs.org/listinfo/devicetree-discuss
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-06 Thread Arnd Bergmann
On Friday 01 February 2013, Matt Porter wrote:
 
 This series adds DT DMA Engine Client support to the omap_hsmmc.
 It leverages the generic DMA OF helpers in -next and the
 dma_request_slave_channel_compat() wrapper introduced in the
 AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
 booting via DT. These platforms include omap2/3/4/5 and am33xx.
 
 These patches were split out from the v5 version of the AM33XX DMA
 series and split from the EDMA-specific omap_hsmmc changes.
 
 The series depends on the following patches:
 
 - dmaengine DT support and edma dmaengine driver fix from
   the git://git.infradead.org/users/vkoul/slave-dma.git next
   branch
 - dma_request_slave_channel_compat() support
   https://patchwork.kernel.org/patch/2081671/
 
 The series with all dependencies can be found at
 https://github.com/ohporter/linux/tree/omap-hsmmc-dt-dmaengine-v1

Nice series,

Acked-by: Arnd Bergmann a...@arndb.de
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-01 Thread Matt Porter
This series adds DT DMA Engine Client support to the omap_hsmmc.
It leverages the generic DMA OF helpers in -next and the
dma_request_slave_channel_compat() wrapper introduced in the
AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
booting via DT. These platforms include omap2/3/4/5 and am33xx.

These patches were split out from the v5 version of the AM33XX DMA
series and split from the EDMA-specific omap_hsmmc changes.

The series depends on the following patches:

- dmaengine DT support and edma dmaengine driver fix from
  the git://git.infradead.org/users/vkoul/slave-dma.git next
  branch
- dma_request_slave_channel_compat() support
  https://patchwork.kernel.org/patch/2081671/

The series with all dependencies can be found at
https://github.com/ohporter/linux/tree/omap-hsmmc-dt-dmaengine-v1

Matt Porter (2):
  mmc: omap_hsmmc: convert to dma_request_slave_channel_compat()
  mmc: omap_hsmmc: add generic DMA request support to the DT binding

Santosh Shilimkar (1):
  mmc: omap_hsmmc: Skip platform_get_resource_byname() for dt case

 .../devicetree/bindings/mmc/ti-omap-hsmmc.txt  |   26 +-
 drivers/mmc/host/omap_hsmmc.c  |   38 
 2 files changed, 48 insertions(+), 16 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-01 Thread Matt Porter
This series adds DT DMA Engine Client support to the omap_hsmmc.
It leverages the generic DMA OF helpers in -next and the
dma_request_slave_channel_compat() wrapper introduced in the
AM33XX DMA Engine series to support DMA in omap_hsmmc on platforms
booting via DT. These platforms include omap2/3/4/5 and am33xx.

These patches were split out from the v5 version of the AM33XX DMA
series and split from the EDMA-specific omap_hsmmc changes.

The series depends on the following patches:

- dmaengine DT support and edma dmaengine driver fix from
  the git://git.infradead.org/users/vkoul/slave-dma.git next
  branch
- dma_request_slave_channel_compat() support
  https://patchwork.kernel.org/patch/2081671/

The series with all dependencies can be found at
https://github.com/ohporter/linux/tree/omap-hsmmc-dt-dmaengine-v1

Matt Porter (2):
  mmc: omap_hsmmc: convert to dma_request_slave_channel_compat()
  mmc: omap_hsmmc: add generic DMA request support to the DT binding

Santosh Shilimkar (1):
  mmc: omap_hsmmc: Skip platform_get_resource_byname() for dt case

 .../devicetree/bindings/mmc/ti-omap-hsmmc.txt  |   26 +-
 drivers/mmc/host/omap_hsmmc.c  |   38 
 2 files changed, 48 insertions(+), 16 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/