Re: [PATCH 0/3] workqueue: code refine/clean for workqueue
On 06/05/2013 03:10 PM, Michael Wang wrote: > Code refine/clean patch set for workqueue. > > Michael Wang (3): > [PATCH 1/3] workqueue: move the internal helper from .h to .c > [PATCH 2/3] workqueue: remove the unused helper in .h > [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() Hi, Tejun Sounds like I failed to grasp the essentials of the way we maintain workqueue :( These are just self opinion I got during the review, please ignore them if they will cause trouble to your maintain work :) Regards, Michael Wang > > --- > b/include/linux/workqueue.h |5 - > b/kernel/workqueue.c|5 + > include/linux/workqueue.h | 27 --- > kernel/workqueue.c |6 +++--- > 4 files changed, 8 insertions(+), 35 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] workqueue: code refine/clean for workqueue
On 06/05/2013 03:10 PM, Michael Wang wrote: > Code refine/clean patch set for workqueue. > > Michael Wang (3): > [PATCH 1/3] workqueue: move the internal helper from .h to .c > [PATCH 2/3] workqueue: remove the unused helper in .h > [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() [PATCH 4/3] workqueue: code refine in wqattrs_equal() Lost one... Regards, Michael Wang > > --- > b/include/linux/workqueue.h |5 - > b/kernel/workqueue.c|5 + > include/linux/workqueue.h | 27 --- > kernel/workqueue.c |6 +++--- > 4 files changed, 8 insertions(+), 35 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/3] workqueue: code refine/clean for workqueue
Code refine/clean patch set for workqueue. Michael Wang (3): [PATCH 1/3] workqueue: move the internal helper from .h to .c [PATCH 2/3] workqueue: remove the unused helper in .h [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() --- b/include/linux/workqueue.h |5 - b/kernel/workqueue.c|5 + include/linux/workqueue.h | 27 --- kernel/workqueue.c |6 +++--- 4 files changed, 8 insertions(+), 35 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/3] workqueue: code refine/clean for workqueue
Code refine/clean patch set for workqueue. Michael Wang (3): [PATCH 1/3] workqueue: move the internal helper from .h to .c [PATCH 2/3] workqueue: remove the unused helper in .h [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() --- b/include/linux/workqueue.h |5 - b/kernel/workqueue.c|5 + include/linux/workqueue.h | 27 --- kernel/workqueue.c |6 +++--- 4 files changed, 8 insertions(+), 35 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] workqueue: code refine/clean for workqueue
On 06/05/2013 03:10 PM, Michael Wang wrote: Code refine/clean patch set for workqueue. Michael Wang (3): [PATCH 1/3] workqueue: move the internal helper from .h to .c [PATCH 2/3] workqueue: remove the unused helper in .h [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() [PATCH 4/3] workqueue: code refine in wqattrs_equal() Lost one... Regards, Michael Wang --- b/include/linux/workqueue.h |5 - b/kernel/workqueue.c|5 + include/linux/workqueue.h | 27 --- kernel/workqueue.c |6 +++--- 4 files changed, 8 insertions(+), 35 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] workqueue: code refine/clean for workqueue
On 06/05/2013 03:10 PM, Michael Wang wrote: Code refine/clean patch set for workqueue. Michael Wang (3): [PATCH 1/3] workqueue: move the internal helper from .h to .c [PATCH 2/3] workqueue: remove the unused helper in .h [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() Hi, Tejun Sounds like I failed to grasp the essentials of the way we maintain workqueue :( These are just self opinion I got during the review, please ignore them if they will cause trouble to your maintain work :) Regards, Michael Wang --- b/include/linux/workqueue.h |5 - b/kernel/workqueue.c|5 + include/linux/workqueue.h | 27 --- kernel/workqueue.c |6 +++--- 4 files changed, 8 insertions(+), 35 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
