Re: [PATCH 0/4] Add support for GPU load values
Hi Lucas, Am Fr., 10. Juli 2020 um 10:44 Uhr schrieb Christian Gmeiner : > > Hoi Lucas > > Am Fr., 10. Juli 2020 um 10:31 Uhr schrieb Lucas Stach > : > > > > Hi Christian, > > > > Am Freitag, den 10.07.2020, 09:41 +0200 schrieb Christian Gmeiner: > > > This patch series add support for loadavg values for GPU > > > sub-components. I am adding a SMA algorithm as I was not > > > really sure if EWMA would be a good fit for this use case. > > > > 1 second is a pretty long window in GPU time. Why do you feel that a > > simple moving average is more appropriate than a exponentially > > weighted one here? Note that I haven't given this any thought myself > > and haven't made up my mind yet, so this is a honest question to > > understand the reasoning behind your choice. > > > I have v2 ready except for this point. If you want to go with EWMA could you provide me with a good weight reciprocal value to use? -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy
Re: [PATCH 0/4] Add support for GPU load values
Hoi Lucas Am Fr., 10. Juli 2020 um 10:31 Uhr schrieb Lucas Stach : > > Hi Christian, > > Am Freitag, den 10.07.2020, 09:41 +0200 schrieb Christian Gmeiner: > > This patch series add support for loadavg values for GPU > > sub-components. I am adding a SMA algorithm as I was not > > really sure if EWMA would be a good fit for this use case. > > 1 second is a pretty long window in GPU time. Why do you feel that a > simple moving average is more appropriate than a exponentially > weighted one here? Note that I haven't given this any thought myself > and haven't made up my mind yet, so this is a honest question to > understand the reasoning behind your choice. > I played with both variants but I 'feel' that SMA might be a better fit. To be honest I have no background in signal processing and stuff like this so.. I will go the route you guide me to :) I have kept the "interface" for SMA equal to the one EWMA uses so I can easily switch between them. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy
Re: [PATCH 0/4] Add support for GPU load values
Hi Christian, Am Freitag, den 10.07.2020, 09:41 +0200 schrieb Christian Gmeiner: > This patch series add support for loadavg values for GPU > sub-components. I am adding a SMA algorithm as I was not > really sure if EWMA would be a good fit for this use case. 1 second is a pretty long window in GPU time. Why do you feel that a simple moving average is more appropriate than a exponentially weighted one here? Note that I haven't given this any thought myself and haven't made up my mind yet, so this is a honest question to understand the reasoning behind your choice. Regards, Lucas > Christian Gmeiner (4): > drm/etnaviv: add simple moving average (SMA) > drm/etnaviv: add loadavg accounting > drm/etnaviv: show loadavg in debugfs > drm/etnaviv: export loadavg via perfmon > > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 14 > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 44 - > drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 29 + > drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 79 +++ > drivers/gpu/drm/etnaviv/etnaviv_sma.h | 53 +++ > 5 files changed, 218 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/etnaviv/etnaviv_sma.h >
[PATCH 0/4] Add support for GPU load values
This patch series add support for loadavg values for GPU sub-components. I am adding a SMA algorithm as I was not really sure if EWMA would be a good fit for this use case. Christian Gmeiner (4): drm/etnaviv: add simple moving average (SMA) drm/etnaviv: add loadavg accounting drm/etnaviv: show loadavg in debugfs drm/etnaviv: export loadavg via perfmon drivers/gpu/drm/etnaviv/etnaviv_drv.c | 14 drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 44 - drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 29 + drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 79 +++ drivers/gpu/drm/etnaviv/etnaviv_sma.h | 53 +++ 5 files changed, 218 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/etnaviv/etnaviv_sma.h -- 2.26.2
