Re: [PATCH 0/7] Make check implementation arch agnostic

[Miroslav Benes]

On Mon, 8 Jun 2020, Julien Thierry wrote:

> Hi,
> 
> The current implementation of the check subcommand has various x86 bits
> here and there. In order to prepare objtool to provide check for other
> architectures, add some abstraction over the x86 specific bits, relying
> on objtool arch specific code to provide some necessary operations.
> 
> This is part of the effort to implement check for arm64, initiated [1]
> by Raphael. The series is based on top of the separation of check & orc
> subcommands series[2].
> 
> I've push both series base on top of tip/objtool/core at [3].
> 
> - The first two patches make it simpler for new arches to provide their
> list of kernel headers, without worrying about modifications in the x86
> headers.
> - Patch 3 Moves arch specific macros to more suitable location
> - Patches 4 and 5 add abstraction to handle alternatives
> - Patch 6 adds abstraction to handle jump table
> - Patch 7 abstracts the use of unwind hints. Adding it as RFC as I'm sure
>   there's room for improvement.

Reviewed-by: Miroslav Benes 

for patches 1-6.

M

[PATCH 0/7] Make check implementation arch agnostic

[Julien Thierry]

Hi,

The current implementation of the check subcommand has various x86 bits
here and there. In order to prepare objtool to provide check for other
architectures, add some abstraction over the x86 specific bits, relying
on objtool arch specific code to provide some necessary operations.

This is part of the effort to implement check for arm64, initiated [1]
by Raphael. The series is based on top of the separation of check & orc
subcommands series[2].

I've push both series base on top of tip/objtool/core at [3].

- The first two patches make it simpler for new arches to provide their
list of kernel headers, without worrying about modifications in the x86
headers.
- Patch 3 Moves arch specific macros to more suitable location
- Patches 4 and 5 add abstraction to handle alternatives
- Patch 6 adds abstraction to handle jump table
- Patch 7 abstracts the use of unwind hints. Adding it as RFC as I'm sure
  there's room for improvement.

[1] https://lkml.org/lkml/2019/8/16/400
[2] https://lkml.org/lkml/2020/6/8/59
[3] https://github.com/julien-thierry/linux/tree/arch-independent-check

Cheers,

Julien

-->

Julien Thierry (6):
  objtool: Group headers to check in a single list
  objtool: Make sync-check consider the target architecture
  objtool: Move macros describing structures to arch-dependent code
  objtool: Abstract alternative special case handling
  objtool: Make relocation in alternative handling arch dependent
  objtool: Make unwind_hints available for all architectures

Raphael Gault (1):
  objtool: Refactor switch-tables code to support other architectures

 arch/x86/include/asm/orc_types.h  |  13 --
 arch/x86/include/asm/unwind_hints.h   |  44 +
 include/linux/frame.h |  83 -
 tools/arch/x86/include/asm/orc_types.h|  13 --
 tools/include/linux/frame.h   | 114 
 tools/objtool/Makefile|   2 +-
 tools/objtool/arch.h  |   5 +-
 tools/objtool/arch/x86/Build  |   1 +
 tools/objtool/arch/x86/arch_special.c | 145 +++
 tools/objtool/arch/x86/decode.c   |  54 ++
 tools/objtool/arch/x86/include/arch_special.h |  20 +++
 tools/objtool/cfi.h   |   3 +-
 tools/objtool/check.c | 166 ++
 tools/objtool/check.h |   7 +-
 tools/objtool/objtool.h   |   2 +
 tools/objtool/orc_gen.c   |   4 +-
 tools/objtool/special.c   |  48 +
 tools/objtool/special.h   |  10 ++
 tools/objtool/sync-check.sh   |  27 ++-
 tools/objtool/weak.c  |   2 -
 20 files changed, 490 insertions(+), 273 deletions(-)
 create mode 100644 tools/include/linux/frame.h
 create mode 100644 tools/objtool/arch/x86/arch_special.c
 create mode 100644 tools/objtool/arch/x86/include/arch_special.h

--
2.21.1