Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
Hi Bryan, On 11/20/2013 04:20 AM, Bryan Wu wrote: On Tue, Nov 19, 2013 at 2:35 AM, Pali Rohár wrote: >Hello, > >now I tested that patch on top of 3.12-rc5 with this led example: > > # Clearing LED-state to be sure > echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo 0 > /sys/class/leds/lp5523:r/brightness > echo 0 > /sys/class/leds/lp5523:g/brightness > echo 0 > /sys/class/leds/lp5523:b/brightness > > # Setting yellow light pattern and running it > echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo "01100" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds > echo "9d804000427f0d7f7f007f004200" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load > echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo "0" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds > echo "9d80" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load > echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo 20 > /sys/class/leds/lp5523:r/led_current > echo 2 > /sys/class/leds/lp5523:g/led_current > echo 0 > /sys/class/leds/lp5523:b/led_current > >And now it working, led blinks :-) I also tested Maemo >application for managing lp5523 led and now it working too. > That's good. We can post this fixing patch to stable tree as well as latest upstream kernel. Milo, do you need to update your patch, if not I'm going to take it into my tree and for stable tree. I'll send the patch-set again because LP5521 is also required to be fixed. And _remove() also needs to be updated. I can send it by tomorrow. Thanks, - Milo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Tue, Nov 19, 2013 at 2:35 AM, Pali Rohár wrote: > Hello, > > now I tested that patch on top of 3.12-rc5 with this led example: > > # Clearing LED-state to be sure > echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo 0 > /sys/class/leds/lp5523:r/brightness > echo 0 > /sys/class/leds/lp5523:g/brightness > echo 0 > /sys/class/leds/lp5523:b/brightness > > # Setting yellow light pattern and running it > echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo "01100" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds > echo "9d804000427f0d7f7f007f004200" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load > echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo "0" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds > echo "9d80" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load > echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo 20 > /sys/class/leds/lp5523:r/led_current > echo 2 > /sys/class/leds/lp5523:g/led_current > echo 0 > /sys/class/leds/lp5523:b/led_current > > And now it working, led blinks :-) I also tested Maemo > application for managing lp5523 led and now it working too. > That's good. We can post this fixing patch to stable tree as well as latest upstream kernel. Milo, do you need to update your patch, if not I'm going to take it into my tree and for stable tree. Thanks, -Bryan > But new interface via request_firmware still not working. > Directory /sys/class/firmware/lp5523/data not exists. > > I think that there can be race condition with udev which is > responsible for firmware loading... Anyway main problem solved, > old interface is working again and old applications too. > > On Tuesday 19 November 2013 02:13:49 Bryan Wu wrote: >> Pali, >> >> Could you please test Milo's patch? >> >> Thanks, >> -Bryan >> >> On Thu, Nov 7, 2013 at 9:15 PM, Milo Kim wrote: >> > Hi Pali, >> > >> > Sorry for the late reply. >> > >> > On 10/26/2013 03:21 AM, Pali Rohár wrote: >> >> On Friday 25 October 2013 19:10:07 Bryan Wu wrote: >> >>> On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár >> >> >> >> wrote: >> >>> On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: >> > On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim >> >> wrote: >> >>> This patch-set resolves the application conflict by >> >>> >> >> restoring sysfs files. >> >> >> >> For LP5521 >> >> >> >>engine1/2/3_mode >> >>engine1/2/3_load >> >> >> >> For LP5523 >> >> >> >>engine1/2/3_mode >> >>engine1/2/3_load >> >>engine1/2/3_leds >> >> >> >> Those attributes are accessed when LED pattern is run >> >> by custom application. Those were removed when LED >> >> pattern interface was changed to generic firmware >> >> interface. Please refer to commits below. >> >> >> >>git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 >> >>(leds-lp5521: use generic firmware interface) >> >> >> >>git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 >> >>(leds-lp5523: use generic firmware interface) >> >> >> >> Necessary attributes are restored in this patch-set. >> >> >> >> (Other changes) >> >> New data structure is added for handling values from/to >> >> an application. Few code fixes for reducing writing I2C >> >> commands. >> >> Add LP55xx common macros for code refactoring. >> >> Documentation updates. >> >> >> >> You can also pull from the location below >> >> This branch is based on 'for-next' of linux-leds. >> >> >> >>https://github.com/milokim/lp55xx.git >> >>resolve-missing-sysfs >> > >> > Thanks, I've already merged the whole patchset in my >> > -devel branch [1]. >> > >> > Pali, could you please help to test it on your hardware? >> > Just grab my -devel branch and build then run. >> > >> > Thanks, >> > -Bryan >> >> Hi, I see that all your patches are part of 3.12-rc5 >> kernel. >> >> Now I tested this example led program: >> # Clearing LED-state to be sure >> echo "disabled" > >> /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode >> echo "disabled" > >> /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode >> echo 0 >> >> > /sys/class/leds/lp5523:r/brightness >> >> echo 0 > /sys/class/leds/lp5523:g/brightness >> echo 0 > /sys/class/leds/lp5523:b/brightness >> >> # Setting yellow light pattern and running it >> echo "load" > >> /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode >> echo "01100" > >> /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds >> echo
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
Hello, now I tested that patch on top of 3.12-rc5 with this led example: # Clearing LED-state to be sure echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 > /sys/class/leds/lp5523:r/brightness echo 0 > /sys/class/leds/lp5523:g/brightness echo 0 > /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo "01100" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo "9d804000427f0d7f7f007f004200" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo "0" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo "9d80" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 > /sys/class/leds/lp5523:r/led_current echo 2 > /sys/class/leds/lp5523:g/led_current echo 0 > /sys/class/leds/lp5523:b/led_current And now it working, led blinks :-) I also tested Maemo application for managing lp5523 led and now it working too. But new interface via request_firmware still not working. Directory /sys/class/firmware/lp5523/data not exists. I think that there can be race condition with udev which is responsible for firmware loading... Anyway main problem solved, old interface is working again and old applications too. On Tuesday 19 November 2013 02:13:49 Bryan Wu wrote: > Pali, > > Could you please test Milo's patch? > > Thanks, > -Bryan > > On Thu, Nov 7, 2013 at 9:15 PM, Milo Kim wrote: > > Hi Pali, > > > > Sorry for the late reply. > > > > On 10/26/2013 03:21 AM, Pali Rohár wrote: > >> On Friday 25 October 2013 19:10:07 Bryan Wu wrote: > >>> On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár > >> > >> wrote: > >>> On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: > > On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim > > wrote: > >>> This patch-set resolves the application conflict by > >>> > >> restoring sysfs files. > >> > >> For LP5521 > >> > >>engine1/2/3_mode > >>engine1/2/3_load > >> > >> For LP5523 > >> > >>engine1/2/3_mode > >>engine1/2/3_load > >>engine1/2/3_leds > >> > >> Those attributes are accessed when LED pattern is run > >> by custom application. Those were removed when LED > >> pattern interface was changed to generic firmware > >> interface. Please refer to commits below. > >> > >>git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 > >>(leds-lp5521: use generic firmware interface) > >> > >>git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 > >>(leds-lp5523: use generic firmware interface) > >> > >> Necessary attributes are restored in this patch-set. > >> > >> (Other changes) > >> New data structure is added for handling values from/to > >> an application. Few code fixes for reducing writing I2C > >> commands. > >> Add LP55xx common macros for code refactoring. > >> Documentation updates. > >> > >> You can also pull from the location below > >> This branch is based on 'for-next' of linux-leds. > >> > >>https://github.com/milokim/lp55xx.git > >>resolve-missing-sysfs > > > > Thanks, I've already merged the whole patchset in my > > -devel branch [1]. > > > > Pali, could you please help to test it on your hardware? > > Just grab my -devel branch and build then run. > > > > Thanks, > > -Bryan > > Hi, I see that all your patches are part of 3.12-rc5 > kernel. > > Now I tested this example led program: > # Clearing LED-state to be sure > echo "disabled" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo "disabled" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo 0 > > > /sys/class/leds/lp5523:r/brightness > > echo 0 > /sys/class/leds/lp5523:g/brightness > echo 0 > /sys/class/leds/lp5523:b/brightness > > # Setting yellow light pattern and running it > echo "load" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo "01100" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds > echo "9d804000427f0d7f7f007f004200" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load > echo "load" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo "0" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds > echo "9d80" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load >
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
Hello, now I tested that patch on top of 3.12-rc5 with this led example: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current And now it working, led blinks :-) I also tested Maemo application for managing lp5523 led and now it working too. But new interface via request_firmware still not working. Directory /sys/class/firmware/lp5523/data not exists. I think that there can be race condition with udev which is responsible for firmware loading... Anyway main problem solved, old interface is working again and old applications too. On Tuesday 19 November 2013 02:13:49 Bryan Wu wrote: Pali, Could you please test Milo's patch? Thanks, -Bryan On Thu, Nov 7, 2013 at 9:15 PM, Milo Kim milo@ti.com wrote: Hi Pali, Sorry for the late reply. On 10/26/2013 03:21 AM, Pali Rohár wrote: On Friday 25 October 2013 19:10:07 Bryan Wu wrote: On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár pali.ro...@gmail.com wrote: On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim woogyom@gmail.com wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current In the latest LP5523 driver, I just found wrong operation mode setting in case of multiple engine used. (please find a patch below) All sysfs entries exists and every echo returned 0. But led does not start blinking that
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Tue, Nov 19, 2013 at 2:35 AM, Pali Rohár pali.ro...@gmail.com wrote: Hello, now I tested that patch on top of 3.12-rc5 with this led example: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current And now it working, led blinks :-) I also tested Maemo application for managing lp5523 led and now it working too. That's good. We can post this fixing patch to stable tree as well as latest upstream kernel. Milo, do you need to update your patch, if not I'm going to take it into my tree and for stable tree. Thanks, -Bryan But new interface via request_firmware still not working. Directory /sys/class/firmware/lp5523/data not exists. I think that there can be race condition with udev which is responsible for firmware loading... Anyway main problem solved, old interface is working again and old applications too. On Tuesday 19 November 2013 02:13:49 Bryan Wu wrote: Pali, Could you please test Milo's patch? Thanks, -Bryan On Thu, Nov 7, 2013 at 9:15 PM, Milo Kim milo@ti.com wrote: Hi Pali, Sorry for the late reply. On 10/26/2013 03:21 AM, Pali Rohár wrote: On Friday 25 October 2013 19:10:07 Bryan Wu wrote: On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár pali.ro...@gmail.com wrote: On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim woogyom@gmail.com wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
Hi Bryan, On 11/20/2013 04:20 AM, Bryan Wu wrote: On Tue, Nov 19, 2013 at 2:35 AM, Pali Rohárpali.ro...@gmail.com wrote: Hello, now I tested that patch on top of 3.12-rc5 with this led example: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current And now it working, led blinks :-) I also tested Maemo application for managing lp5523 led and now it working too. That's good. We can post this fixing patch to stable tree as well as latest upstream kernel. Milo, do you need to update your patch, if not I'm going to take it into my tree and for stable tree. I'll send the patch-set again because LP5521 is also required to be fixed. And _remove() also needs to be updated. I can send it by tomorrow. Thanks, - Milo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
Hi Pali, Sorry for the late reply. On 10/26/2013 03:21 AM, Pali Rohár wrote: On Friday 25 October 2013 19:10:07 Bryan Wu wrote: On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár wrote: On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 > /sys/class/leds/lp5523:r/brightness echo 0 > /sys/class/leds/lp5523:g/brightness echo 0 > /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo "01100" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo "9d804000427f0d7f7f007f004200" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo "0" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo "9d80" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 > /sys/class/leds/lp5523:r/led_current echo 2 > /sys/class/leds/lp5523:g/led_current echo 0 > /sys/class/leds/lp5523:b/led_current In the latest LP5523 driver, I just found wrong operation mode setting in case of multiple engine used. (please find a patch below) All sysfs entries exists and every echo returned 0. But led does not start blinking that yellow ligh pattern. So it not working on 3.12-rc5 kernel :-( OK, great! Do you still remember which kernel version works on you system? Milo, do you have time to take a look? I bet it's a regression somewhere. Thanks, -Bryan I do not know which version. Now I tried pattern example from Documentation/leds/leds-lp55xx.txt which using new API. echo 2 > /sys/class/i2c-adapter/i2c-2/2-0032/select_engine echo 1 > /sys/class/firmware/lp5523/loading echo "9d8044ff05ff437f" > /sys/class/firmware/lp5523/data echo 0 > /sys/class/firmware/lp5523/loading echo 1 > /sys/class/i2c-adapter/i2c-2/2-0032/run_engine But it failed at second command. In directory /sys/class/firmware/ I have only one file with name timeout. Nothing more, no lp5523 folder. I can't reproduce this issue but I found some duplicated mutex problem. But in my case, I could found /sys/class/firmware/lp5523 directory. Is any permission issue? Anyway, I've added fixed mutex code below. Could you check this patch below? If it's resolved, then I'll send official patch-set. 8< 8< --- From dad27e0d834a5635232116569aaa1fa471ac46bf Mon Sep 17 00:00:00 2001 From: Milo Kim Date: Fri, 8 Nov 2013 13:43:33 +0900 Subject: [PATCH] leds: lp5523: Fix multiple engine usage bug and remove duplicated mutex Fix multiple engine usage bug: Whenever the engine is loaded by the user-application, the operation mode is reset first. But it has a problem in case of multiple engine used because previous engine settings are cleared. The driver should update not whole 8bits but each engine bits by masking. Remove duplicate mutex: It can be a problem when a pattern is loaded via the firmware interface. LP55xx common driver has already locked the mutex in 'lp55xx_firmware_loaded()'. So it should be deleted. Signed-off-by: Milo Kim --- drivers/leds/leds-lp5523.c | 14 +- 1 file changed, 9 insertions(+), 5
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
Hi Pali, Sorry for the late reply. On 10/26/2013 03:21 AM, Pali Rohár wrote: On Friday 25 October 2013 19:10:07 Bryan Wu wrote: On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár pali.ro...@gmail.com wrote: On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim woogyom@gmail.com wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current In the latest LP5523 driver, I just found wrong operation mode setting in case of multiple engine used. (please find a patch below) All sysfs entries exists and every echo returned 0. But led does not start blinking that yellow ligh pattern. So it not working on 3.12-rc5 kernel :-( OK, great! Do you still remember which kernel version works on you system? Milo, do you have time to take a look? I bet it's a regression somewhere. Thanks, -Bryan I do not know which version. Now I tried pattern example from Documentation/leds/leds-lp55xx.txt which using new API. echo 2 /sys/class/i2c-adapter/i2c-2/2-0032/select_engine echo 1 /sys/class/firmware/lp5523/loading echo 9d8044ff05ff437f /sys/class/firmware/lp5523/data echo 0 /sys/class/firmware/lp5523/loading echo 1 /sys/class/i2c-adapter/i2c-2/2-0032/run_engine But it failed at second command. In directory /sys/class/firmware/ I have only one file with name timeout. Nothing more, no lp5523 folder. I can't reproduce this issue but I found some duplicated mutex problem. But in my case, I could found /sys/class/firmware/lp5523 directory. Is any permission issue? Anyway, I've added fixed mutex code below. Could you check this patch below? If it's resolved, then I'll send official patch-set. 8 8 --- From dad27e0d834a5635232116569aaa1fa471ac46bf Mon Sep 17 00:00:00 2001 From: Milo Kim milo@ti.com Date: Fri, 8 Nov 2013 13:43:33 +0900 Subject: [PATCH] leds: lp5523: Fix multiple engine usage bug and remove duplicated mutex Fix multiple engine usage bug: Whenever the engine is loaded by the user-application, the operation mode is reset first. But it has a problem in case of multiple engine used because previous engine settings are cleared. The driver should update not whole 8bits but each engine bits by masking. Remove duplicate mutex: It can be a problem when a pattern is loaded via the firmware interface. LP55xx common driver has already locked the mutex in 'lp55xx_firmware_loaded()'. So it should be deleted. Signed-off-by: Milo Kim milo@ti.com --- drivers/leds/leds-lp5523.c | 14 +- 1 file
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Fri, Oct 25, 2013 at 11:21 AM, Pali Rohár wrote: > On Friday 25 October 2013 19:10:07 Bryan Wu wrote: >> On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár > wrote: >> > On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: >> >> On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim > wrote: >> >> > This patch-set resolves the application conflict by >> >> > restoring sysfs files. >> >> > >> >> > For LP5521 >> >> > >> >> > engine1/2/3_mode >> >> > engine1/2/3_load >> >> > >> >> > For LP5523 >> >> > >> >> > engine1/2/3_mode >> >> > engine1/2/3_load >> >> > engine1/2/3_leds >> >> > >> >> > Those attributes are accessed when LED pattern is run by >> >> > custom application. Those were removed when LED pattern >> >> > interface was changed to generic firmware interface. >> >> > Please refer to commits below. >> >> > >> >> > git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 >> >> > (leds-lp5521: use generic firmware interface) >> >> > >> >> > git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 >> >> > (leds-lp5523: use generic firmware interface) >> >> > >> >> > Necessary attributes are restored in this patch-set. >> >> > >> >> > (Other changes) >> >> > New data structure is added for handling values from/to >> >> > an application. Few code fixes for reducing writing I2C >> >> > commands. >> >> > Add LP55xx common macros for code refactoring. >> >> > Documentation updates. >> >> > >> >> > You can also pull from the location below >> >> > This branch is based on 'for-next' of linux-leds. >> >> > >> >> > https://github.com/milokim/lp55xx.git >> >> > resolve-missing-sysfs >> >> >> >> Thanks, I've already merged the whole patchset in my -devel >> >> branch [1]. >> >> >> >> Pali, could you please help to test it on your hardware? >> >> Just grab my -devel branch and build then run. >> >> >> >> Thanks, >> >> -Bryan >> > >> > Hi, I see that all your patches are part of 3.12-rc5 kernel. >> > >> > Now I tested this example led program: >> > # Clearing LED-state to be sure >> > echo "disabled" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo >> > "disabled" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 >> > > /sys/class/leds/lp5523:r/brightness >> > echo 0 > /sys/class/leds/lp5523:g/brightness >> > echo 0 > /sys/class/leds/lp5523:b/brightness >> > >> > # Setting yellow light pattern and running it >> > echo "load" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo >> > "01100" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo >> > "9d804000427f0d7f7f007f004200" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo >> > "load" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo >> > "0" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo >> > "9d80" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo >> > "run" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo >> > "run" > >> > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo >> > 20 > /sys/class/leds/lp5523:r/led_current >> > echo 2 > /sys/class/leds/lp5523:g/led_current >> > echo 0 > /sys/class/leds/lp5523:b/led_current >> > >> > All sysfs entries exists and every echo returned 0. >> > >> > But led does not start blinking that yellow ligh pattern. >> > So it not working on 3.12-rc5 kernel :-( >> >> OK, great! Do you still remember which kernel version works on >> you system? Milo, do you have time to take a look? I bet it's >> a regression somewhere. >> >> Thanks, >> -Bryan > > I do not know which version. Now I tried pattern example from > Documentation/leds/leds-lp55xx.txt which using new API. > > echo 2 > /sys/class/i2c-adapter/i2c-2/2-0032/select_engine > echo 1 > /sys/class/firmware/lp5523/loading > echo "9d8044ff05ff437f" > /sys/class/firmware/lp5523/data > echo 0 > /sys/class/firmware/lp5523/loading > echo 1 > /sys/class/i2c-adapter/i2c-2/2-0032/run_engine > > But it failed at second command. In directory /sys/class/firmware/ > I have only one file with name timeout. Nothing more, no lp5523 > folder. > > Any idea who and when creating that lp5523 folder? Milo, Do you have time to take a look at this? Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Fri, Oct 25, 2013 at 11:21 AM, Pali Rohár pali.ro...@gmail.com wrote: On Friday 25 October 2013 19:10:07 Bryan Wu wrote: On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár pali.ro...@gmail.com wrote: On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim woogyom@gmail.com wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current All sysfs entries exists and every echo returned 0. But led does not start blinking that yellow ligh pattern. So it not working on 3.12-rc5 kernel :-( OK, great! Do you still remember which kernel version works on you system? Milo, do you have time to take a look? I bet it's a regression somewhere. Thanks, -Bryan I do not know which version. Now I tried pattern example from Documentation/leds/leds-lp55xx.txt which using new API. echo 2 /sys/class/i2c-adapter/i2c-2/2-0032/select_engine echo 1 /sys/class/firmware/lp5523/loading echo 9d8044ff05ff437f /sys/class/firmware/lp5523/data echo 0 /sys/class/firmware/lp5523/loading echo 1 /sys/class/i2c-adapter/i2c-2/2-0032/run_engine But it failed at second command. In directory /sys/class/firmware/ I have only one file with name timeout. Nothing more, no lp5523 folder. Any idea who and when creating that lp5523 folder? Milo, Do you have time to take a look at this? Thanks, -Bryan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Friday 25 October 2013 19:10:07 Bryan Wu wrote: > On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár wrote: > > On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: > >> On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim wrote: > >> > This patch-set resolves the application conflict by > >> > restoring sysfs files. > >> > > >> > For LP5521 > >> > > >> > engine1/2/3_mode > >> > engine1/2/3_load > >> > > >> > For LP5523 > >> > > >> > engine1/2/3_mode > >> > engine1/2/3_load > >> > engine1/2/3_leds > >> > > >> > Those attributes are accessed when LED pattern is run by > >> > custom application. Those were removed when LED pattern > >> > interface was changed to generic firmware interface. > >> > Please refer to commits below. > >> > > >> > git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 > >> > (leds-lp5521: use generic firmware interface) > >> > > >> > git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 > >> > (leds-lp5523: use generic firmware interface) > >> > > >> > Necessary attributes are restored in this patch-set. > >> > > >> > (Other changes) > >> > New data structure is added for handling values from/to > >> > an application. Few code fixes for reducing writing I2C > >> > commands. > >> > Add LP55xx common macros for code refactoring. > >> > Documentation updates. > >> > > >> > You can also pull from the location below > >> > This branch is based on 'for-next' of linux-leds. > >> > > >> > https://github.com/milokim/lp55xx.git > >> > resolve-missing-sysfs > >> > >> Thanks, I've already merged the whole patchset in my -devel > >> branch [1]. > >> > >> Pali, could you please help to test it on your hardware? > >> Just grab my -devel branch and build then run. > >> > >> Thanks, > >> -Bryan > > > > Hi, I see that all your patches are part of 3.12-rc5 kernel. > > > > Now I tested this example led program: > > # Clearing LED-state to be sure > > echo "disabled" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo > > "disabled" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 > > > /sys/class/leds/lp5523:r/brightness > > echo 0 > /sys/class/leds/lp5523:g/brightness > > echo 0 > /sys/class/leds/lp5523:b/brightness > > > > # Setting yellow light pattern and running it > > echo "load" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo > > "01100" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo > > "9d804000427f0d7f7f007f004200" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo > > "load" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo > > "0" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo > > "9d80" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo > > "run" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo > > "run" > > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo > > 20 > /sys/class/leds/lp5523:r/led_current > > echo 2 > /sys/class/leds/lp5523:g/led_current > > echo 0 > /sys/class/leds/lp5523:b/led_current > > > > All sysfs entries exists and every echo returned 0. > > > > But led does not start blinking that yellow ligh pattern. > > So it not working on 3.12-rc5 kernel :-( > > OK, great! Do you still remember which kernel version works on > you system? Milo, do you have time to take a look? I bet it's > a regression somewhere. > > Thanks, > -Bryan I do not know which version. Now I tried pattern example from Documentation/leds/leds-lp55xx.txt which using new API. echo 2 > /sys/class/i2c-adapter/i2c-2/2-0032/select_engine echo 1 > /sys/class/firmware/lp5523/loading echo "9d8044ff05ff437f" > /sys/class/firmware/lp5523/data echo 0 > /sys/class/firmware/lp5523/loading echo 1 > /sys/class/i2c-adapter/i2c-2/2-0032/run_engine But it failed at second command. In directory /sys/class/firmware/ I have only one file with name timeout. Nothing more, no lp5523 folder. Any idea who and when creating that lp5523 folder? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár wrote: > On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: >> On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim wrote: >> > This patch-set resolves the application conflict by >> > restoring sysfs files. >> > >> > For LP5521 >> > >> > engine1/2/3_mode >> > engine1/2/3_load >> > >> > For LP5523 >> > >> > engine1/2/3_mode >> > engine1/2/3_load >> > engine1/2/3_leds >> > >> > Those attributes are accessed when LED pattern is run by >> > custom application. Those were removed when LED pattern >> > interface was changed to generic firmware interface. Please >> > refer to commits below. >> > >> > git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 >> > (leds-lp5521: use generic firmware interface) >> > >> > git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 >> > (leds-lp5523: use generic firmware interface) >> > >> > Necessary attributes are restored in this patch-set. >> > >> > (Other changes) >> > New data structure is added for handling values from/to an >> > application. Few code fixes for reducing writing I2C >> > commands. >> > Add LP55xx common macros for code refactoring. >> > Documentation updates. >> > >> > You can also pull from the location below >> > This branch is based on 'for-next' of linux-leds. >> > >> > https://github.com/milokim/lp55xx.git >> > resolve-missing-sysfs >> >> Thanks, I've already merged the whole patchset in my -devel >> branch [1]. >> >> Pali, could you please help to test it on your hardware? Just >> grab my -devel branch and build then run. >> >> Thanks, >> -Bryan >> > > Hi, I see that all your patches are part of 3.12-rc5 kernel. > > Now I tested this example led program: > > # Clearing LED-state to be sure > echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo 0 > /sys/class/leds/lp5523:r/brightness > echo 0 > /sys/class/leds/lp5523:g/brightness > echo 0 > /sys/class/leds/lp5523:b/brightness > > # Setting yellow light pattern and running it > echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo "01100" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds > echo "9d804000427f0d7f7f007f004200" > > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load > echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo "0" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds > echo "9d80" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load > echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode > echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode > echo 20 > /sys/class/leds/lp5523:r/led_current > echo 2 > /sys/class/leds/lp5523:g/led_current > echo 0 > /sys/class/leds/lp5523:b/led_current > > All sysfs entries exists and every echo returned 0. > > But led does not start blinking that yellow ligh pattern. > So it not working on 3.12-rc5 kernel :-( > OK, great! Do you still remember which kernel version works on you system? Milo, do you have time to take a look? I bet it's a regression somewhere. Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: > On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim wrote: > > This patch-set resolves the application conflict by > > restoring sysfs files. > > > > For LP5521 > > > > engine1/2/3_mode > > engine1/2/3_load > > > > For LP5523 > > > > engine1/2/3_mode > > engine1/2/3_load > > engine1/2/3_leds > > > > Those attributes are accessed when LED pattern is run by > > custom application. Those were removed when LED pattern > > interface was changed to generic firmware interface. Please > > refer to commits below. > > > > git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 > > (leds-lp5521: use generic firmware interface) > > > > git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 > > (leds-lp5523: use generic firmware interface) > > > > Necessary attributes are restored in this patch-set. > > > > (Other changes) > > New data structure is added for handling values from/to an > > application. Few code fixes for reducing writing I2C > > commands. > > Add LP55xx common macros for code refactoring. > > Documentation updates. > > > > You can also pull from the location below > > This branch is based on 'for-next' of linux-leds. > > > > https://github.com/milokim/lp55xx.git > > resolve-missing-sysfs > > Thanks, I've already merged the whole patchset in my -devel > branch [1]. > > Pali, could you please help to test it on your hardware? Just > grab my -devel branch and build then run. > > Thanks, > -Bryan > Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 > /sys/class/leds/lp5523:r/brightness echo 0 > /sys/class/leds/lp5523:g/brightness echo 0 > /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo "01100" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo "9d804000427f0d7f7f007f004200" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo "0" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo "9d80" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 > /sys/class/leds/lp5523:r/led_current echo 2 > /sys/class/leds/lp5523:g/led_current echo 0 > /sys/class/leds/lp5523:b/led_current All sysfs entries exists and every echo returned 0. But led does not start blinking that yellow ligh pattern. So it not working on 3.12-rc5 kernel :-( -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim woogyom@gmail.com wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current All sysfs entries exists and every echo returned 0. But led does not start blinking that yellow ligh pattern. So it not working on 3.12-rc5 kernel :-( -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár pali.ro...@gmail.com wrote: On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim woogyom@gmail.com wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current All sysfs entries exists and every echo returned 0. But led does not start blinking that yellow ligh pattern. So it not working on 3.12-rc5 kernel :-( OK, great! Do you still remember which kernel version works on you system? Milo, do you have time to take a look? I bet it's a regression somewhere. Thanks, -Bryan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Friday 25 October 2013 19:10:07 Bryan Wu wrote: On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár pali.ro...@gmail.com wrote: On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim woogyom@gmail.com wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan Hi, I see that all your patches are part of 3.12-rc5 kernel. Now I tested this example led program: # Clearing LED-state to be sure echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo disabled /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/leds/lp5523:r/brightness echo 0 /sys/class/leds/lp5523:g/brightness echo 0 /sys/class/leds/lp5523:b/brightness # Setting yellow light pattern and running it echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 01100 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds echo 9d804000427f0d7f7f007f004200 /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load echo load /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo 0 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds echo 9d80 /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode echo run /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode echo 20 /sys/class/leds/lp5523:r/led_current echo 2 /sys/class/leds/lp5523:g/led_current echo 0 /sys/class/leds/lp5523:b/led_current All sysfs entries exists and every echo returned 0. But led does not start blinking that yellow ligh pattern. So it not working on 3.12-rc5 kernel :-( OK, great! Do you still remember which kernel version works on you system? Milo, do you have time to take a look? I bet it's a regression somewhere. Thanks, -Bryan I do not know which version. Now I tried pattern example from Documentation/leds/leds-lp55xx.txt which using new API. echo 2 /sys/class/i2c-adapter/i2c-2/2-0032/select_engine echo 1 /sys/class/firmware/lp5523/loading echo 9d8044ff05ff437f /sys/class/firmware/lp5523/data echo 0 /sys/class/firmware/lp5523/loading echo 1 /sys/class/i2c-adapter/i2c-2/2-0032/run_engine But it failed at second command. In directory /sys/class/firmware/ I have only one file with name timeout. Nothing more, no lp5523 folder. Any idea who and when creating that lp5523 folder? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim wrote: > This patch-set resolves the application conflict by restoring sysfs files. > > For LP5521 > engine1/2/3_mode > engine1/2/3_load > > For LP5523 > engine1/2/3_mode > engine1/2/3_load > engine1/2/3_leds > > Those attributes are accessed when LED pattern is run by custom application. > Those were removed when LED pattern interface was changed to generic firmware > interface. Please refer to commits below. > > git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 > (leds-lp5521: use generic firmware interface) > > git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 > (leds-lp5523: use generic firmware interface) > > Necessary attributes are restored in this patch-set. > > (Other changes) > New data structure is added for handling values from/to an application. > Few code fixes for reducing writing I2C commands. > Add LP55xx common macros for code refactoring. > Documentation updates. > > You can also pull from the location below > This branch is based on 'for-next' of linux-leds. > > https://github.com/milokim/lp55xx.git resolve-missing-sysfs > Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan [1]: http://git.kernel.org/cgit/linux/kernel/git/cooloney/linux-leds.git/log/?h=devel > Milo Kim (10): > leds: lp55xx: add common data structure for program > leds: lp55xx: add common macros for device attributes > leds: lp5521: restore legacy device attributes > leds: lp5521: remove unnecessary writing commands > leds: lp5523: make separate API for loading engine > leds: lp5523: LED MUX configuration on initializing > leds: lp5523: restore legacy device attributes > leds: lp5523: remove unnecessary writing commands > Documentation: leds-lp5521,lp5523: update device attribute > information > leds: lp5562: use LP55xx common macros for device attributes > > Documentation/leds/leds-lp5521.txt | 20 ++- > Documentation/leds/leds-lp5523.txt | 21 ++- > drivers/leds/leds-lp5521.c | 114 +++-- > drivers/leds/leds-lp5523.c | 321 > ++-- > drivers/leds/leds-lp5562.c |4 +- > drivers/leds/leds-lp55xx-common.h | 66 > 6 files changed, 511 insertions(+), 35 deletions(-) > > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim woogyom@gmail.com wrote: This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Thanks, I've already merged the whole patchset in my -devel branch [1]. Pali, could you please help to test it on your hardware? Just grab my -devel branch and build then run. Thanks, -Bryan [1]: http://git.kernel.org/cgit/linux/kernel/git/cooloney/linux-leds.git/log/?h=devel Milo Kim (10): leds: lp55xx: add common data structure for program leds: lp55xx: add common macros for device attributes leds: lp5521: restore legacy device attributes leds: lp5521: remove unnecessary writing commands leds: lp5523: make separate API for loading engine leds: lp5523: LED MUX configuration on initializing leds: lp5523: restore legacy device attributes leds: lp5523: remove unnecessary writing commands Documentation: leds-lp5521,lp5523: update device attribute information leds: lp5562: use LP55xx common macros for device attributes Documentation/leds/leds-lp5521.txt | 20 ++- Documentation/leds/leds-lp5523.txt | 21 ++- drivers/leds/leds-lp5521.c | 114 +++-- drivers/leds/leds-lp5523.c | 321 ++-- drivers/leds/leds-lp5562.c |4 +- drivers/leds/leds-lp55xx-common.h | 66 6 files changed, 511 insertions(+), 35 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Milo Kim (10): leds: lp55xx: add common data structure for program leds: lp55xx: add common macros for device attributes leds: lp5521: restore legacy device attributes leds: lp5521: remove unnecessary writing commands leds: lp5523: make separate API for loading engine leds: lp5523: LED MUX configuration on initializing leds: lp5523: restore legacy device attributes leds: lp5523: remove unnecessary writing commands Documentation: leds-lp5521,lp5523: update device attribute information leds: lp5562: use LP55xx common macros for device attributes Documentation/leds/leds-lp5521.txt | 20 ++- Documentation/leds/leds-lp5523.txt | 21 ++- drivers/leds/leds-lp5521.c | 114 +++-- drivers/leds/leds-lp5523.c | 321 ++-- drivers/leds/leds-lp5562.c |4 +- drivers/leds/leds-lp55xx-common.h | 66 6 files changed, 511 insertions(+), 35 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns
This patch-set resolves the application conflict by restoring sysfs files. For LP5521 engine1/2/3_mode engine1/2/3_load For LP5523 engine1/2/3_mode engine1/2/3_load engine1/2/3_leds Those attributes are accessed when LED pattern is run by custom application. Those were removed when LED pattern interface was changed to generic firmware interface. Please refer to commits below. git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328 (leds-lp5521: use generic firmware interface) git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 (leds-lp5523: use generic firmware interface) Necessary attributes are restored in this patch-set. (Other changes) New data structure is added for handling values from/to an application. Few code fixes for reducing writing I2C commands. Add LP55xx common macros for code refactoring. Documentation updates. You can also pull from the location below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Milo Kim (10): leds: lp55xx: add common data structure for program leds: lp55xx: add common macros for device attributes leds: lp5521: restore legacy device attributes leds: lp5521: remove unnecessary writing commands leds: lp5523: make separate API for loading engine leds: lp5523: LED MUX configuration on initializing leds: lp5523: restore legacy device attributes leds: lp5523: remove unnecessary writing commands Documentation: leds-lp5521,lp5523: update device attribute information leds: lp5562: use LP55xx common macros for device attributes Documentation/leds/leds-lp5521.txt | 20 ++- Documentation/leds/leds-lp5523.txt | 21 ++- drivers/leds/leds-lp5521.c | 114 +++-- drivers/leds/leds-lp5523.c | 321 ++-- drivers/leds/leds-lp5562.c |4 +- drivers/leds/leds-lp55xx-common.h | 66 6 files changed, 511 insertions(+), 35 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
