Re: [PATCH 00/11] HID: spring cleaning
On Mon, Feb 3, 2014 at 11:48 AM, David Herrmann wrote: > Hi > > On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires > wrote: >> Hi guys, >> >> This is an attempt to complete the branch for-3.15/ll-driver-new-callbacks: >> - try to implement as much as possible ll_driver callbacks (some are still >> missing, but I did not had the time to complete it) >> - add inliners hid_hw_* for all the ll_driver callbacks >> - remove transport dependant callbacks in struct hid_device >> - remove the so called "obsolete" hidinput_input_event handler which was used >> in 2/4 transport drivers >> >> Bonus point: 14 files changed, 213 insertions(+), 272 deletions(-) >> Yay! >> >> I made sure I kept the PS3 controller working and the LEDs (on logitech-dj >> and >> on bluetooth keyboard) working. The rest do not mostly need further testing, >> the code path did not changed. But still, a review (and some tests) would be >> a >> good idea :) > > Thanks a lot! Looks all good except for the uhid and i2c changes. But > I have commented on those. Thanks David for the review. Very appreciated. Jiri, I think the simpler way to handle this is that I send out a v2 of the patches with the reviewed-by David: I will drop 1, 2 and 11 and rework a little on 4 (hid-logitech-dj). Then, I'll send out the second series where I will remove hid_output_raw_report, implement a generic .request() on top of .raw_request(), and I have some more cleanup to come (less aggressive this time I think). Cheers, Benjamin > > Cheers > David > >> Cheers, >> Benjamin >> >> PS: obviously, this goes on top on the branch >> for-3.15/ll-driver-new-callbacks >> >> Benjamin Tissoires (11): >> HID: uHID: implement .raw_request >> HID: i2c-hid: implement ll_driver transport-layer callbacks >> HID: add inliners for ll_driver transport-layer callbacks >> HID: logitech-dj: remove hidinput_input_event >> HID: HIDp: remove hidp_hidinput_event >> HID: remove hidinput_input_event handler >> HID: HIDp: remove duplicated coded >> HID: usbhid: remove duplicated code >> HID: remove hid_get_raw_report in struct hid_device >> HID: introduce helper to access hid_output_raw_report() >> HID: move hid_output_raw_report to hid_ll_driver >> >> drivers/hid/hid-input.c| 12 ++--- >> drivers/hid/hid-lg.c | 6 ++- >> drivers/hid/hid-logitech-dj.c | 101 +- >> drivers/hid/hid-magicmouse.c | 2 +- >> drivers/hid/hid-sony.c | 19 +-- >> drivers/hid/hid-thingm.c | 4 +- >> drivers/hid/hid-wacom.c| 16 +++--- >> drivers/hid/hid-wiimote-core.c | 4 +- >> drivers/hid/hidraw.c | 11 ++-- >> drivers/hid/i2c-hid/i2c-hid.c | 27 +- >> drivers/hid/uhid.c | 20 ++- >> drivers/hid/usbhid/hid-core.c | 67 +-- >> include/linux/hid.h| 77 ++ >> net/bluetooth/hidp/core.c | 119 >> + >> 14 files changed, 213 insertions(+), 272 deletions(-) >> >> -- >> 1.8.3.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/11] HID: spring cleaning
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires wrote: > Hi guys, > > This is an attempt to complete the branch for-3.15/ll-driver-new-callbacks: > - try to implement as much as possible ll_driver callbacks (some are still > missing, but I did not had the time to complete it) > - add inliners hid_hw_* for all the ll_driver callbacks > - remove transport dependant callbacks in struct hid_device > - remove the so called "obsolete" hidinput_input_event handler which was used > in 2/4 transport drivers > > Bonus point: 14 files changed, 213 insertions(+), 272 deletions(-) > Yay! > > I made sure I kept the PS3 controller working and the LEDs (on logitech-dj and > on bluetooth keyboard) working. The rest do not mostly need further testing, > the code path did not changed. But still, a review (and some tests) would be a > good idea :) Thanks a lot! Looks all good except for the uhid and i2c changes. But I have commented on those. Cheers David > Cheers, > Benjamin > > PS: obviously, this goes on top on the branch for-3.15/ll-driver-new-callbacks > > Benjamin Tissoires (11): > HID: uHID: implement .raw_request > HID: i2c-hid: implement ll_driver transport-layer callbacks > HID: add inliners for ll_driver transport-layer callbacks > HID: logitech-dj: remove hidinput_input_event > HID: HIDp: remove hidp_hidinput_event > HID: remove hidinput_input_event handler > HID: HIDp: remove duplicated coded > HID: usbhid: remove duplicated code > HID: remove hid_get_raw_report in struct hid_device > HID: introduce helper to access hid_output_raw_report() > HID: move hid_output_raw_report to hid_ll_driver > > drivers/hid/hid-input.c| 12 ++--- > drivers/hid/hid-lg.c | 6 ++- > drivers/hid/hid-logitech-dj.c | 101 +- > drivers/hid/hid-magicmouse.c | 2 +- > drivers/hid/hid-sony.c | 19 +-- > drivers/hid/hid-thingm.c | 4 +- > drivers/hid/hid-wacom.c| 16 +++--- > drivers/hid/hid-wiimote-core.c | 4 +- > drivers/hid/hidraw.c | 11 ++-- > drivers/hid/i2c-hid/i2c-hid.c | 27 +- > drivers/hid/uhid.c | 20 ++- > drivers/hid/usbhid/hid-core.c | 67 +-- > include/linux/hid.h| 77 ++ > net/bluetooth/hidp/core.c | 119 > + > 14 files changed, 213 insertions(+), 272 deletions(-) > > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/11] HID: spring cleaning
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi guys, This is an attempt to complete the branch for-3.15/ll-driver-new-callbacks: - try to implement as much as possible ll_driver callbacks (some are still missing, but I did not had the time to complete it) - add inliners hid_hw_* for all the ll_driver callbacks - remove transport dependant callbacks in struct hid_device - remove the so called obsolete hidinput_input_event handler which was used in 2/4 transport drivers Bonus point: 14 files changed, 213 insertions(+), 272 deletions(-) Yay! I made sure I kept the PS3 controller working and the LEDs (on logitech-dj and on bluetooth keyboard) working. The rest do not mostly need further testing, the code path did not changed. But still, a review (and some tests) would be a good idea :) Thanks a lot! Looks all good except for the uhid and i2c changes. But I have commented on those. Cheers David Cheers, Benjamin PS: obviously, this goes on top on the branch for-3.15/ll-driver-new-callbacks Benjamin Tissoires (11): HID: uHID: implement .raw_request HID: i2c-hid: implement ll_driver transport-layer callbacks HID: add inliners for ll_driver transport-layer callbacks HID: logitech-dj: remove hidinput_input_event HID: HIDp: remove hidp_hidinput_event HID: remove hidinput_input_event handler HID: HIDp: remove duplicated coded HID: usbhid: remove duplicated code HID: remove hid_get_raw_report in struct hid_device HID: introduce helper to access hid_output_raw_report() HID: move hid_output_raw_report to hid_ll_driver drivers/hid/hid-input.c| 12 ++--- drivers/hid/hid-lg.c | 6 ++- drivers/hid/hid-logitech-dj.c | 101 +- drivers/hid/hid-magicmouse.c | 2 +- drivers/hid/hid-sony.c | 19 +-- drivers/hid/hid-thingm.c | 4 +- drivers/hid/hid-wacom.c| 16 +++--- drivers/hid/hid-wiimote-core.c | 4 +- drivers/hid/hidraw.c | 11 ++-- drivers/hid/i2c-hid/i2c-hid.c | 27 +- drivers/hid/uhid.c | 20 ++- drivers/hid/usbhid/hid-core.c | 67 +-- include/linux/hid.h| 77 ++ net/bluetooth/hidp/core.c | 119 + 14 files changed, 213 insertions(+), 272 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/11] HID: spring cleaning
On Mon, Feb 3, 2014 at 11:48 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi guys, This is an attempt to complete the branch for-3.15/ll-driver-new-callbacks: - try to implement as much as possible ll_driver callbacks (some are still missing, but I did not had the time to complete it) - add inliners hid_hw_* for all the ll_driver callbacks - remove transport dependant callbacks in struct hid_device - remove the so called obsolete hidinput_input_event handler which was used in 2/4 transport drivers Bonus point: 14 files changed, 213 insertions(+), 272 deletions(-) Yay! I made sure I kept the PS3 controller working and the LEDs (on logitech-dj and on bluetooth keyboard) working. The rest do not mostly need further testing, the code path did not changed. But still, a review (and some tests) would be a good idea :) Thanks a lot! Looks all good except for the uhid and i2c changes. But I have commented on those. Thanks David for the review. Very appreciated. Jiri, I think the simpler way to handle this is that I send out a v2 of the patches with the reviewed-by David: I will drop 1, 2 and 11 and rework a little on 4 (hid-logitech-dj). Then, I'll send out the second series where I will remove hid_output_raw_report, implement a generic .request() on top of .raw_request(), and I have some more cleanup to come (less aggressive this time I think). Cheers, Benjamin Cheers David Cheers, Benjamin PS: obviously, this goes on top on the branch for-3.15/ll-driver-new-callbacks Benjamin Tissoires (11): HID: uHID: implement .raw_request HID: i2c-hid: implement ll_driver transport-layer callbacks HID: add inliners for ll_driver transport-layer callbacks HID: logitech-dj: remove hidinput_input_event HID: HIDp: remove hidp_hidinput_event HID: remove hidinput_input_event handler HID: HIDp: remove duplicated coded HID: usbhid: remove duplicated code HID: remove hid_get_raw_report in struct hid_device HID: introduce helper to access hid_output_raw_report() HID: move hid_output_raw_report to hid_ll_driver drivers/hid/hid-input.c| 12 ++--- drivers/hid/hid-lg.c | 6 ++- drivers/hid/hid-logitech-dj.c | 101 +- drivers/hid/hid-magicmouse.c | 2 +- drivers/hid/hid-sony.c | 19 +-- drivers/hid/hid-thingm.c | 4 +- drivers/hid/hid-wacom.c| 16 +++--- drivers/hid/hid-wiimote-core.c | 4 +- drivers/hid/hidraw.c | 11 ++-- drivers/hid/i2c-hid/i2c-hid.c | 27 +- drivers/hid/uhid.c | 20 ++- drivers/hid/usbhid/hid-core.c | 67 +-- include/linux/hid.h| 77 ++ net/bluetooth/hidp/core.c | 119 + 14 files changed, 213 insertions(+), 272 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/11] HID: spring cleaning
Hi guys, This is an attempt to complete the branch for-3.15/ll-driver-new-callbacks: - try to implement as much as possible ll_driver callbacks (some are still missing, but I did not had the time to complete it) - add inliners hid_hw_* for all the ll_driver callbacks - remove transport dependant callbacks in struct hid_device - remove the so called "obsolete" hidinput_input_event handler which was used in 2/4 transport drivers Bonus point: 14 files changed, 213 insertions(+), 272 deletions(-) Yay! I made sure I kept the PS3 controller working and the LEDs (on logitech-dj and on bluetooth keyboard) working. The rest do not mostly need further testing, the code path did not changed. But still, a review (and some tests) would be a good idea :) Cheers, Benjamin PS: obviously, this goes on top on the branch for-3.15/ll-driver-new-callbacks Benjamin Tissoires (11): HID: uHID: implement .raw_request HID: i2c-hid: implement ll_driver transport-layer callbacks HID: add inliners for ll_driver transport-layer callbacks HID: logitech-dj: remove hidinput_input_event HID: HIDp: remove hidp_hidinput_event HID: remove hidinput_input_event handler HID: HIDp: remove duplicated coded HID: usbhid: remove duplicated code HID: remove hid_get_raw_report in struct hid_device HID: introduce helper to access hid_output_raw_report() HID: move hid_output_raw_report to hid_ll_driver drivers/hid/hid-input.c| 12 ++--- drivers/hid/hid-lg.c | 6 ++- drivers/hid/hid-logitech-dj.c | 101 +- drivers/hid/hid-magicmouse.c | 2 +- drivers/hid/hid-sony.c | 19 +-- drivers/hid/hid-thingm.c | 4 +- drivers/hid/hid-wacom.c| 16 +++--- drivers/hid/hid-wiimote-core.c | 4 +- drivers/hid/hidraw.c | 11 ++-- drivers/hid/i2c-hid/i2c-hid.c | 27 +- drivers/hid/uhid.c | 20 ++- drivers/hid/usbhid/hid-core.c | 67 +-- include/linux/hid.h| 77 ++ net/bluetooth/hidp/core.c | 119 + 14 files changed, 213 insertions(+), 272 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/11] HID: spring cleaning
Hi guys, This is an attempt to complete the branch for-3.15/ll-driver-new-callbacks: - try to implement as much as possible ll_driver callbacks (some are still missing, but I did not had the time to complete it) - add inliners hid_hw_* for all the ll_driver callbacks - remove transport dependant callbacks in struct hid_device - remove the so called obsolete hidinput_input_event handler which was used in 2/4 transport drivers Bonus point: 14 files changed, 213 insertions(+), 272 deletions(-) Yay! I made sure I kept the PS3 controller working and the LEDs (on logitech-dj and on bluetooth keyboard) working. The rest do not mostly need further testing, the code path did not changed. But still, a review (and some tests) would be a good idea :) Cheers, Benjamin PS: obviously, this goes on top on the branch for-3.15/ll-driver-new-callbacks Benjamin Tissoires (11): HID: uHID: implement .raw_request HID: i2c-hid: implement ll_driver transport-layer callbacks HID: add inliners for ll_driver transport-layer callbacks HID: logitech-dj: remove hidinput_input_event HID: HIDp: remove hidp_hidinput_event HID: remove hidinput_input_event handler HID: HIDp: remove duplicated coded HID: usbhid: remove duplicated code HID: remove hid_get_raw_report in struct hid_device HID: introduce helper to access hid_output_raw_report() HID: move hid_output_raw_report to hid_ll_driver drivers/hid/hid-input.c| 12 ++--- drivers/hid/hid-lg.c | 6 ++- drivers/hid/hid-logitech-dj.c | 101 +- drivers/hid/hid-magicmouse.c | 2 +- drivers/hid/hid-sony.c | 19 +-- drivers/hid/hid-thingm.c | 4 +- drivers/hid/hid-wacom.c| 16 +++--- drivers/hid/hid-wiimote-core.c | 4 +- drivers/hid/hidraw.c | 11 ++-- drivers/hid/i2c-hid/i2c-hid.c | 27 +- drivers/hid/uhid.c | 20 ++- drivers/hid/usbhid/hid-core.c | 67 +-- include/linux/hid.h| 77 ++ net/bluetooth/hidp/core.c | 119 + 14 files changed, 213 insertions(+), 272 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
