Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.
On 04/08/17 11:22, Arvind Yadav wrote: Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: Hi Arwind, These files were generated by a script maintained in this repository : https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py It would best to update this script first to make sure future platforms get the fixes too. Some changes have just been merged, deleted most configs but the test ones. You'll need to update your series. I have done the changes. Please review it. :) Shared patch is 0001-i915-perf-kernelgen.py-constify-attribute_group-stru.patch. Hm... Where is it? (I can't see it on the mailing list nor attached) The best would be to submit a PR on the github project directly. Otherwise it looks like a good change. Thanks, - Lionel On 04/08/17 06:03, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group structures. [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group structures. [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group structures. [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group structures. [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group structures. [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group structures. [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures. [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group structures. [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group structures. [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group structures. [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group structures. drivers/gpu/drm/i915/i915_oa_bdw.c| 44 +-- drivers/gpu/drm/i915/i915_oa_bxt.c| 30 drivers/gpu/drm/i915/i915_oa_chv.c| 28 +++--- drivers/gpu/drm/i915/i915_oa_glk.c| 30 drivers/gpu/drm/i915/i915_oa_hsw.c| 12 +- drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 ++-- drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- 11 files changed, 165 insertions(+), 165 deletions(-) ~arvind
Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.
On 04/08/17 11:22, Arvind Yadav wrote: Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: Hi Arwind, These files were generated by a script maintained in this repository : https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py It would best to update this script first to make sure future platforms get the fixes too. Some changes have just been merged, deleted most configs but the test ones. You'll need to update your series. I have done the changes. Please review it. :) Shared patch is 0001-i915-perf-kernelgen.py-constify-attribute_group-stru.patch. Hm... Where is it? (I can't see it on the mailing list nor attached) The best would be to submit a PR on the github project directly. Otherwise it looks like a good change. Thanks, - Lionel On 04/08/17 06:03, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group structures. [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group structures. [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group structures. [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group structures. [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group structures. [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group structures. [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures. [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group structures. [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group structures. [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group structures. [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group structures. drivers/gpu/drm/i915/i915_oa_bdw.c| 44 +-- drivers/gpu/drm/i915/i915_oa_bxt.c| 30 drivers/gpu/drm/i915/i915_oa_chv.c| 28 +++--- drivers/gpu/drm/i915/i915_oa_glk.c| 30 drivers/gpu/drm/i915/i915_oa_hsw.c| 12 +- drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 ++-- drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- 11 files changed, 165 insertions(+), 165 deletions(-) ~arvind
Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.
Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: Hi Arwind, These files were generated by a script maintained in this repository : https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py It would best to update this script first to make sure future platforms get the fixes too. Some changes have just been merged, deleted most configs but the test ones. You'll need to update your series. I have done the changes. Please review it. :) Shared patch is 0001-i915-perf-kernelgen.py-constify-attribute_group-stru.patch. Otherwise it looks like a good change. Thanks, - Lionel On 04/08/17 06:03, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group structures. [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group structures. [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group structures. [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group structures. [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group structures. [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group structures. [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures. [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group structures. [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group structures. [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group structures. [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group structures. drivers/gpu/drm/i915/i915_oa_bdw.c| 44 +-- drivers/gpu/drm/i915/i915_oa_bxt.c| 30 drivers/gpu/drm/i915/i915_oa_chv.c| 28 +++--- drivers/gpu/drm/i915/i915_oa_glk.c| 30 drivers/gpu/drm/i915/i915_oa_hsw.c| 12 +- drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 ++-- drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- 11 files changed, 165 insertions(+), 165 deletions(-) ~arvind
Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.
Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: Hi Arwind, These files were generated by a script maintained in this repository : https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py It would best to update this script first to make sure future platforms get the fixes too. Some changes have just been merged, deleted most configs but the test ones. You'll need to update your series. I have done the changes. Please review it. :) Shared patch is 0001-i915-perf-kernelgen.py-constify-attribute_group-stru.patch. Otherwise it looks like a good change. Thanks, - Lionel On 04/08/17 06:03, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group structures. [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group structures. [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group structures. [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group structures. [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group structures. [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group structures. [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures. [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group structures. [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group structures. [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group structures. [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group structures. drivers/gpu/drm/i915/i915_oa_bdw.c| 44 +-- drivers/gpu/drm/i915/i915_oa_bxt.c| 30 drivers/gpu/drm/i915/i915_oa_chv.c| 28 +++--- drivers/gpu/drm/i915/i915_oa_glk.c| 30 drivers/gpu/drm/i915/i915_oa_hsw.c| 12 +- drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 ++-- drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- 11 files changed, 165 insertions(+), 165 deletions(-) ~arvind
Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.
Hi Arwind, These files were generated by a script maintained in this repository : https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py It would best to update this script first to make sure future platforms get the fixes too. Some changes have just been merged, deleted most configs but the test ones. You'll need to update your series. Otherwise it looks like a good change. Thanks, - Lionel On 04/08/17 06:03, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group structures. [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group structures. [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group structures. [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group structures. [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group structures. [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group structures. [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures. [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group structures. [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group structures. [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group structures. [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group structures. drivers/gpu/drm/i915/i915_oa_bdw.c| 44 +-- drivers/gpu/drm/i915/i915_oa_bxt.c| 30 drivers/gpu/drm/i915/i915_oa_chv.c| 28 +++--- drivers/gpu/drm/i915/i915_oa_glk.c| 30 drivers/gpu/drm/i915/i915_oa_hsw.c| 12 +- drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 ++-- drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- 11 files changed, 165 insertions(+), 165 deletions(-)
Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.
Hi Arwind, These files were generated by a script maintained in this repository : https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py It would best to update this script first to make sure future platforms get the fixes too. Some changes have just been merged, deleted most configs but the test ones. You'll need to update your series. Otherwise it looks like a good change. Thanks, - Lionel On 04/08/17 06:03, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group structures. [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group structures. [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group structures. [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group structures. [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group structures. [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group structures. [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures. [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group structures. [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group structures. [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group structures. [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group structures. drivers/gpu/drm/i915/i915_oa_bdw.c| 44 +-- drivers/gpu/drm/i915/i915_oa_bxt.c| 30 drivers/gpu/drm/i915/i915_oa_chv.c| 28 +++--- drivers/gpu/drm/i915/i915_oa_glk.c| 30 drivers/gpu/drm/i915/i915_oa_hsw.c| 12 +- drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 ++-- drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- 11 files changed, 165 insertions(+), 165 deletions(-)
[PATCH 00/11] constify i915 attribute_group structures.
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group structures. [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group structures. [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group structures. [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group structures. [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group structures. [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group structures. [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures. [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group structures. [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group structures. [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group structures. [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group structures. drivers/gpu/drm/i915/i915_oa_bdw.c| 44 +-- drivers/gpu/drm/i915/i915_oa_bxt.c| 30 drivers/gpu/drm/i915/i915_oa_chv.c| 28 +++--- drivers/gpu/drm/i915/i915_oa_glk.c| 30 drivers/gpu/drm/i915/i915_oa_hsw.c| 12 +- drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 ++-- drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- 11 files changed, 165 insertions(+), 165 deletions(-) -- 1.9.1
[PATCH 00/11] constify i915 attribute_group structures.
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group structures. [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group structures. [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group structures. [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group structures. [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group structures. [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group structures. [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures. [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group structures. [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group structures. [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group structures. [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group structures. drivers/gpu/drm/i915/i915_oa_bdw.c| 44 +-- drivers/gpu/drm/i915/i915_oa_bxt.c| 30 drivers/gpu/drm/i915/i915_oa_chv.c| 28 +++--- drivers/gpu/drm/i915/i915_oa_glk.c| 30 drivers/gpu/drm/i915/i915_oa_hsw.c| 12 +- drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 ++-- drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 ++-- drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- 11 files changed, 165 insertions(+), 165 deletions(-) -- 1.9.1
