Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion
On Tue, 17 Jul 2007 23:04:04 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > This is a refresh of an on-going work-in-progress: convert the last > remaining users of pci_find_device() to the ISA/PCI/etc. hotplug APIs > now in standard use. After SCSI's gdth, ISDN's HiSax suite of drivers > are just about the last place using the older API. > > A few rough edges remain, and I'm not sure how much of ISDN userland > will explode (I have no ISDN hardware, nor much want any:)), but this > should get us almost all the way there. > > The patches are diff'd against 2.6.25-rc1. > > Comments/review/testing welcome. Especially "it works" or "its dead" > testing. When `make modules_install' runs depmod using http://userweb.kernel.org/~akpm/config-akpm2.txt these patches cause this: WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/teles_cs.ko ignored, due to loop WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/hisax_st5481.ko ignored, due to loop WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/elsa_cs.ko ignored, due to loop WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/hfc4s8s_l1.ko ignored, due to loop WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/hisax_isac.ko ignored, due to loop WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/avma1_cs.ko ignored, due to loop WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/libhisax.ko ignored, due to loop WARNING: Loop detected: /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/hisax.ko needs libhisax.ko which needs hisax.ko again! WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/hisax.ko ignored, due to loop WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/sedlbauer_cs.ko ignored, due to loop WARNING: Module /lib/modules/2.6.25-rc2-mm1/kernel/drivers/isdn/hisax/hisax_fcpcipnp.ko ignored, due to loop -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion
> > > >Just ran checkpatch for the fun of it: > >total: 28 errors, 86 warnings, 4896 lines checked > >Most looks easy to fix. > > I'll take a look... if its checkpatch stuff I caused, I'm happy to fix it. > > But I'm trying to avoid cleanups for pre-existing conditions, i.e. > flagged by checkpatch only because I moved existing code to a new location. > > Down that path lies madness and way too much work :) I didn't sign on > to clean up ISDN :) > > Anyway, thanks for the multiple comments, they will be taken into > account in the next update of these patches. I was distracted when halfdone - but I assume that I would just repeated myself for the rest of the drivers. When you post an updated version I will try to take a little bit deeper look. I did not get the full picture of the libification you have made in hisax. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion
Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 11:04:04PM -0400, Jeff Garzik wrote: This is a refresh of an on-going work-in-progress: convert the last remaining users of pci_find_device() to the ISA/PCI/etc. hotplug APIs now in standard use. After SCSI's gdth, ISDN's HiSax suite of drivers are just about the last place using the older API. A few rough edges remain, and I'm not sure how much of ISDN userland will explode (I have no ISDN hardware, nor much want any:)), but this should get us almost all the way there. The patches are diff'd against 2.6.25-rc1. Comments/review/testing welcome. Especially "it works" or "its dead" testing. Just ran checkpatch for the fun of it: total: 28 errors, 86 warnings, 4896 lines checked Most looks easy to fix. I'll take a look... if its checkpatch stuff I caused, I'm happy to fix it. But I'm trying to avoid cleanups for pre-existing conditions, i.e. flagged by checkpatch only because I moved existing code to a new location. Down that path lies madness and way too much work :) I didn't sign on to clean up ISDN :) Anyway, thanks for the multiple comments, they will be taken into account in the next update of these patches. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion
On Tue, Jul 17, 2007 at 11:04:04PM -0400, Jeff Garzik wrote: > > This is a refresh of an on-going work-in-progress: convert the last > remaining users of pci_find_device() to the ISA/PCI/etc. hotplug APIs > now in standard use. After SCSI's gdth, ISDN's HiSax suite of drivers > are just about the last place using the older API. > > A few rough edges remain, and I'm not sure how much of ISDN userland > will explode (I have no ISDN hardware, nor much want any:)), but this > should get us almost all the way there. > > The patches are diff'd against 2.6.25-rc1. > > Comments/review/testing welcome. Especially "it works" or "its dead" > testing. Just ran checkpatch for the fun of it: total: 28 errors, 86 warnings, 4896 lines checked Most looks easy to fix. Anyone with minimal interest in isdn could do so - hint! Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion
Apologies to those who missed this patchset... it carried the original patch creation date (July 2007). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion
Greg KH wrote: I have some patches in my pci tree to get rid of some pci_find_slot() usages, as well, so we are almost rid of these old functions. Good... I was avoiding that area, silently hoping that someone else would handle that part for me :) Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion
On Tue, Jul 17, 2007 at 11:04:04PM -0400, Jeff Garzik wrote: > > This is a refresh of an on-going work-in-progress: convert the last > remaining users of pci_find_device() to the ISA/PCI/etc. hotplug APIs > now in standard use. After SCSI's gdth, ISDN's HiSax suite of drivers > are just about the last place using the older API. Yeah! I have some patches in my pci tree to get rid of some pci_find_slot() usages, as well, so we are almost rid of these old functions. Thanks a lot for doing this work, I really appreciate it. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/14] [ISDN] HiSax hotplug conversion
This is a refresh of an on-going work-in-progress: convert the last remaining users of pci_find_device() to the ISA/PCI/etc. hotplug APIs now in standard use. After SCSI's gdth, ISDN's HiSax suite of drivers are just about the last place using the older API. A few rough edges remain, and I'm not sure how much of ISDN userland will explode (I have no ISDN hardware, nor much want any:)), but this should get us almost all the way there. The patches are diff'd against 2.6.25-rc1. Comments/review/testing welcome. Especially "it works" or "its dead" testing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
