Re: [PATCH 00/16] CSI2RX support on J721E
On Wed, Mar 31, 2021 at 03:03:51PM +0530, Vinod Koul wrote: > On 30-03-21, 23:03, Pratyush Yadav wrote: > > Hi, > > > > This series adds support for CSI2 capture on J721E. It includes some > > fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY > > driver, and finally adds the TI CSI2RX wrapper driver. > > > > Tested on TI's J721E with OV5640 sensor. > > > > Paul Kocialkowski (1): > > phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes > > > > Pratyush Yadav (15): > > phy: cdns-dphy: Prepare for Rx support > > phy: cdns-dphy: Allow setting mode > > phy: cdns-dphy: Add Rx support > > media: cadence: csi2rx: Add external DPHY support > > media: cadence: csi2rx: Soft reset the streams before starting capture > > media: cadence: csi2rx: Set the STOP bit when stopping a stream > > media: cadence: csi2rx: Fix stream data configuration > > media: cadence: csi2rx: Turn subdev power on before starting stream > > media: cadence: csi2rx: Add wrappers for subdev calls > > dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX > > dt-bindings: media: Add DT bindings for TI CSI2RX driver > > media: ti-vpe: csi2rx: Add CSI2RX support > > dt-bindings: phy: Convert Cadence DPHY binding to YAML > > dt-bindings: phy: cdns,dphy: make clocks optional > > dt-bindings: phy: cdns,dphy: add power-domains property > > Is there any dependency between patches to various subsystems, if not > please do consider sending a series per subsystem... Splitting the series per subsystem will facilitate merging, but for the first versions, keeping all patches together facilitate review. I'd prefer if we could have a v2 that still includes everything, until we agree on the interface between the two subsystems. At that point, we can split the series if needed. > > > > .../devicetree/bindings/media/ti,csi2rx.yaml | 70 ++ > > .../devicetree/bindings/phy/cdns,dphy.txt | 20 - > > .../devicetree/bindings/phy/cdns,dphy.yaml| 52 + > > MAINTAINERS | 7 + > > drivers/dma/ti/k3-psil-j721e.c| 10 + > > drivers/media/platform/Kconfig| 11 + > > drivers/media/platform/cadence/cdns-csi2rx.c | 269 - > > drivers/media/platform/ti-vpe/Makefile| 1 + > > drivers/media/platform/ti-vpe/ti-csi2rx.c | 964 ++ > > drivers/phy/cadence/cdns-dphy.c | 407 +++- > > include/linux/phy/phy-mipi-dphy.h | 13 + > > 11 files changed, 1754 insertions(+), 70 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/media/ti,csi2rx.yaml > > delete mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.txt > > create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.yaml > > create mode 100644 drivers/media/platform/ti-vpe/ti-csi2rx.c -- Regards, Laurent Pinchart
Re: [PATCH 00/16] CSI2RX support on J721E
On 31/03/21 06:36PM, Vinod Koul wrote: > On 31-03-21, 17:10, Pratyush Yadav wrote: > > On 31/03/21 03:03PM, Vinod Koul wrote: > > > On 30-03-21, 23:03, Pratyush Yadav wrote: > > > > Hi, > > > > > > > > This series adds support for CSI2 capture on J721E. It includes some > > > > fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY > > > > driver, and finally adds the TI CSI2RX wrapper driver. > > > > > > > > Tested on TI's J721E with OV5640 sensor. > > > > > > > > Paul Kocialkowski (1): > > > > phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes > > > > > > > > Pratyush Yadav (15): > > > > phy: cdns-dphy: Prepare for Rx support > > > > phy: cdns-dphy: Allow setting mode > > > > phy: cdns-dphy: Add Rx support > > > > media: cadence: csi2rx: Add external DPHY support > > > > media: cadence: csi2rx: Soft reset the streams before starting capture > > > > media: cadence: csi2rx: Set the STOP bit when stopping a stream > > > > media: cadence: csi2rx: Fix stream data configuration > > > > media: cadence: csi2rx: Turn subdev power on before starting stream > > > > media: cadence: csi2rx: Add wrappers for subdev calls > > > > dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX > > > > dt-bindings: media: Add DT bindings for TI CSI2RX driver > > > > media: ti-vpe: csi2rx: Add CSI2RX support > > > > dt-bindings: phy: Convert Cadence DPHY binding to YAML > > > > dt-bindings: phy: cdns,dphy: make clocks optional > > > > dt-bindings: phy: cdns,dphy: add power-domains property > > > > > > Is there any dependency between patches to various subsystems, if not > > > please do consider sending a series per subsystem... > > > > Without patch 1, patch 5 and later won't build. Without patch 11, patch > > 13 will not work. > > Cover letter is a good place to mention this! And what do you mean by > not working, do we have compile time dependencies? I agree that for > everything to work all the pieces need to land I have not tried it but patch 11 is not a compile time dependency. It should be a run time dependency. Without it the driver will probably fail to acquire the DMA channels and its probe will fail. -- Regards, Pratyush Yadav Texas Instruments Inc.
Re: [PATCH 00/16] CSI2RX support on J721E
On 31-03-21, 17:10, Pratyush Yadav wrote: > On 31/03/21 03:03PM, Vinod Koul wrote: > > On 30-03-21, 23:03, Pratyush Yadav wrote: > > > Hi, > > > > > > This series adds support for CSI2 capture on J721E. It includes some > > > fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY > > > driver, and finally adds the TI CSI2RX wrapper driver. > > > > > > Tested on TI's J721E with OV5640 sensor. > > > > > > Paul Kocialkowski (1): > > > phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes > > > > > > Pratyush Yadav (15): > > > phy: cdns-dphy: Prepare for Rx support > > > phy: cdns-dphy: Allow setting mode > > > phy: cdns-dphy: Add Rx support > > > media: cadence: csi2rx: Add external DPHY support > > > media: cadence: csi2rx: Soft reset the streams before starting capture > > > media: cadence: csi2rx: Set the STOP bit when stopping a stream > > > media: cadence: csi2rx: Fix stream data configuration > > > media: cadence: csi2rx: Turn subdev power on before starting stream > > > media: cadence: csi2rx: Add wrappers for subdev calls > > > dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX > > > dt-bindings: media: Add DT bindings for TI CSI2RX driver > > > media: ti-vpe: csi2rx: Add CSI2RX support > > > dt-bindings: phy: Convert Cadence DPHY binding to YAML > > > dt-bindings: phy: cdns,dphy: make clocks optional > > > dt-bindings: phy: cdns,dphy: add power-domains property > > > > Is there any dependency between patches to various subsystems, if not > > please do consider sending a series per subsystem... > > Without patch 1, patch 5 and later won't build. Without patch 11, patch > 13 will not work. Cover letter is a good place to mention this! And what do you mean by not working, do we have compile time dependencies? I agree that for everything to work all the pieces need to land -- ~Vinod
Re: [PATCH 00/16] CSI2RX support on J721E
On 31/03/21 03:03PM, Vinod Koul wrote: > On 30-03-21, 23:03, Pratyush Yadav wrote: > > Hi, > > > > This series adds support for CSI2 capture on J721E. It includes some > > fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY > > driver, and finally adds the TI CSI2RX wrapper driver. > > > > Tested on TI's J721E with OV5640 sensor. > > > > Paul Kocialkowski (1): > > phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes > > > > Pratyush Yadav (15): > > phy: cdns-dphy: Prepare for Rx support > > phy: cdns-dphy: Allow setting mode > > phy: cdns-dphy: Add Rx support > > media: cadence: csi2rx: Add external DPHY support > > media: cadence: csi2rx: Soft reset the streams before starting capture > > media: cadence: csi2rx: Set the STOP bit when stopping a stream > > media: cadence: csi2rx: Fix stream data configuration > > media: cadence: csi2rx: Turn subdev power on before starting stream > > media: cadence: csi2rx: Add wrappers for subdev calls > > dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX > > dt-bindings: media: Add DT bindings for TI CSI2RX driver > > media: ti-vpe: csi2rx: Add CSI2RX support > > dt-bindings: phy: Convert Cadence DPHY binding to YAML > > dt-bindings: phy: cdns,dphy: make clocks optional > > dt-bindings: phy: cdns,dphy: add power-domains property > > Is there any dependency between patches to various subsystems, if not > please do consider sending a series per subsystem... Without patch 1, patch 5 and later won't build. Without patch 11, patch 13 will not work. > > Thanks > > > > > > .../devicetree/bindings/media/ti,csi2rx.yaml | 70 ++ > > .../devicetree/bindings/phy/cdns,dphy.txt | 20 - > > .../devicetree/bindings/phy/cdns,dphy.yaml| 52 + > > MAINTAINERS | 7 + > > drivers/dma/ti/k3-psil-j721e.c| 10 + > > drivers/media/platform/Kconfig| 11 + > > drivers/media/platform/cadence/cdns-csi2rx.c | 269 - > > drivers/media/platform/ti-vpe/Makefile| 1 + > > drivers/media/platform/ti-vpe/ti-csi2rx.c | 964 ++ > > drivers/phy/cadence/cdns-dphy.c | 407 +++- > > include/linux/phy/phy-mipi-dphy.h | 13 + > > 11 files changed, 1754 insertions(+), 70 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/media/ti,csi2rx.yaml > > delete mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.txt > > create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.yaml > > create mode 100644 drivers/media/platform/ti-vpe/ti-csi2rx.c > > > > -- > > 2.30.0 > > -- > ~Vinod -- Regards, Pratyush Yadav Texas Instruments Inc.
Re: [PATCH 00/16] CSI2RX support on J721E
On 30-03-21, 23:03, Pratyush Yadav wrote: > Hi, > > This series adds support for CSI2 capture on J721E. It includes some > fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY > driver, and finally adds the TI CSI2RX wrapper driver. > > Tested on TI's J721E with OV5640 sensor. > > Paul Kocialkowski (1): > phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes > > Pratyush Yadav (15): > phy: cdns-dphy: Prepare for Rx support > phy: cdns-dphy: Allow setting mode > phy: cdns-dphy: Add Rx support > media: cadence: csi2rx: Add external DPHY support > media: cadence: csi2rx: Soft reset the streams before starting capture > media: cadence: csi2rx: Set the STOP bit when stopping a stream > media: cadence: csi2rx: Fix stream data configuration > media: cadence: csi2rx: Turn subdev power on before starting stream > media: cadence: csi2rx: Add wrappers for subdev calls > dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX > dt-bindings: media: Add DT bindings for TI CSI2RX driver > media: ti-vpe: csi2rx: Add CSI2RX support > dt-bindings: phy: Convert Cadence DPHY binding to YAML > dt-bindings: phy: cdns,dphy: make clocks optional > dt-bindings: phy: cdns,dphy: add power-domains property Is there any dependency between patches to various subsystems, if not please do consider sending a series per subsystem... Thanks > > .../devicetree/bindings/media/ti,csi2rx.yaml | 70 ++ > .../devicetree/bindings/phy/cdns,dphy.txt | 20 - > .../devicetree/bindings/phy/cdns,dphy.yaml| 52 + > MAINTAINERS | 7 + > drivers/dma/ti/k3-psil-j721e.c| 10 + > drivers/media/platform/Kconfig| 11 + > drivers/media/platform/cadence/cdns-csi2rx.c | 269 - > drivers/media/platform/ti-vpe/Makefile| 1 + > drivers/media/platform/ti-vpe/ti-csi2rx.c | 964 ++ > drivers/phy/cadence/cdns-dphy.c | 407 +++- > include/linux/phy/phy-mipi-dphy.h | 13 + > 11 files changed, 1754 insertions(+), 70 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/ti,csi2rx.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.txt > create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.yaml > create mode 100644 drivers/media/platform/ti-vpe/ti-csi2rx.c > > -- > 2.30.0 -- ~Vinod
[PATCH 00/16] CSI2RX support on J721E
Hi, This series adds support for CSI2 capture on J721E. It includes some fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY driver, and finally adds the TI CSI2RX wrapper driver. Tested on TI's J721E with OV5640 sensor. Paul Kocialkowski (1): phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes Pratyush Yadav (15): phy: cdns-dphy: Prepare for Rx support phy: cdns-dphy: Allow setting mode phy: cdns-dphy: Add Rx support media: cadence: csi2rx: Add external DPHY support media: cadence: csi2rx: Soft reset the streams before starting capture media: cadence: csi2rx: Set the STOP bit when stopping a stream media: cadence: csi2rx: Fix stream data configuration media: cadence: csi2rx: Turn subdev power on before starting stream media: cadence: csi2rx: Add wrappers for subdev calls dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX dt-bindings: media: Add DT bindings for TI CSI2RX driver media: ti-vpe: csi2rx: Add CSI2RX support dt-bindings: phy: Convert Cadence DPHY binding to YAML dt-bindings: phy: cdns,dphy: make clocks optional dt-bindings: phy: cdns,dphy: add power-domains property .../devicetree/bindings/media/ti,csi2rx.yaml | 70 ++ .../devicetree/bindings/phy/cdns,dphy.txt | 20 - .../devicetree/bindings/phy/cdns,dphy.yaml| 52 + MAINTAINERS | 7 + drivers/dma/ti/k3-psil-j721e.c| 10 + drivers/media/platform/Kconfig| 11 + drivers/media/platform/cadence/cdns-csi2rx.c | 269 - drivers/media/platform/ti-vpe/Makefile| 1 + drivers/media/platform/ti-vpe/ti-csi2rx.c | 964 ++ drivers/phy/cadence/cdns-dphy.c | 407 +++- include/linux/phy/phy-mipi-dphy.h | 13 + 11 files changed, 1754 insertions(+), 70 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/ti,csi2rx.yaml delete mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.txt create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.yaml create mode 100644 drivers/media/platform/ti-vpe/ti-csi2rx.c -- 2.30.0
