Re: [PATCH 00/18] Rid W=1 warnings from GFS2
On Fri, 09 Apr 2021, Andreas Gruenbacher wrote: > Hi Lee, > > On Tue, Apr 6, 2021 at 1:54 PM Lee Jones wrote: > > > > These have been on the list for a couple of weeks now. > > thanks for your fixes, I've gone through them now. I've fixed up some > comments instead of "demoting" them to make the patch somewhat less > destructive, and I found a few more minor issues along the way. Those > changes are now all in the following commit: > > > https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?id=c551f66c5dfef You squashed all of the changes across all of the files into one-big-patch (tm)? I haven't seen anyone do that for years. Hopefully none of it needs reverting or bisecting! Anyway, thanks for merging. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 00/18] Rid W=1 warnings from GFS2
Hi Lee, On Tue, Apr 6, 2021 at 1:54 PM Lee Jones wrote: > > > These have been on the list for a couple of weeks now. thanks for your fixes, I've gone through them now. I've fixed up some comments instead of "demoting" them to make the patch somewhat less destructive, and I found a few more minor issues along the way. Those changes are now all in the following commit: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?id=c551f66c5dfef Thanks, Andreas
Re: [PATCH 00/18] Rid W=1 warnings from GFS2
On Tue, 06 Apr 2021, Bob Peterson wrote: > - Original Message - > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > > > > > > Lee Jones (18): > > > fs: gfs2: dir: Finish off mostly complete headers demote others > > > fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant > > > ones > > > fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others > > > fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote > > > others > > > fs: gfs2: log: Fix a couple of param descriptions and demote > > > non-conformant headers > > > fs: gfs2: lops: Help out worthy kernel-doc headers and demote others > > > fs: gfs2: glock: Fix some deficient kernel-doc headers and demote > > > non-conformant ones > > > fs: gfs2: aops: Fix a little potential doc-rot > > > fs: gfs2: meta_io: Add missing description for 'rahead' param > > > fs: gfs2: inode: Fix worthy function headers demote others > > > fs: gfs2: file: Strip out superflouous param description and demote > > > kernel-doc abuse > > > fs: gfs2: ops_fstype: Fix a little doc-rot > > > fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' > > > fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours > > > fs: gfs2: recovery: Provide missing param descriptions and remove one > > > other > > > fs: gfs2: super: Fix kernel-doc issues where feasible demote one other > > > fs: gfs2: util: Fix one conformant kernel-doc header and demote a > > > bunch of abuses > > > fs: gfs2: lock_dlm: Demote incomplete kernel-doc header > > > > These have been on the list for a couple of weeks now. > > > > Is there anything I can do to help expedite their merge? > > > > I'm concerned since -rc6 has just been released. > > Hi Lee, > > Thanks for your patches. Andreas and I have a slight disagreement about them. > I wanted to merge them, but Andreas is concerned that there may be some > cases in which we should get rid of parameter descriptions altogether. > So I've been waiting for Andreas to review them all before we push them. > Also, the dir.c patch might be out of date because of a patch I recently did > that > was recently added to for-next. I'll work with Andreas to expedite them so > they can go into the next merge window. Thanks for the update Bob. My initial response to that would be; this patch-set ensures all of the warnings are taken care of. Removal of superfluous documentation could be easily undertaken as part of a subsequent effort. It would be good to have these warnings quashed for v5.13. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 00/18] Rid W=1 warnings from GFS2
- Original Message - > On Fri, 26 Mar 2021, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (18): > > fs: gfs2: dir: Finish off mostly complete headers demote others > > fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant > > ones > > fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others > > fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote > > others > > fs: gfs2: log: Fix a couple of param descriptions and demote > > non-conformant headers > > fs: gfs2: lops: Help out worthy kernel-doc headers and demote others > > fs: gfs2: glock: Fix some deficient kernel-doc headers and demote > > non-conformant ones > > fs: gfs2: aops: Fix a little potential doc-rot > > fs: gfs2: meta_io: Add missing description for 'rahead' param > > fs: gfs2: inode: Fix worthy function headers demote others > > fs: gfs2: file: Strip out superflouous param description and demote > > kernel-doc abuse > > fs: gfs2: ops_fstype: Fix a little doc-rot > > fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' > > fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours > > fs: gfs2: recovery: Provide missing param descriptions and remove one > > other > > fs: gfs2: super: Fix kernel-doc issues where feasible demote one other > > fs: gfs2: util: Fix one conformant kernel-doc header and demote a > > bunch of abuses > > fs: gfs2: lock_dlm: Demote incomplete kernel-doc header > > These have been on the list for a couple of weeks now. > > Is there anything I can do to help expedite their merge? > > I'm concerned since -rc6 has just been released. Hi Lee, Thanks for your patches. Andreas and I have a slight disagreement about them. I wanted to merge them, but Andreas is concerned that there may be some cases in which we should get rid of parameter descriptions altogether. So I've been waiting for Andreas to review them all before we push them. Also, the dir.c patch might be out of date because of a patch I recently did that was recently added to for-next. I'll work with Andreas to expedite them so they can go into the next merge window. Regards, Bob Peterson
Re: [PATCH 00/18] Rid W=1 warnings from GFS2
On Fri, 26 Mar 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (18): > fs: gfs2: dir: Finish off mostly complete headers demote others > fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant > ones > fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others > fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote > others > fs: gfs2: log: Fix a couple of param descriptions and demote > non-conformant headers > fs: gfs2: lops: Help out worthy kernel-doc headers and demote others > fs: gfs2: glock: Fix some deficient kernel-doc headers and demote > non-conformant ones > fs: gfs2: aops: Fix a little potential doc-rot > fs: gfs2: meta_io: Add missing description for 'rahead' param > fs: gfs2: inode: Fix worthy function headers demote others > fs: gfs2: file: Strip out superflouous param description and demote > kernel-doc abuse > fs: gfs2: ops_fstype: Fix a little doc-rot > fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' > fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours > fs: gfs2: recovery: Provide missing param descriptions and remove one > other > fs: gfs2: super: Fix kernel-doc issues where feasible demote one other > fs: gfs2: util: Fix one conformant kernel-doc header and demote a > bunch of abuses > fs: gfs2: lock_dlm: Demote incomplete kernel-doc header These have been on the list for a couple of weeks now. Is there anything I can do to help expedite their merge? I'm concerned since -rc6 has just been released. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH 00/18] Rid W=1 warnings from GFS2
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (18): fs: gfs2: dir: Finish off mostly complete headers demote others fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers fs: gfs2: lops: Help out worthy kernel-doc headers and demote others fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones fs: gfs2: aops: Fix a little potential doc-rot fs: gfs2: meta_io: Add missing description for 'rahead' param fs: gfs2: inode: Fix worthy function headers demote others fs: gfs2: file: Strip out superflouous param description and demote kernel-doc abuse fs: gfs2: ops_fstype: Fix a little doc-rot fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours fs: gfs2: recovery: Provide missing param descriptions and remove one other fs: gfs2: super: Fix kernel-doc issues where feasible demote one other fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses fs: gfs2: lock_dlm: Demote incomplete kernel-doc header fs/gfs2/aops.c | 5 + fs/gfs2/bmap.c | 4 ++-- fs/gfs2/dir.c| 35 +-- fs/gfs2/file.c | 3 +-- fs/gfs2/glock.c | 9 - fs/gfs2/glops.c | 18 ++ fs/gfs2/inode.c | 22 -- fs/gfs2/lock_dlm.c | 3 +-- fs/gfs2/log.c| 11 --- fs/gfs2/lops.c | 13 +++-- fs/gfs2/meta_io.c| 1 + fs/gfs2/ops_fstype.c | 7 ++- fs/gfs2/quota.c | 2 +- fs/gfs2/recovery.c | 3 ++- fs/gfs2/rgrp.c | 4 +++- fs/gfs2/super.c | 13 ++--- fs/gfs2/util.c | 19 ++- fs/gfs2/xattr.c | 25 +++-- 18 files changed, 83 insertions(+), 114 deletions(-) Cc: Andreas Gruenbacher Cc: Bob Peterson Cc: cluster-de...@redhat.com -- 2.27.0
