Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
On Fri, 12 Mar 2021 09:47:08 +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (30): > scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot > scsi: ufs: ufshcd: Fix incorrectly named > ufshcd_find_max_sup_active_icc_level() > scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours > scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions > scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp() > scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented > functions/params > scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy() > scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions > scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues > scsi: qla2xxx: qla_nx2: Fix incorrectly named function > qla8044_check_temp() > scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions > scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function > lpfc_debugfs_commonxripools_data() > scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions > scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the > heap > scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue > scsi: ufs: cdns-pltfrm: Supply function names for headers > scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest() > scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for > esas2r_log_master() > scsi: be2iscsi: be_iscsi: Fix incorrect naming of > beiscsi_iface_config_vlan() > scsi: be2iscsi: be_main: Provide missing function name in header > scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header > scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in > description > scsi: initio: Remove unused variable 'prev' > scsi: a100u2w: Remove unused variable 'bios_phys' > scsi: dc395x: Fix incorrect naming in function headers > scsi: atp870u: Fix naming and demote incorrect and non-conformant > kernel-doc header > scsi: myrs: Remove a couple of unused 'status' variables > scsi: 3w-: Remove 2 unused variables 'response_que_value' and > 'tw_dev' > scsi: 3w-9xxx: Remove a few set but unused variables > scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev' > > [...] Applied to 5.13/scsi-queue, thanks! [01/30] scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot https://git.kernel.org/mkp/scsi/c/cf9e575e62a4 [02/30] scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level() https://git.kernel.org/mkp/scsi/c/11eea9b3fd4d [03/30] scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours https://git.kernel.org/mkp/scsi/c/0bb87e01d815 [04/30] scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions https://git.kernel.org/mkp/scsi/c/a3dbf5145d01 [05/30] scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp() https://git.kernel.org/mkp/scsi/c/0dbea7c18873 [06/30] scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params https://git.kernel.org/mkp/scsi/c/54cb88dc3083 [07/30] scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy() https://git.kernel.org/mkp/scsi/c/775b4d65a6fb [08/30] scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions https://git.kernel.org/mkp/scsi/c/381095668d51 [09/30] scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues https://git.kernel.org/mkp/scsi/c/782a1ab33f71 [10/30] scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp() https://git.kernel.org/mkp/scsi/c/a736e4490442 [11/30] scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions https://git.kernel.org/mkp/scsi/c/dc49ab48a77c [12/30] scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data() https://git.kernel.org/mkp/scsi/c/2c6400b78243 [13/30] scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions https://git.kernel.org/mkp/scsi/c/3145d2d69e16 [14/30] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap https://git.kernel.org/mkp/scsi/c/a7a11b6cfec2 [15/30] scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue https://git.kernel.org/mkp/scsi/c/f6b35a75042b [16/30] scsi: ufs: cdns-pltfrm: Supply function names for headers https://git.kernel.org/mkp/scsi/c/d5db88b0ce89 [17/30] scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest() https://git.kernel.org/mkp/scsi/c/181883786427 [18/30] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master() https://git.kernel.org/mkp/scsi/c/1c666a3e0a54 [19/30] scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan() https://git.kernel.org/mkp/scsi/c/1b8a7ee9308e [20/30]
Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
On Tue, 16 Mar 2021, Martin K. Petersen wrote: > > Lee, > > > Would you like them in 1 or 2 sets? > > As long as they are trivial, one set is fine. > > What does help is to split by complexity. In your two previous series I > would have preferred the mpt3sas and bfa patches that actually change > code to be posted separately. Just to make sure they don't get lost in a > sea of trivial changes. > > IOW, if the patches contain substantial functional changes I'd prefer > them to be separate from all the kernel-doc, function prototype, > etc. fixes. At the moment, my process involves a script which opens each file and works it's way through the reported issues. I'll take a look through the remaining patches and try to pull out any that are more complex. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
Lee, > Would you like them in 1 or 2 sets? As long as they are trivial, one set is fine. What does help is to split by complexity. In your two previous series I would have preferred the mpt3sas and bfa patches that actually change code to be posted separately. Just to make sure they don't get lost in a sea of trivial changes. IOW, if the patches contain substantial functional changes I'd prefer them to be separate from all the kernel-doc, function prototype, etc. fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
On Mon, 15 Mar 2021, Martin K. Petersen wrote: > > Lee, > > > This set is part of a larger effort attempting to clean-up W=1 kernel > > builds, which are currently overwhelmingly riddled with niggly little > > warnings. > > Applied to 5.13/scsi-staging, thanks! Superstar! Thanks Martin. Just FYI, there are more 44 more patches left until clean. Would you like them in 1 or 2 sets? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
Lee, > This set is part of a larger effort attempting to clean-up W=1 kernel > builds, which are currently overwhelmingly riddled with niggly little > warnings. Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
[PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (30): scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level() scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp() scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy() scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp() scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data() scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue scsi: ufs: cdns-pltfrm: Supply function names for headers scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest() scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master() scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan() scsi: be2iscsi: be_main: Provide missing function name in header scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description scsi: initio: Remove unused variable 'prev' scsi: a100u2w: Remove unused variable 'bios_phys' scsi: dc395x: Fix incorrect naming in function headers scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header scsi: myrs: Remove a couple of unused 'status' variables scsi: 3w-: Remove 2 unused variables 'response_que_value' and 'tw_dev' scsi: 3w-9xxx: Remove a few set but unused variables scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev' drivers/scsi/3w-9xxx.c | 14 -- drivers/scsi/3w-sas.c| 10 ++ drivers/scsi/3w-.c | 6 ++ drivers/scsi/a100u2w.c | 2 -- drivers/scsi/atp870u.c | 7 +++ drivers/scsi/be2iscsi/be_iscsi.c | 2 +- drivers/scsi/be2iscsi/be_main.c | 1 + drivers/scsi/be2iscsi/be_mgmt.c | 2 +- drivers/scsi/bfa/bfa_fcs_lport.c | 20 ++-- drivers/scsi/bnx2i/bnx2i_sysfs.c | 2 +- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 2 +- drivers/scsi/dc395x.c| 6 +++--- drivers/scsi/esas2r/esas2r_log.c | 7 +++ drivers/scsi/initio.c| 5 ++--- drivers/scsi/libfc/fc_fcp.c | 2 +- drivers/scsi/libfc/fc_rport.c| 2 +- drivers/scsi/lpfc/lpfc_attr.c| 12 ++-- drivers/scsi/lpfc/lpfc_bsg.c | 6 +++--- drivers/scsi/lpfc/lpfc_debugfs.c | 2 +- drivers/scsi/lpfc/lpfc_nvme.c| 2 +- drivers/scsi/lpfc/lpfc_scsi.c| 24 drivers/scsi/mpt3sas/mpt3sas_config.c| 10 +- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 16 drivers/scsi/mpt3sas/mpt3sas_transport.c | 7 --- drivers/scsi/myrs.c | 6 ++ drivers/scsi/qla2xxx/qla_mr.c| 4 ++-- drivers/scsi/qla2xxx/qla_nx2.c | 2 +- drivers/scsi/qla2xxx/qla_target.c| 4 ++-- drivers/scsi/ufs/cdns-pltfrm.c | 4 drivers/scsi/ufs/ufshcd.c| 2 +- 30 files changed, 96 insertions(+), 95 deletions(-) Cc: Adam Radford Cc: Alan Cox Cc: Ali Akcaagac Cc: Alim Akhtar Cc: Andre Hedrick Cc: Anil Gurumurthy Cc: Anil Veerabhadrappa Cc: Avri Altman Cc: Bas Vermeulen Cc: Bradley Grove Cc: Brian Macy Cc: Christoph Hellwig Cc: "C.L. Huang" Cc: dc3...@twibble.org Cc: de Melo Cc: Dick Kennedy Cc: Dimitris Michailidis Cc: Doug Ledford Cc: Eddie Wai Cc: Erich Chen Cc: gr-qlogic-storage-upstr...@marvell.com Cc: Hannes Reinecke Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: James Smart Cc: Jamie Lenehan Cc: Jan Kotas Cc: Jitendra Bhivare Cc: Joel Jacobson Cc: Karen Xie Cc: Ketan Mukadam Cc: Kurt Garloff Cc: "Leonard N. Zubkoff" Cc: linux-driv...@broadcom.com Cc: Linux GmbH Cc: linux-s...@vger.kernel.org Cc: Manish Rangankar Cc: Marcelo Tosatti Cc: "Martin K. Petersen" Cc: mpt-fusionlinux@avagotech.com Cc: mpt-fusionlinux@broadcom.com Cc: Nathaniel Clark Cc: "Nicholas A. Bellinger" Cc: Nilesh Javali Cc:
