Re: [PATCH 01/10] mfd: cros_ec: Fix the comment on cros_ec_remove()
On Wed, 18 Jun 2014, Doug Anderson wrote: > Lee, > > On Wed, Jun 18, 2014 at 12:57 AM, Lee Jones wrote: > > On Mon, 16 Jun 2014, Doug Anderson wrote: > > > >> From: Bill Richardson > >> > >> This comment was incorrect, so update it. > >> > >> Signed-off-by: Bill Richardson > >> Signed-off-by: Simon Glass > > > > How many people did it take to write this patch? ;) > > > > Acked-by: Lee Jones > > There's gotta be a joke here about how many Google engineers it takes > to fix a comment. In this case I think the answer is 3: one to fix > the comment, one to clean it up, and one to send it upstream. ;) ... and one to hold the ladder. No, wait! ;) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/10] mfd: cros_ec: Fix the comment on cros_ec_remove()
Lee, On Wed, Jun 18, 2014 at 12:57 AM, Lee Jones wrote: > On Mon, 16 Jun 2014, Doug Anderson wrote: > >> From: Bill Richardson >> >> This comment was incorrect, so update it. >> >> Signed-off-by: Bill Richardson >> Signed-off-by: Simon Glass > > How many people did it take to write this patch? ;) > > Acked-by: Lee Jones There's gotta be a joke here about how many Google engineers it takes to fix a comment. In this case I think the answer is 3: one to fix the comment, one to clean it up, and one to send it upstream. ;) -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/10] mfd: cros_ec: Fix the comment on cros_ec_remove()
On Mon, 16 Jun 2014, Doug Anderson wrote: > From: Bill Richardson > > This comment was incorrect, so update it. > > Signed-off-by: Bill Richardson > Signed-off-by: Simon Glass How many people did it take to write this patch? ;) Acked-by: Lee Jones > Signed-off-by: Doug Anderson > --- > include/linux/mfd/cros_ec.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > index 887ef4f..7e9fe6e 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -148,8 +148,7 @@ int cros_ec_prepare_tx(struct cros_ec_device *ec_dev, > /** > * cros_ec_remove - Remove a ChromeOS EC > * > - * Call this to deregister a ChromeOS EC. After this you should call > - * cros_ec_free(). > + * Call this to deregister a ChromeOS EC, then clean up any private data. > * > * @ec_dev: Device to register > * @return 0 if ok, -ve on error -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/10] mfd: cros_ec: Fix the comment on cros_ec_remove()
On Mon, 16 Jun 2014, Doug Anderson wrote: From: Bill Richardson wfric...@chromium.org This comment was incorrect, so update it. Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Simon Glass s...@chromium.org How many people did it take to write this patch? ;) Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Doug Anderson diand...@chromium.org --- include/linux/mfd/cros_ec.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h index 887ef4f..7e9fe6e 100644 --- a/include/linux/mfd/cros_ec.h +++ b/include/linux/mfd/cros_ec.h @@ -148,8 +148,7 @@ int cros_ec_prepare_tx(struct cros_ec_device *ec_dev, /** * cros_ec_remove - Remove a ChromeOS EC * - * Call this to deregister a ChromeOS EC. After this you should call - * cros_ec_free(). + * Call this to deregister a ChromeOS EC, then clean up any private data. * * @ec_dev: Device to register * @return 0 if ok, -ve on error -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/10] mfd: cros_ec: Fix the comment on cros_ec_remove()
Lee, On Wed, Jun 18, 2014 at 12:57 AM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 16 Jun 2014, Doug Anderson wrote: From: Bill Richardson wfric...@chromium.org This comment was incorrect, so update it. Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Simon Glass s...@chromium.org How many people did it take to write this patch? ;) Acked-by: Lee Jones lee.jo...@linaro.org There's gotta be a joke here about how many Google engineers it takes to fix a comment. In this case I think the answer is 3: one to fix the comment, one to clean it up, and one to send it upstream. ;) -Doug -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/10] mfd: cros_ec: Fix the comment on cros_ec_remove()
On Wed, 18 Jun 2014, Doug Anderson wrote: Lee, On Wed, Jun 18, 2014 at 12:57 AM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 16 Jun 2014, Doug Anderson wrote: From: Bill Richardson wfric...@chromium.org This comment was incorrect, so update it. Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Simon Glass s...@chromium.org How many people did it take to write this patch? ;) Acked-by: Lee Jones lee.jo...@linaro.org There's gotta be a joke here about how many Google engineers it takes to fix a comment. In this case I think the answer is 3: one to fix the comment, one to clean it up, and one to send it upstream. ;) ... and one to hold the ladder. No, wait! ;) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 01/10] mfd: cros_ec: Fix the comment on cros_ec_remove()
From: Bill Richardson This comment was incorrect, so update it. Signed-off-by: Bill Richardson Signed-off-by: Simon Glass Signed-off-by: Doug Anderson --- include/linux/mfd/cros_ec.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h index 887ef4f..7e9fe6e 100644 --- a/include/linux/mfd/cros_ec.h +++ b/include/linux/mfd/cros_ec.h @@ -148,8 +148,7 @@ int cros_ec_prepare_tx(struct cros_ec_device *ec_dev, /** * cros_ec_remove - Remove a ChromeOS EC * - * Call this to deregister a ChromeOS EC. After this you should call - * cros_ec_free(). + * Call this to deregister a ChromeOS EC, then clean up any private data. * * @ec_dev: Device to register * @return 0 if ok, -ve on error -- 2.0.0.526.g5318336 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 01/10] mfd: cros_ec: Fix the comment on cros_ec_remove()
From: Bill Richardson wfric...@chromium.org This comment was incorrect, so update it. Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org --- include/linux/mfd/cros_ec.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h index 887ef4f..7e9fe6e 100644 --- a/include/linux/mfd/cros_ec.h +++ b/include/linux/mfd/cros_ec.h @@ -148,8 +148,7 @@ int cros_ec_prepare_tx(struct cros_ec_device *ec_dev, /** * cros_ec_remove - Remove a ChromeOS EC * - * Call this to deregister a ChromeOS EC. After this you should call - * cros_ec_free(). + * Call this to deregister a ChromeOS EC, then clean up any private data. * * @ec_dev: Device to register * @return 0 if ok, -ve on error -- 2.0.0.526.g5318336 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
