Re: [PATCH 02/10] drm/virtio: fix endianness in primary_plane_update

[Jason Wang]

On 2016年12月06日 23:40, Michael S. Tsirkin wrote:

virtio_gpu_cmd_transfer_to_host_2d expects x and y
parameters in LE, but virtio_gpu_primary_plane_update
passes in the CPU format instead.

Signed-off-by: Michael S. Tsirkin 
---
  drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Jason Wang 



diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c 
b/drivers/gpu/drm/virtio/virtgpu_plane.c
index ba28c0f..1fda965 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -88,8 +88,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane 
*plane,
(vgdev, handle, 0,
 cpu_to_le32(plane->state->src_w >> 16),
 cpu_to_le32(plane->state->src_h >> 16),
-plane->state->src_x >> 16,
-plane->state->src_y >> 16, NULL);
+cpu_to_le32(plane->state->src_x >> 16),
+cpu_to_le32(plane->state->src_y >> 16), NULL);
}
} else {
handle = 0;

Re: [PATCH 02/10] drm/virtio: fix endianness in primary_plane_update

[Jason Wang]

On 2016年12月06日 23:40, Michael S. Tsirkin wrote:

virtio_gpu_cmd_transfer_to_host_2d expects x and y
parameters in LE, but virtio_gpu_primary_plane_update
passes in the CPU format instead.

Signed-off-by: Michael S. Tsirkin 
---
  drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Jason Wang 



diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c 
b/drivers/gpu/drm/virtio/virtgpu_plane.c
index ba28c0f..1fda965 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -88,8 +88,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane 
*plane,
(vgdev, handle, 0,
 cpu_to_le32(plane->state->src_w >> 16),
 cpu_to_le32(plane->state->src_h >> 16),
-plane->state->src_x >> 16,
-plane->state->src_y >> 16, NULL);
+cpu_to_le32(plane->state->src_x >> 16),
+cpu_to_le32(plane->state->src_y >> 16), NULL);
}
} else {
handle = 0;

[PATCH 02/10] drm/virtio: fix endianness in primary_plane_update

[Michael S. Tsirkin]

virtio_gpu_cmd_transfer_to_host_2d expects x and y
parameters in LE, but virtio_gpu_primary_plane_update
passes in the CPU format instead.

Signed-off-by: Michael S. Tsirkin 
---
 drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c 
b/drivers/gpu/drm/virtio/virtgpu_plane.c
index ba28c0f..1fda965 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -88,8 +88,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane 
*plane,
(vgdev, handle, 0,
 cpu_to_le32(plane->state->src_w >> 16),
 cpu_to_le32(plane->state->src_h >> 16),
-plane->state->src_x >> 16,
-plane->state->src_y >> 16, NULL);
+cpu_to_le32(plane->state->src_x >> 16),
+cpu_to_le32(plane->state->src_y >> 16), NULL);
}
} else {
handle = 0;
-- 
MST

[PATCH 02/10] drm/virtio: fix endianness in primary_plane_update

[Michael S. Tsirkin]

virtio_gpu_cmd_transfer_to_host_2d expects x and y
parameters in LE, but virtio_gpu_primary_plane_update
passes in the CPU format instead.

Signed-off-by: Michael S. Tsirkin 
---
 drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c 
b/drivers/gpu/drm/virtio/virtgpu_plane.c
index ba28c0f..1fda965 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -88,8 +88,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane 
*plane,
(vgdev, handle, 0,
 cpu_to_le32(plane->state->src_w >> 16),
 cpu_to_le32(plane->state->src_h >> 16),
-plane->state->src_x >> 16,
-plane->state->src_y >> 16, NULL);
+cpu_to_le32(plane->state->src_x >> 16),
+cpu_to_le32(plane->state->src_y >> 16), NULL);
}
} else {
handle = 0;
-- 
MST