Re: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types

2021-03-02 Thread Alexey Dobriyan 
On Mon, Mar 01, 2021 at 10:19:50AM +, Russell King - ARM Linux admin wrote:
> On Sun, Feb 28, 2021 at 07:59:16PM +0300, Alexey Dobriyan wrote:
> > From 72842f89ae91a4d02ea29604f87c373052bd3f64 Mon Sep 17 00:00:00 2001
> > From: Alexey Dobriyan 
> > Date: Tue, 9 Feb 2021 14:37:40 +0300
> > Subject: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types
> > 
> > Generate arch/arm/include/generated/asm/mach-types.h without include
> > guard.
> 
> The fundamental question of "why" is missing from this commit message.
> Are we making this change to all kernel headers?

Apparently, no. Linus doesn't like it.

Re: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types

2021-03-01 Thread Russell King - ARM Linux admin 
On Sun, Feb 28, 2021 at 07:59:16PM +0300, Alexey Dobriyan wrote:
> From 72842f89ae91a4d02ea29604f87c373052bd3f64 Mon Sep 17 00:00:00 2001
> From: Alexey Dobriyan 
> Date: Tue, 9 Feb 2021 14:37:40 +0300
> Subject: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types
> 
> Generate arch/arm/include/generated/asm/mach-types.h without include
> guard.

The fundamental question of "why" is missing from this commit message.
Are we making this change to all kernel headers?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

[PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types

2021-02-28 Thread Alexey Dobriyan 
>From 72842f89ae91a4d02ea29604f87c373052bd3f64 Mon Sep 17 00:00:00 2001
From: Alexey Dobriyan 
Date: Tue, 9 Feb 2021 14:37:40 +0300
Subject: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types

Generate arch/arm/include/generated/asm/mach-types.h without include
guard.

Signed-off-by: Alexey Dobriyan 
---
 arch/arm/tools/gen-mach-types | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/tools/gen-mach-types b/arch/arm/tools/gen-mach-types
index cbe1c33bb871..c28cd4b50f76 100644
--- a/arch/arm/tools/gen-mach-types
+++ b/arch/arm/tools/gen-mach-types
@@ -23,12 +23,11 @@ NF == 3 {
 
 
 END{
+ printf("#pragma once\n");
  printf("/*\n");
  printf(" * This was automagically generated from %s!\n", FILENAME);
  printf(" * Do NOT edit\n");
- printf(" */\n\n");
- printf("#ifndef __ASM_ARM_MACH_TYPE_H\n");
- printf("#define __ASM_ARM_MACH_TYPE_H\n\n");
+ printf(" */\n");
  printf("#ifndef __ASSEMBLY__\n");
  printf("/* The type of machine we're running on */\n");
  printf("extern unsigned int __machine_arch_type;\n");
@@ -68,6 +67,5 @@ END   {
 
  printf("\n#ifndef machine_arch_type\n");
  printf("#define machine_arch_type\t__machine_arch_type\n");
- printf("#endif\n\n");
  printf("#endif\n");
}
-- 
2.29.2