[PATCH 02/13] Don't touch fs_struct in usermodehelper

2007-10-22 Thread Bharata B Rao
From: Jan Blunck <[EMAIL PROTECTED]>

This test seems to be unnecessary since we always have rootfs mounted before
calling a usermodehelper.

Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]>
Signed-off-by: Jan Blunck <[EMAIL PROTECTED]>
Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]>
Acked-by: Christoph Hellwig <[EMAIL PROTECTED]>
---
 kernel/kmod.c |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -173,10 +173,7 @@ static int call_usermodehelper(void 
 */
set_user_nice(current, 0);
 
-   retval = -EPERM;
-   if (current->fs->root)
-   retval = kernel_execve(sub_info->path,
-   sub_info->argv, sub_info->envp);
+   retval = kernel_execve(sub_info->path, sub_info->argv, sub_info->envp);
 
/* Exec failed? */
sub_info->retval = retval;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 02/13] Don't touch fs_struct in usermodehelper

2007-10-22 Thread Bharata B Rao
From: Jan Blunck [EMAIL PROTECTED]

This test seems to be unnecessary since we always have rootfs mounted before
calling a usermodehelper.

Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED]
Signed-off-by: Jan Blunck [EMAIL PROTECTED]
Signed-off-by: Bharata B Rao [EMAIL PROTECTED]
Acked-by: Christoph Hellwig [EMAIL PROTECTED]
---
 kernel/kmod.c |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -173,10 +173,7 @@ static int call_usermodehelper(void 
 */
set_user_nice(current, 0);
 
-   retval = -EPERM;
-   if (current-fs-root)
-   retval = kernel_execve(sub_info-path,
-   sub_info-argv, sub_info-envp);
+   retval = kernel_execve(sub_info-path, sub_info-argv, sub_info-envp);
 
/* Exec failed? */
sub_info-retval = retval;
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/