Re: [PATCH 03/14] perf tool: Fix period symbol_conf.field_sep display

[Jiri Olsa]

On Thu, Nov 29, 2012 at 04:56:04PM +0900, Namhyung Kim wrote:
> On Wed, 28 Nov 2012 14:52:38 +0100, Jiri Olsa wrote:
> > Currently we don't properly display hist data with
> > symbol_conf.field_sep separator. We need to display
> > either space or separator.
> >
> > Signed-off-by: Jiri Olsa 
> > Cc: Arnaldo Carvalho de Melo 
> > Cc: Peter Zijlstra 
> > Cc: Ingo Molnar 
> > Cc: Paul Mackerras 
> > Cc: Corey Ashford 
> > Cc: Frederic Weisbecker 
> > Cc: Namhyung Kim 
> > ---
> >  tools/perf/ui/hist.c | 8 ++--
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
> > index 5452960..20a4392 100644
> > --- a/tools/perf/ui/hist.c
> > +++ b/tools/perf/ui/hist.c
> > @@ -523,17 +523,13 @@ int hist_entry__period_snprintf(struct perf_hpp *hpp, 
> > struct hist_entry *he,
> > struct perf_hpp_fmt *fmt;
> > char *start = hpp->buf;
> > int ret;
> > -   bool first = true;
> >  
> > if (symbol_conf.exclude_other && !he->parent)
> > return 0;
> >  
> > perf_hpp__for_each_format(fmt) {
> > -   if (!sep || !first) {
> > -   ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: "  ");
> > -   advance_hpp(hpp, ret);
> > -   first = false;
> > -   }
> > +   ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: "  ");
> > +   advance_hpp(hpp, ret);
> 
> It will display the separator even before the first column so that the
> output can be messed up with this.  I can see that there's a bug setting
> 'first' to false - the line should be moved out of the block otherwise
> it's pointless since we cannot enter the block.

hum, I'll retest

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 03/14] perf tool: Fix period symbol_conf.field_sep display

[Namhyung Kim]

On Wed, 28 Nov 2012 14:52:38 +0100, Jiri Olsa wrote:
> Currently we don't properly display hist data with
> symbol_conf.field_sep separator. We need to display
> either space or separator.
>
> Signed-off-by: Jiri Olsa 
> Cc: Arnaldo Carvalho de Melo 
> Cc: Peter Zijlstra 
> Cc: Ingo Molnar 
> Cc: Paul Mackerras 
> Cc: Corey Ashford 
> Cc: Frederic Weisbecker 
> Cc: Namhyung Kim 
> ---
>  tools/perf/ui/hist.c | 8 ++--
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
> index 5452960..20a4392 100644
> --- a/tools/perf/ui/hist.c
> +++ b/tools/perf/ui/hist.c
> @@ -523,17 +523,13 @@ int hist_entry__period_snprintf(struct perf_hpp *hpp, 
> struct hist_entry *he,
>   struct perf_hpp_fmt *fmt;
>   char *start = hpp->buf;
>   int ret;
> - bool first = true;
>  
>   if (symbol_conf.exclude_other && !he->parent)
>   return 0;
>  
>   perf_hpp__for_each_format(fmt) {
> - if (!sep || !first) {
> - ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: "  ");
> - advance_hpp(hpp, ret);
> - first = false;
> - }
> + ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: "  ");
> + advance_hpp(hpp, ret);

It will display the separator even before the first column so that the
output can be messed up with this.  I can see that there's a bug setting
'first' to false - the line should be moved out of the block otherwise
it's pointless since we cannot enter the block.

Thanks,
Namhyung

>  
>   if (color && fmt->color)
>   ret = fmt->color(fmt, hpp, he);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 03/14] perf tool: Fix period symbol_conf.field_sep display

[Jiri Olsa]

Currently we don't properly display hist data with
symbol_conf.field_sep separator. We need to display
either space or separator.

Signed-off-by: Jiri Olsa 
Cc: Arnaldo Carvalho de Melo 
Cc: Peter Zijlstra 
Cc: Ingo Molnar 
Cc: Paul Mackerras 
Cc: Corey Ashford 
Cc: Frederic Weisbecker 
Cc: Namhyung Kim 
---
 tools/perf/ui/hist.c | 8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
index 5452960..20a4392 100644
--- a/tools/perf/ui/hist.c
+++ b/tools/perf/ui/hist.c
@@ -523,17 +523,13 @@ int hist_entry__period_snprintf(struct perf_hpp *hpp, 
struct hist_entry *he,
struct perf_hpp_fmt *fmt;
char *start = hpp->buf;
int ret;
-   bool first = true;
 
if (symbol_conf.exclude_other && !he->parent)
return 0;
 
perf_hpp__for_each_format(fmt) {
-   if (!sep || !first) {
-   ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: "  ");
-   advance_hpp(hpp, ret);
-   first = false;
-   }
+   ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: "  ");
+   advance_hpp(hpp, ret);
 
if (color && fmt->color)
ret = fmt->color(fmt, hpp, he);
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/